Browse Source

fix: popup parameter not working in firefox

Ahmad Kholid 2 years ago
parent
commit
0c2d548d4d

+ 1 - 1
package.json

@@ -29,7 +29,7 @@
     "*.{js,ts,vue}": "eslint --fix"
   },
   "dependencies": {
-    "@braks/vue-flow": "^0.4.30",
+    "@braks/vue-flow": "^0.4.35",
     "@codemirror/autocomplete": "^6.1.0",
     "@codemirror/lang-css": "^6.0.0",
     "@codemirror/lang-html": "^6.1.0",

+ 1 - 0
src/background/workflowEngine/engine.js

@@ -130,6 +130,7 @@ class WorkflowEngine {
           browser.windows.create({
             type: 'popup',
             width: 480,
+            height: window.screen.availHeight,
             url: browser.runtime.getURL(
               `/params.html?workflowId=${this.workflow.id}`
             ),

+ 2 - 2
src/components/newtab/workflow/WorkflowEditor.vue

@@ -131,8 +131,8 @@ const editor = useVueFlow({
   deleteKeyCode: 'Delete',
   elevateEdgesOnSelect: true,
   defaultZoom: props.data?.zoom ?? 1,
-  minZoom: store.settings.editor.minZoom,
-  maxZoom: store.settings.editor.maxZoom,
+  minZoom: Math.abs(+store.settings.editor.minZoom || 0.5),
+  maxZoom: Math.abs(+store.settings.editor.maxZoom || 1.2),
   multiSelectionKeyCode: isMac ? 'Meta' : 'Control',
   defaultPosition: getPosition(props.data?.position),
   ...props.options,

+ 9 - 8
src/params/App.vue

@@ -159,18 +159,19 @@ function runWorkflow(index, { data, params }) {
     return acc;
   }, {});
   const payload = {
-    ...data,
-    options: {
-      checkParams: false,
-      data: { variables },
+    name: 'background--workflow:execute',
+    data: {
+      ...data,
+      options: {
+        checkParams: false,
+        data: { variables },
+      },
     },
   };
+  const isFirefox = BROWSER_TYPE === 'firefox';
 
   browser.runtime
-    .sendMessage({
-      name: 'background--workflow:execute',
-      data: payload,
-    })
+    .sendMessage(isFirefox ? JSON.stringify(payload) : payload)
     .then(() => {
       deleteWorkflow(index);
     });

+ 1 - 1
yarn.lock

@@ -911,7 +911,7 @@
     "@babel/helper-validator-identifier" "^7.18.6"
     to-fast-properties "^2.0.0"
 
-"@braks/vue-flow@^0.4.30":
+"@braks/vue-flow@^0.4.35":
   version "0.4.35"
   resolved "https://registry.yarnpkg.com/@braks/vue-flow/-/vue-flow-0.4.35.tgz#7d2bbd99d51ded1ebbb2297fe976cc0f1e7dc411"
   integrity sha512-V+tnk/lXf2tUZEC0sIWrlYvr792Dtj9ghiW3Kz2doNeaBC57DMNh2t4Kya/NIG4IXnWO1iOxn3/BosHkaniwrg==