Browse Source

feat: show error message when preview google sheets data

Ahmad Kholid 3 years ago
parent
commit
c1390e60b1
2 changed files with 7 additions and 3 deletions
  1. 6 3
      src/components/newtab/workflow/edit/EditGoogleSheets.vue
  2. 1 0
      src/utils/shared.js

+ 6 - 3
src/components/newtab/workflow/edit/EditGoogleSheets.vue

@@ -81,7 +81,7 @@
         {{ previewDataState.errorMessage }}
       </p>
       <shared-codemirror
-        v-if="previewDataState.data"
+        v-if="previewDataState.data && previewDataState.status !== 'error'"
         :model-value="previewDataState.data"
         readonly
         class="mt-4 max-h-96"
@@ -194,7 +194,9 @@ async function previewData() {
     });
 
     if (response.status !== 200) {
-      throw new Error(response.statusText);
+      const error = await response.json();
+
+      throw new Error(response.statusText || error.statusMessage);
     }
 
     const { values } = await response.json();
@@ -206,7 +208,8 @@ async function previewData() {
 
     previewDataState.status = 'idle';
   } catch (error) {
-    console.error(error);
+    console.dir(error);
+    previewDataState.data = '';
     previewDataState.status = 'error';
     previewDataState.errorMessage = error.message;
   }

+ 1 - 0
src/utils/shared.js

@@ -261,6 +261,7 @@ export const tasks = {
       regexExp: ['g'],
       dataColumn: '',
       saveData: true,
+      includeTags: false,
       addExtraRow: false,
       extraRowValue: '',
       extraRowDataColumn: '',