瀏覽代碼

Merge pull request #694 from mgilangjanuar/dev

enhancement: element selector
Ahmad Kholid 3 年之前
父節點
當前提交
ff5829d707
共有 2 個文件被更改,包括 3 次插入4 次删除
  1. 1 3
      src/content/elementSelector/generateElementsSelector.js
  2. 2 1
      src/lib/findSelector.js

+ 1 - 3
src/content/elementSelector/generateElementsSelector.js

@@ -47,11 +47,9 @@ export default function ({
       });
       });
     }
     }
   } else {
   } else {
-    const tagName = selectedElement.tagName.toLowerCase();
-    const candidate = findSelector(selectedElement, finderOptions);
     selector =
     selector =
       selectorType === 'css'
       selectorType === 'css'
-        ? `${candidate.startsWith(tagName) ? '' : tagName}${candidate}`
+        ? findSelector(selectedElement, finderOptions)
         : generateXPath(selectedElement);
         : generateXPath(selectedElement);
   }
   }
 
 

+ 2 - 1
src/lib/findSelector.js

@@ -1,6 +1,7 @@
 import { finder as finderLib } from '@medv/finder';
 import { finder as finderLib } from '@medv/finder';
 
 
-const ariaAttrs = ['aria-label', 'aria-labelledby'];
+// const ariaAttrs = ['aria-label', 'aria-labelledby'];
+const ariaAttrs = ['data-testid'];
 
 
 export const finder = finderLib;
 export const finder = finderLib;