Selaa lähdekoodia

= performance improve

  - using bulk operation instead of iteration if possible
  - terminate loop after condition is met
zavakid 4 vuotta sitten
vanhempi
commit
435db30b7b

+ 1 - 3
parse/src/main/java/com/alibaba/otter/canal/parse/inbound/mysql/tsdb/DatabaseTableMeta.java

@@ -191,9 +191,7 @@ public class DatabaseTableMeta implements TableMetaTSDB {
         try {
             ResultSetPacket packet = connection.query("show databases");
             List<String> schemas = new ArrayList<>();
-            for (String schema : packet.getFieldValues()) {
-                schemas.add(schema);
-            }
+            schemas.addAll(packet.getFieldValues());
 
             for (String schema : schemas) {
                 // filter views

+ 1 - 0
sink/src/main/java/com/alibaba/otter/canal/sink/entry/HeartBeatEntryEventHandler.java

@@ -20,6 +20,7 @@ public class HeartBeatEntryEventHandler extends AbstractCanalEventDownStreamHand
         for (Event event : events) {
             if (event.getEntryType() == EntryType.HEARTBEAT) {
                 existHeartBeat = true;
+                break;
             }
         }