modify

deployer/src/main/java/com/alibaba/otter/canal/deployer/mbean/CanalServerAgent.java

@@ -1,6 +1,8 @@
 package com.alibaba.otter.canal.deployer.mbean;
 
 import org.apache.commons.lang.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 import java.lang.management.ManagementFactory;
@@ -16,6 +18,8 @@ import javax.management.remote.JMXServiceURL;
 
 public class CanalServerAgent implements NotificationListener {
 
+    private static final Logger         logger      = LoggerFactory.getLogger(CanalServerBean.class);
+
     private MBeanServer                 mBeanServer = ManagementFactory.getPlatformMBeanServer();
 
     private String                      ip          = "0.0.0.0";
@@ -47,16 +51,13 @@ public class CanalServerAgent implements NotificationListener {
 
                 LocateRegistry.createRegistry(port);
 
-                // 构造JMXServiceURL
                 JMXServiceURL jmxServiceURL = new JMXServiceURL(
                     "service:jmx:rmi:///jndi/rmi://" + ip + ":" + port + "/jmxrmi");
-                // 创建JMXConnectorServer
                 cs = JMXConnectorServerFactory.newJMXConnectorServer(jmxServiceURL, null, mBeanServer);
-                // 启动
                 cs.start();
             }
         } catch (Exception e) {
-            e.printStackTrace();
+            logger.error(e.getMessage(), e);
         }
     }
 
@@ -65,7 +66,7 @@ public class CanalServerAgent implements NotificationListener {
             try {
                 cs.stop();
             } catch (IOException e) {
-                e.printStackTrace();
+                logger.error(e.getMessage(), e);
             }
         }
     }

deployer/src/main/java/com/alibaba/otter/canal/deployer/mbean/CanalServerBean.java

@@ -2,12 +2,16 @@ package com.alibaba.otter.canal.deployer.mbean;
 
 import com.alibaba.otter.canal.deployer.CanalLauncher;
 import com.alibaba.otter.canal.deployer.CanalStater;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 public class CanalServerBean implements CanalServerMXBean {
 
-    private volatile int status;
+    private static final Logger logger = LoggerFactory.getLogger(CanalServerBean.class);
 
-    private CanalStater  canalStater;
+    private volatile int        status;
+
+    private CanalStater         canalStater;
 
     public CanalServerBean(CanalStater canalStater){
         this.canalStater = canalStater;
@@ -32,7 +36,7 @@ public class CanalServerBean implements CanalServerMXBean {
                 return true;
             }
         } catch (Throwable e) {
-            e.printStackTrace();
+            logger.error(e.getMessage(), e);
         }
         return false;
     }
@@ -46,7 +50,7 @@ public class CanalServerBean implements CanalServerMXBean {
                 return true;
             }
         } catch (Throwable e) {
-            e.printStackTrace();
+            logger.error(e.getMessage(), e);
         }
         return false;
     }