Bladeren bron

remove compiler warning

agapple 10 jaren geleden
bovenliggende
commit
c935f06344
26 gewijzigde bestanden met toevoegingen van 50 en 50 verwijderingen
  1. 1 0
      common/src/main/java/com/alibaba/otter/canal/common/utils/UriUtils.java
  2. 1 1
      dbsync/src/test/java/com/taobao/tddl/dbsync/binlog/DirectLogFetcherTest.java
  3. 1 1
      dbsync/src/test/java/com/taobao/tddl/dbsync/binlog/FileLogFetcherTest.java
  4. 1 1
      driver/src/test/java/com/alibaba/otter/canal/parse/driver/mysql/MysqlConnectorTest.java
  5. 1 0
      filter/src/main/java/com/alibaba/otter/canal/filter/PatternUtils.java
  6. 1 1
      filter/src/test/java/com/alibaba/otter/canal/filter/AviaterFilterTest.java
  7. 1 1
      filter/src/test/java/com/alibaba/otter/canal/filter/MutliAviaterFilterTest.java
  8. 1 1
      meta/src/test/java/com/alibaba/otter/canal/meta/AbstractMetaManagerTest.java
  9. 1 1
      meta/src/test/java/com/alibaba/otter/canal/meta/FileMixedMetaManagerTest.java
  10. 1 1
      meta/src/test/java/com/alibaba/otter/canal/meta/MemoryMetaManagerTest.java
  11. 1 1
      meta/src/test/java/com/alibaba/otter/canal/meta/MixedMetaManagerTest.java
  12. 1 1
      meta/src/test/java/com/alibaba/otter/canal/meta/PeriodMixedMetaManagerTest.java
  13. 1 1
      meta/src/test/java/com/alibaba/otter/canal/meta/ZooKeeperMetaManagerTest.java
  14. 1 2
      parse/src/test/java/com/alibaba/otter/canal/parse/DirectLogFetcherTest.java
  15. 1 1
      parse/src/test/java/com/alibaba/otter/canal/parse/inbound/EventTransactionBufferTest.java
  16. 1 1
      parse/src/test/java/com/alibaba/otter/canal/parse/inbound/mysql/LocalBinlogDumpTest.java
  17. 9 11
      parse/src/test/java/com/alibaba/otter/canal/parse/inbound/mysql/LocalBinlogEventParserTest.java
  18. 1 1
      parse/src/test/java/com/alibaba/otter/canal/parse/inbound/mysql/MysqlDumpTest.java
  19. 11 15
      parse/src/test/java/com/alibaba/otter/canal/parse/inbound/mysql/MysqlEventParserTest.java
  20. 7 2
      parse/src/test/java/com/alibaba/otter/canal/parse/inbound/mysql/SimpleDdlParserTest.java
  21. 1 1
      parse/src/test/java/com/alibaba/otter/canal/parse/index/AbstractLogPositionManagerTest.java
  22. 1 1
      parse/src/test/java/com/alibaba/otter/canal/parse/index/FileMixedLogPositionManagerTest.java
  23. 1 1
      parse/src/test/java/com/alibaba/otter/canal/parse/index/MetaLogPositionManagerTest.java
  24. 1 1
      parse/src/test/java/com/alibaba/otter/canal/parse/index/MixedLogPositionManagerTest.java
  25. 1 1
      parse/src/test/java/com/alibaba/otter/canal/parse/index/PeriodMixedLogPositionManagerTest.java
  26. 1 1
      store/src/test/java/com/alibaba/otter/cancel/store/memory/buffer/MemoryEventStoreMultiThreadTest.java

+ 1 - 0
common/src/main/java/com/alibaba/otter/canal/common/utils/UriUtils.java

@@ -54,6 +54,7 @@ public final class UriUtils {
         }
         String query = uri.getRawQuery();
         HashMap<String, String> params = new HashMap<String, String>();
+        @SuppressWarnings("resource")
         Scanner scan = new Scanner(query);
         scan.useDelimiter(SPLIT);
         while (scan.hasNext()) {

+ 1 - 1
dbsync/src/test/java/com/taobao/tddl/dbsync/binlog/DirectLogFetcherTest.java

@@ -5,7 +5,7 @@ import java.sql.Connection;
 import java.sql.DriverManager;
 import java.sql.Statement;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.Test;
 

+ 1 - 1
dbsync/src/test/java/com/taobao/tddl/dbsync/binlog/FileLogFetcherTest.java

@@ -4,7 +4,7 @@ import java.io.File;
 import java.io.IOException;
 import java.net.URL;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.Before;
 import org.junit.Test;

+ 1 - 1
driver/src/test/java/com/alibaba/otter/canal/parse/driver/mysql/MysqlConnectorTest.java

@@ -3,7 +3,7 @@ package com.alibaba.otter.canal.parse.driver.mysql;
 import java.io.IOException;
 import java.net.InetSocketAddress;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.Test;
 

+ 1 - 0
filter/src/main/java/com/alibaba/otter/canal/filter/PatternUtils.java

@@ -20,6 +20,7 @@ import com.google.common.collect.MigrateMap;
  */
 public class PatternUtils {
 
+    @SuppressWarnings("deprecation")
     private static Map<String, Pattern> patterns = MigrateMap.makeComputingMap(new MapMaker().softValues(),
                                                      new Function<String, Pattern>() {
 

+ 1 - 1
filter/src/test/java/com/alibaba/otter/canal/filter/AviaterFilterTest.java

@@ -1,6 +1,6 @@
 package com.alibaba.otter.canal.filter;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.Test;
 

+ 1 - 1
filter/src/test/java/com/alibaba/otter/canal/filter/MutliAviaterFilterTest.java

@@ -5,7 +5,7 @@ import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 import java.util.concurrent.atomic.AtomicInteger;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.apache.commons.lang.RandomStringUtils;
 import org.junit.Test;

+ 1 - 1
meta/src/test/java/com/alibaba/otter/canal/meta/AbstractMetaManagerTest.java

@@ -6,7 +6,7 @@ import java.util.Date;
 import java.util.List;
 import java.util.Map;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import com.alibaba.otter.canal.protocol.ClientIdentity;
 import com.alibaba.otter.canal.protocol.position.EntryPosition;

+ 1 - 1
meta/src/test/java/com/alibaba/otter/canal/meta/FileMixedMetaManagerTest.java

@@ -5,7 +5,7 @@ import java.io.IOException;
 import java.util.List;
 import java.util.Map;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.apache.commons.io.FileUtils;
 import org.junit.Before;

+ 1 - 1
meta/src/test/java/com/alibaba/otter/canal/meta/MemoryMetaManagerTest.java

@@ -2,7 +2,7 @@ package com.alibaba.otter.canal.meta;
 
 import java.util.Map;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.Test;
 

+ 1 - 1
meta/src/test/java/com/alibaba/otter/canal/meta/MixedMetaManagerTest.java

@@ -3,7 +3,7 @@ package com.alibaba.otter.canal.meta;
 import java.util.List;
 import java.util.Map;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.After;
 import org.junit.Before;

+ 1 - 1
meta/src/test/java/com/alibaba/otter/canal/meta/PeriodMixedMetaManagerTest.java

@@ -3,7 +3,7 @@ package com.alibaba.otter.canal.meta;
 import java.util.List;
 import java.util.Map;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.After;
 import org.junit.Before;

+ 1 - 1
meta/src/test/java/com/alibaba/otter/canal/meta/ZooKeeperMetaManagerTest.java

@@ -2,7 +2,7 @@ package com.alibaba.otter.canal.meta;
 
 import java.util.Map;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.After;
 import org.junit.Before;

+ 1 - 2
parse/src/test/java/com/alibaba/otter/canal/parse/DirectLogFetcherTest.java

@@ -4,8 +4,7 @@ import java.io.IOException;
 import java.net.InetSocketAddress;
 import java.nio.ByteBuffer;
 
-import junit.framework.Assert;
-
+import org.junit.Assert;
 import org.junit.Test;
 
 import com.alibaba.otter.canal.parse.driver.mysql.MysqlConnector;

+ 1 - 1
parse/src/test/java/com/alibaba/otter/canal/parse/inbound/EventTransactionBufferTest.java

@@ -5,7 +5,7 @@ import java.text.SimpleDateFormat;
 import java.util.Date;
 import java.util.List;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.Test;
 

+ 1 - 1
parse/src/test/java/com/alibaba/otter/canal/parse/inbound/mysql/LocalBinlogDumpTest.java

@@ -4,7 +4,7 @@ import java.net.InetSocketAddress;
 import java.nio.charset.Charset;
 import java.util.List;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.Test;
 

+ 9 - 11
parse/src/test/java/com/alibaba/otter/canal/parse/inbound/mysql/LocalBinlogEventParserTest.java

@@ -1,8 +1,5 @@
 package com.alibaba.otter.canal.parse.inbound.mysql;
 
-import static junit.framework.Assert.assertEquals;
-import static junit.framework.Assert.assertTrue;
-
 import java.io.File;
 import java.net.InetSocketAddress;
 import java.net.URL;
@@ -10,6 +7,7 @@ import java.util.Date;
 import java.util.List;
 import java.util.concurrent.atomic.AtomicLong;
 
+import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
 
@@ -93,10 +91,10 @@ public class LocalBinlogEventParserTest {
         }
 
         // check
-        assertTrue(entryCount.get() > 0);
+        Assert.assertTrue(entryCount.get() > 0);
 
         // 对比第一条数据和起始的position相同
-        assertEquals(entryPosition, defaultPosition);
+        Assert.assertEquals(entryPosition, defaultPosition);
     }
 
     @Test
@@ -155,12 +153,12 @@ public class LocalBinlogEventParserTest {
         }
 
         // check
-        assertTrue(entryCount.get() > 0);
+        Assert.assertTrue(entryCount.get() > 0);
 
         // 对比第一条数据和起始的position相同
-        assertEquals(entryPosition.getJournalName(), "mysql-bin.000001");
-        assertTrue(entryPosition.getPosition() <= 6163L);
-        assertTrue(entryPosition.getTimestamp() <= defaultPosition.getTimestamp());
+        Assert.assertEquals(entryPosition.getJournalName(), "mysql-bin.000001");
+        Assert.assertTrue(entryPosition.getPosition() <= 6163L);
+        Assert.assertTrue(entryPosition.getTimestamp() <= defaultPosition.getTimestamp());
     }
 
     @Test
@@ -221,11 +219,11 @@ public class LocalBinlogEventParserTest {
         }
 
         // check
-        assertTrue(entryCount.get() > 0);
+        Assert.assertTrue(entryCount.get() > 0);
 
         // 对比第一条数据和起始的position相同
         // assertEquals(entryPosition.getJournalName(), "mysql-bin.000002");
-        assertTrue(entryPosition.getTimestamp() <= defaultPosition.getTimestamp());
+        Assert.assertTrue(entryPosition.getTimestamp() <= defaultPosition.getTimestamp());
     }
 
     private EntryPosition buildPosition(String binlogFile, Long offest, Long timestamp) {

+ 1 - 1
parse/src/test/java/com/alibaba/otter/canal/parse/inbound/mysql/MysqlDumpTest.java

@@ -4,7 +4,7 @@ import java.net.InetSocketAddress;
 import java.nio.charset.Charset;
 import java.util.List;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.Test;
 

+ 11 - 15
parse/src/test/java/com/alibaba/otter/canal/parse/inbound/mysql/MysqlEventParserTest.java

@@ -1,15 +1,11 @@
 package com.alibaba.otter.canal.parse.inbound.mysql;
 
-import static junit.framework.Assert.assertEquals;
-import static junit.framework.Assert.assertTrue;
-
 import java.net.InetSocketAddress;
 import java.util.Date;
 import java.util.List;
 import java.util.concurrent.atomic.AtomicLong;
 
-import junit.framework.Assert;
-
+import org.junit.Assert;
 import org.junit.Test;
 
 import com.alibaba.otter.canal.parse.helper.TimeoutChecker;
@@ -88,7 +84,7 @@ public class MysqlEventParserTest {
         }
 
         // check
-        assertTrue(entryCount.get() > 0);
+        Assert.assertTrue(entryCount.get() > 0);
 
         // 对比第一条数据和起始的position相同
         Assert.assertEquals(entryPosition, defaultPosition);
@@ -152,12 +148,12 @@ public class MysqlEventParserTest {
         }
 
         // check
-        assertTrue(entryCount.get() > 0);
+        Assert.assertTrue(entryCount.get() > 0);
 
         // 对比第一条数据和起始的position相同
-        assertEquals(entryPosition.getJournalName(), "mysql-bin.000001");
-        assertTrue(entryPosition.getPosition() <= 6163L);
-        assertTrue(entryPosition.getTimestamp() <= defaultPosition.getTimestamp());
+        Assert.assertEquals(entryPosition.getJournalName(), "mysql-bin.000001");
+        Assert.assertTrue(entryPosition.getPosition() <= 6163L);
+        Assert.assertTrue(entryPosition.getTimestamp() <= defaultPosition.getTimestamp());
     }
 
     @Test
@@ -219,12 +215,12 @@ public class MysqlEventParserTest {
         }
 
         // check
-        assertTrue(entryCount.get() > 0);
+        Assert.assertTrue(entryCount.get() > 0);
 
         // 对比第一条数据和起始的position相同
         Assert.assertEquals(entryPosition.getJournalName(), "mysql-bin.000001");
-        assertTrue(entryPosition.getPosition() <= 6163L);
-        assertTrue(entryPosition.getTimestamp() <= defaultPosition.getTimestamp());
+        Assert.assertTrue(entryPosition.getPosition() <= 6163L);
+        Assert.assertTrue(entryPosition.getTimestamp() <= defaultPosition.getTimestamp());
     }
 
     @Test
@@ -288,12 +284,12 @@ public class MysqlEventParserTest {
         }
 
         // check
-        assertTrue(entryCount.get() > 0);
+        Assert.assertTrue(entryCount.get() > 0);
 
         // 对比第一条数据和起始的position相同
         // Assert.assertEquals(logfilename, "mysql-bin.000001");
         // Assert.assertEquals(106L, logfileoffset);
-        assertTrue(entryPosition.getTimestamp() < defaultPosition.getTimestamp());
+        Assert.assertTrue(entryPosition.getTimestamp() < defaultPosition.getTimestamp());
     }
 
     // ======================== helper method =======================

+ 7 - 2
parse/src/test/java/com/alibaba/otter/canal/parse/inbound/mysql/SimpleDdlParserTest.java

@@ -1,7 +1,6 @@
 package com.alibaba.otter.canal.parse.inbound.mysql;
 
-import junit.framework.Assert;
-
+import org.junit.Assert;
 import org.junit.Test;
 
 import com.alibaba.otter.canal.parse.inbound.mysql.dbsync.SimpleDdlParser;
@@ -82,6 +81,12 @@ public class SimpleDdlParserTest {
         Assert.assertNotNull(result);
         Assert.assertEquals("temp_bond_keys", result.getSchemaName());
         Assert.assertEquals("temp_bond_key_id", result.getTableName());
+
+        queryString = "CREATE TABLE performance_schema.cond_instances(NAME ";
+        result = SimpleDdlParser.parse(queryString, "retl");
+        Assert.assertNotNull(result);
+        Assert.assertEquals("performance_schema", result.getSchemaName());
+        Assert.assertEquals("cond_instances", result.getTableName());
     }
 
     @Test

+ 1 - 1
parse/src/test/java/com/alibaba/otter/canal/parse/index/AbstractLogPositionManagerTest.java

@@ -3,7 +3,7 @@ package com.alibaba.otter.canal.parse.index;
 import java.net.InetSocketAddress;
 import java.util.Date;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import com.alibaba.otter.canal.protocol.position.EntryPosition;
 import com.alibaba.otter.canal.protocol.position.LogIdentity;

+ 1 - 1
parse/src/test/java/com/alibaba/otter/canal/parse/index/FileMixedLogPositionManagerTest.java

@@ -3,7 +3,7 @@ package com.alibaba.otter.canal.parse.index;
 import java.io.File;
 import java.io.IOException;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.apache.commons.io.FileUtils;
 import org.junit.Before;

+ 1 - 1
parse/src/test/java/com/alibaba/otter/canal/parse/index/MetaLogPositionManagerTest.java

@@ -3,7 +3,7 @@ package com.alibaba.otter.canal.parse.index;
 import java.net.InetSocketAddress;
 import java.util.Date;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.After;
 import org.junit.Before;

+ 1 - 1
parse/src/test/java/com/alibaba/otter/canal/parse/index/MixedLogPositionManagerTest.java

@@ -1,6 +1,6 @@
 package com.alibaba.otter.canal.parse.index;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.After;
 import org.junit.Before;

+ 1 - 1
parse/src/test/java/com/alibaba/otter/canal/parse/index/PeriodMixedLogPositionManagerTest.java

@@ -1,6 +1,6 @@
 package com.alibaba.otter.canal.parse.index;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.junit.After;
 import org.junit.Before;

+ 1 - 1
store/src/test/java/com/alibaba/otter/cancel/store/memory/buffer/MemoryEventStoreMultiThreadTest.java

@@ -7,7 +7,7 @@ import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 import java.util.concurrent.TimeUnit;
 
-import junit.framework.Assert;
+import org.junit.Assert;
 
 import org.apache.commons.lang.math.RandomUtils;
 import org.junit.After;