1
0
Эх сурвалжийг харах

Restore assertion on discount overlaps in SimilarityTests

This assertion was commented out as the getDiscountOverlaps getter was
missing from LegacyBm25Similarity. That has been fixed in lucene.
Luca Cavanna 6 жил өмнө
parent
commit
0b396a0c5e

+ 1 - 2
server/src/test/java/org/elasticsearch/index/similarity/SimilarityTests.java

@@ -99,8 +99,7 @@ public class SimilarityTests extends ESSingleNodeTestCase {
         LegacyBM25Similarity similarity = (LegacyBM25Similarity) mapperService.fullName("field1").similarity().get();
         assertThat(similarity.getK1(), equalTo(2.0f));
         assertThat(similarity.getB(), equalTo(0.5f));
-        // TODO: re-enable when we switch back to BM25Similarity
-        // assertThat(similarity.getDiscountOverlaps(), equalTo(false));
+        assertThat(similarity.getDiscountOverlaps(), equalTo(false));
     }
 
     public void testResolveSimilaritiesFromMapping_boolean() throws IOException {