Browse Source

[ML][Data Frame] Adjusting error message (#43455)

* Adjusting error message

* Update TransportPutDataFrameTransformAction.java

* Update TransportPutDataFrameTransformAction.java
Benjamin Trent 6 years ago
parent
commit
1e92d1a8a6

+ 10 - 13
x-pack/plugin/data-frame/src/main/java/org/elasticsearch/xpack/dataframe/action/TransportPutDataFrameTransformAction.java

@@ -25,8 +25,6 @@ import org.elasticsearch.common.inject.Inject;
 import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.regex.Regex;
 import org.elasticsearch.common.settings.Settings;
-import org.elasticsearch.common.xcontent.XContentBuilder;
-import org.elasticsearch.common.xcontent.json.JsonXContent;
 import org.elasticsearch.license.LicenseUtils;
 import org.elasticsearch.license.XPackLicenseState;
 import org.elasticsearch.persistent.PersistentTasksCustomMetaData;
@@ -233,17 +231,16 @@ public class TransportPutDataFrameTransformAction
         if (privilegesResponse.isCompleteMatch()) {
             putDataFrame(config, listener);
         } else {
-            XContentBuilder builder = JsonXContent.contentBuilder();
-            builder.startObject();
-            for (ResourcePrivileges index : privilegesResponse.getIndexPrivileges()) {
-                builder.field(index.getResource());
-                builder.map(index.getPrivileges());
-            }
-            builder.endObject();
-
-            listener.onFailure(Exceptions.authorizationError("Cannot create data frame transform [{}]" +
-                    " because user {} lacks permissions on the indices: {}",
-                config.getId(), username, Strings.toString(builder)));
+            List<String> indices = privilegesResponse.getIndexPrivileges()
+                .stream()
+                .map(ResourcePrivileges::getResource)
+                .collect(Collectors.toList());
+
+            listener.onFailure(Exceptions.authorizationError(
+                "Cannot create data frame transform [{}] because user {} lacks all the required permissions for indices: {}",
+                config.getId(),
+                username,
+                indices));
         }
     }