[Connector API] Fix bug with filtering validation toXContent (#107467)

docs/changelog/107467.yaml

@@ -0,0 +1,5 @@
+pr: 107467
+summary: "[Connector API] Fix bug with filtering validation toXContent"
+area: Application
+type: bug
+issues: []

x-pack/plugin/ent-search/src/main/java/org/elasticsearch/xpack/application/connector/filtering/FilteringValidation.java

@@ -69,6 +69,7 @@ public class FilteringValidation implements Writeable, ToXContentObject {
             builder.stringListField(IDS_FIELD.getPreferredName(), ids);
             builder.stringListField(MESSAGES_FIELD.getPreferredName(), messages);
         }
+        builder.endObject();
         return builder;
     }
 

x-pack/plugin/ent-search/src/test/java/org/elasticsearch/xpack/application/connector/ConnectorFilteringTests.java

@@ -203,8 +203,8 @@ public class ConnectorFilteringTests extends ESTestCase {
                             }
                         ],
                         "validation": {
-                            "errors": [],
-                            "state": "valid"
+                            "errors": [{"ids": ["1"], "messages": ["some messages"]}],
+                            "state": "invalid"
                         }
                     },
                     "domain": "DEFAULT",