1
0
Эх сурвалжийг харах

TEST: Use non-zero number for #testCompareUnits

In `ByteSizeValueTests#testCompareUnits`, we expect non-zero for the
variable `number` however `randomNonNegativeLong` can return zero.

CI: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.2+oracle-java10-periodic/147/console
Nhat Nguyen 7 жил өмнө
parent
commit
4f644d04a3

+ 1 - 1
server/src/test/java/org/elasticsearch/common/unit/ByteSizeValueTests.java

@@ -168,7 +168,7 @@ public class ByteSizeValueTests extends AbstractWireSerializingTestCase<ByteSize
     }
 
     public void testCompareUnits() {
-        long number = randomNonNegativeLong() / ByteSizeUnit.PB.toBytes(1);
+        long number = randomLongBetween(1, Long.MAX_VALUE/ ByteSizeUnit.PB.toBytes(1));
         ByteSizeUnit randomUnit = randomValueOtherThan(ByteSizeUnit.PB, ()->randomFrom(ByteSizeUnit.values()));
         ByteSizeValue firstByteValue = new ByteSizeValue(number, randomUnit);
         ByteSizeValue secondByteValue = new ByteSizeValue(number, ByteSizeUnit.PB);