浏览代码

Esql - gate IgnoreNullMetricsTests tests on capability (#134304)

Forgot these tests need a capability gate as well.

Co-authored-by: Craig Taverner <craig@amanzi.com>
Mark Tozzi 1 月之前
父节点
当前提交
5f06c397c7

+ 6 - 3
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/rules/logical/local/IgnoreNullMetricsTests.java

@@ -10,6 +10,7 @@ package org.elasticsearch.xpack.esql.optimizer.rules.logical.local;
 import org.elasticsearch.index.IndexMode;
 import org.elasticsearch.test.ESTestCase;
 import org.elasticsearch.xpack.esql.EsqlTestUtils;
+import org.elasticsearch.xpack.esql.action.EsqlCapabilities;
 import org.elasticsearch.xpack.esql.analysis.Analyzer;
 import org.elasticsearch.xpack.esql.analysis.AnalyzerContext;
 import org.elasticsearch.xpack.esql.analysis.AnalyzerTestUtils;
@@ -115,6 +116,7 @@ public class IgnoreNullMetricsTests extends ESTestCase {
     }
 
     public void testSimple() {
+        assumeTrue("requires metrics command", EsqlCapabilities.Cap.METRICS_COMMAND.isEnabled());
         LogicalPlan actual = localPlan("""
             TS test
             | STATS max(max_over_time(metric_1))
@@ -144,7 +146,7 @@ public class IgnoreNullMetricsTests extends ESTestCase {
     }
 
     public void testDimensionsAreNotFiltered() {
-
+        assumeTrue("requires metrics command", EsqlCapabilities.Cap.METRICS_COMMAND.isEnabled());
         LogicalPlan actual = localPlan("""
             TS test
             | STATS max(max_over_time(metric_1)) BY dimension_1
@@ -161,7 +163,7 @@ public class IgnoreNullMetricsTests extends ESTestCase {
     }
 
     public void testFiltersAreJoinedWithOr() {
-
+        assumeTrue("requires metrics command", EsqlCapabilities.Cap.METRICS_COMMAND.isEnabled());
         LogicalPlan actual = localPlan("""
             TS test
             | STATS max(max_over_time(metric_1)), min(min_over_time(metric_2))
@@ -197,6 +199,7 @@ public class IgnoreNullMetricsTests extends ESTestCase {
     public void testSkipCoalescedMetrics() {
         // Note: this test is passing because the reference attribute metric_2 in the stats block does not inherit the
         // metric property from the original field.
+        assumeTrue("requires metrics command", EsqlCapabilities.Cap.METRICS_COMMAND.isEnabled());
         LogicalPlan actual = localPlan("""
             TS test
             | EVAL metric_2 = coalesce(metric_2, 0)
@@ -218,6 +221,7 @@ public class IgnoreNullMetricsTests extends ESTestCase {
      * check that stats blocks after the first are not sourced for adding metrics to the filter
      */
     public void testMultipleStats() {
+        assumeTrue("requires metrics command", EsqlCapabilities.Cap.METRICS_COMMAND.isEnabled());
         LogicalPlan actual = localPlan("""
             TS test
             | STATS m = max(max_over_time(metric_1))
@@ -232,6 +236,5 @@ public class IgnoreNullMetricsTests extends ESTestCase {
         IsNotNull condition = as(filter.condition(), IsNotNull.class);
         FieldAttribute attribute = as(condition.field(), FieldAttribute.class);
         assertEquals("metric_1", attribute.fieldName().string());
-
     }
 }