Revert "Skip translog creation for search shards (#92873)" (#92972)

This reverts commit c51783aeb40d8f22fea5645a3389a901d83d90c9.

server/src/main/java/org/elasticsearch/indices/recovery/RecoveryTarget.java

@@ -498,15 +498,14 @@ public class RecoveryTarget extends AbstractRefCounted implements RecoveryTarget
                 if (DiscoveryNode.isStateless(indexShard.indexSettings().getNodeSettings()) == false
                     || indexShard.routingEntry().primary()) {
                     store.cleanupAndVerify("recovery CleanFilesRequestHandler", sourceMetadata);
-
-                    final String translogUUID = Translog.createEmptyTranslog(
-                        indexShard.shardPath().resolveTranslog(),
-                        globalCheckpoint,
-                        shardId,
-                        indexShard.getPendingPrimaryTerm()
-                    );
-                    store.associateIndexWithNewTranslog(translogUUID);
                 }
+                final String translogUUID = Translog.createEmptyTranslog(
+                    indexShard.shardPath().resolveTranslog(),
+                    globalCheckpoint,
+                    shardId,
+                    indexShard.getPendingPrimaryTerm()
+                );
+                store.associateIndexWithNewTranslog(translogUUID);
 
                 if (indexShard.getRetentionLeases().leases().isEmpty()) {
                     // if empty, may be a fresh IndexShard, so write an empty leases file to disk