Browse Source

[TEST] Expand assert to mention which files are not deleted

Relates to #25335
Lee Hinman 7 years ago
parent
commit
96e7da53c7
1 changed files with 12 additions and 1 deletions
  1. 12 1
      server/src/main/java/org/elasticsearch/env/NodeEnvironment.java

+ 12 - 1
server/src/main/java/org/elasticsearch/env/NodeEnvironment.java

@@ -450,7 +450,18 @@ public final class NodeEnvironment  implements Closeable {
             IOUtils.rm(customLocation);
         }
         logger.trace("deleted shard {} directory, paths: [{}]", shardId, paths);
-        assert FileSystemUtils.exists(paths) == false;
+        assert assertPathsDoNotExist(paths);
+    }
+
+    private static boolean assertPathsDoNotExist(final Path[] paths) {
+        Set<Path> existingPaths = new HashSet<>();
+        for (Path path : paths) {
+            if (FileSystemUtils.exists(paths)) {
+                existingPaths.add(path);
+            }
+        }
+        assert existingPaths.size() == 0 : "Paths exist that should have been deleted: " + existingPaths;
+        return existingPaths.size() == 0;
     }
 
     private boolean isShardLocked(ShardId id) {