浏览代码

Fix the condition for logging empty JWK sets. (#91675)

The logic for check isEmpty should have been flipped. This PR fixes it.

Relates: #91001
Yang Wang 2 年之前
父节点
当前提交
a7abee0ec1

+ 4 - 2
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/jwt/JwtSignatureValidator.java

@@ -161,8 +161,10 @@ public interface JwtSignatureValidator extends Releasable {
         }
         }
 
 
         private void logWarnIfAuthenticationWillAlwaysFail() {
         private void logWarnIfAuthenticationWillAlwaysFail() {
-            final boolean hasUsableJwksAndAlgorithms = (hmacJwtSignatureValidator != null && hmacJwtSignatureValidator.jwksAlgs.isEmpty())
-                || (pkcJwtSignatureValidator != null && pkcJwtSignatureValidator.jwkSetLoader.getContentAndJwksAlgs().jwksAlgs().isEmpty());
+            final boolean hasUsableJwksAndAlgorithms = (hmacJwtSignatureValidator != null
+                && false == hmacJwtSignatureValidator.jwksAlgs.isEmpty())
+                || (pkcJwtSignatureValidator != null
+                    && false == pkcJwtSignatureValidator.jwkSetLoader.getContentAndJwksAlgs().jwksAlgs().isEmpty());
             if (false == hasUsableJwksAndAlgorithms) {
             if (false == hasUsableJwksAndAlgorithms) {
                 logger.warn(
                 logger.warn(
                     "No available JWK and algorithm for HMAC or PKC. JWT realm authentication expected to fail until this is fixed."
                     "No available JWK and algorithm for HMAC or PKC. JWT realm authentication expected to fail until this is fixed."