1
0
Эх сурвалжийг харах

Fix type conversion problem in Eclipse (#50549)

Eclipse 4.13 shows a type mismatch error in the affected line because it cannot
correctly infer the boolean return type for the method call. Assigning return
value to a local variable resolves this problem.
Christoph Büscher 5 жил өмнө
parent
commit
be68264981

+ 4 - 1
x-pack/plugin/ml/qa/native-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration/ClassificationIT.java

@@ -6,6 +6,7 @@
 package org.elasticsearch.xpack.ml.integration;
 package org.elasticsearch.xpack.ml.integration;
 
 
 import com.google.common.collect.Ordering;
 import com.google.common.collect.Ordering;
+
 import org.elasticsearch.ElasticsearchStatusException;
 import org.elasticsearch.ElasticsearchStatusException;
 import org.elasticsearch.action.admin.indices.get.GetIndexAction;
 import org.elasticsearch.action.admin.indices.get.GetIndexAction;
 import org.elasticsearch.action.admin.indices.get.GetIndexRequest;
 import org.elasticsearch.action.admin.indices.get.GetIndexRequest;
@@ -192,7 +193,9 @@ public class ClassificationIT extends MlNativeDataFrameAnalyticsIntegTestCase {
             assertTopClasses(resultsObject, numTopClasses, dependentVariable, dependentVariableValues);
             assertTopClasses(resultsObject, numTopClasses, dependentVariable, dependentVariableValues);
 
 
             // Let's just assert there's both training and non-training results
             // Let's just assert there's both training and non-training results
-            if (getFieldValue(resultsObject, "is_training")) {
+            //
+            boolean isTraining = getFieldValue(resultsObject, "is_training");
+            if (isTraining) {
                 trainingRowsCount++;
                 trainingRowsCount++;
             } else {
             } else {
                 nonTrainingRowsCount++;
                 nonTrainingRowsCount++;