Browse Source

[ML] Disallow wildcarded deletions in ML native tests again (#73721)

After #71150 was merged we had to allow wildcarded deletions
in our native multi-node tests, because the feature reset API
was doing a wildcarded deletion.

This is not ideal because we then might rely on wildcarded
deletion somewhere else and not notice in our tests.

Now that #73017 is merged we should no longer need to allow
wildcarded deletion for the benefit of the feature reset API.
Therefore, this PR reverts the setting change that was made
in #71176.  Over time our testing will then validate that the
feature reset API really does work with wildcarded deletes
disallowed.
David Roberts 4 years ago
parent
commit
fb5071c3ef

+ 0 - 2
x-pack/plugin/ml/qa/native-multi-node-tests/src/javaRestTest/java/org/elasticsearch/xpack/ml/integration/MlNativeIntegTestCase.java

@@ -8,7 +8,6 @@ package org.elasticsearch.xpack.ml.integration;
 
 import org.elasticsearch.action.admin.cluster.snapshots.features.ResetFeatureStateAction;
 import org.elasticsearch.action.admin.cluster.snapshots.features.ResetFeatureStateRequest;
-import org.elasticsearch.action.support.DestructiveOperations;
 import org.elasticsearch.cluster.NamedDiff;
 import org.elasticsearch.xpack.autoscaling.Autoscaling;
 import org.elasticsearch.xpack.autoscaling.AutoscalingMetadata;
@@ -169,7 +168,6 @@ abstract class MlNativeIntegTestCase extends ESIntegTestCase {
 
         Settings.Builder builder = Settings.builder();
         builder.putList("node.roles", Collections.emptyList());
-        builder.put(DestructiveOperations.REQUIRES_NAME_SETTING.getKey(), false);
         builder.put(NetworkModule.TRANSPORT_TYPE_KEY, SecurityField.NAME4);
         builder.put(XPackSettings.MACHINE_LEARNING_ENABLED.getKey(), true);
         builder.put(XPackSettings.SECURITY_ENABLED.getKey(), true);