Quellcode durchsuchen

Don't report `context cancelled` errors to metrics collectors

DarthSim vor 1 Jahr
Ursprung
Commit
94492e812c
2 geänderte Dateien mit 7 neuen und 2 gelöschten Zeilen
  1. 2 0
      CHANGELOG.md
  2. 5 2
      processing_handler.go

+ 2 - 0
CHANGELOG.md

@@ -1,6 +1,8 @@
 # Changelog
 
 ## [Unreleased]
+### Change
+- Don't report `The image request is cancelled` errors.
 
 ## [3.18.2] - 2023-07-13
 ### Fix

+ 5 - 2
processing_handler.go

@@ -167,7 +167,7 @@ func respondWithNotModified(reqID string, r *http.Request, rw http.ResponseWrite
 	)
 }
 
-func sendErrAndPanic(ctx context.Context, errType string, err error) {
+func sendErr(ctx context.Context, errType string, err error) {
 	send := true
 
 	if ierr, ok := err.(*ierrors.Error); ok {
@@ -183,7 +183,10 @@ func sendErrAndPanic(ctx context.Context, errType string, err error) {
 	if send {
 		metrics.SendError(ctx, errType, err)
 	}
+}
 
+func sendErrAndPanic(ctx context.Context, errType string, err error) {
+	sendErr(ctx, errType, err)
 	panic(err)
 }
 
@@ -329,7 +332,7 @@ func handleProcessing(reqID string, rw http.ResponseWriter, r *http.Request) {
 			errorreport.Report(err, r)
 		}
 
-		metrics.SendError(ctx, "download", err)
+		sendErr(ctx, "download", err)
 
 		if imagedata.FallbackImage == nil {
 			panic(err)