1
0

processing_handler_test.go 23 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787
  1. package main
  2. import (
  3. "fmt"
  4. "io"
  5. "net/http"
  6. "net/http/httptest"
  7. "os"
  8. "path/filepath"
  9. "regexp"
  10. "strings"
  11. "testing"
  12. "time"
  13. "github.com/sirupsen/logrus"
  14. "github.com/stretchr/testify/suite"
  15. "github.com/imgproxy/imgproxy/v3/config"
  16. "github.com/imgproxy/imgproxy/v3/config/configurators"
  17. "github.com/imgproxy/imgproxy/v3/etag"
  18. "github.com/imgproxy/imgproxy/v3/httpheaders"
  19. "github.com/imgproxy/imgproxy/v3/imagedata"
  20. "github.com/imgproxy/imgproxy/v3/imagetype"
  21. "github.com/imgproxy/imgproxy/v3/options"
  22. "github.com/imgproxy/imgproxy/v3/router"
  23. "github.com/imgproxy/imgproxy/v3/svg"
  24. "github.com/imgproxy/imgproxy/v3/testutil"
  25. "github.com/imgproxy/imgproxy/v3/vips"
  26. )
  27. type ProcessingHandlerTestSuite struct {
  28. suite.Suite
  29. router *router.Router
  30. }
  31. func (s *ProcessingHandlerTestSuite) SetupSuite() {
  32. config.Reset()
  33. wd, err := os.Getwd()
  34. s.Require().NoError(err)
  35. s.T().Setenv("IMGPROXY_LOCAL_FILESYSTEM_ROOT", filepath.Join(wd, "/testdata"))
  36. s.T().Setenv("IMGPROXY_CLIENT_KEEP_ALIVE_TIMEOUT", "0")
  37. err = initialize()
  38. s.Require().NoError(err)
  39. logrus.SetOutput(io.Discard)
  40. s.router = buildRouter()
  41. }
  42. func (s *ProcessingHandlerTestSuite) TeardownSuite() {
  43. shutdown()
  44. logrus.SetOutput(os.Stdout)
  45. }
  46. func (s *ProcessingHandlerTestSuite) SetupTest() {
  47. // We don't need config.LocalFileSystemRoot anymore as it is used
  48. // only during initialization
  49. config.Reset()
  50. config.AllowLoopbackSourceAddresses = true
  51. }
  52. func (s *ProcessingHandlerTestSuite) send(path string, header ...http.Header) *httptest.ResponseRecorder {
  53. req := httptest.NewRequest(http.MethodGet, path, nil)
  54. rw := httptest.NewRecorder()
  55. if len(header) > 0 {
  56. req.Header = header[0]
  57. }
  58. s.router.ServeHTTP(rw, req)
  59. return rw
  60. }
  61. func (s *ProcessingHandlerTestSuite) readTestFile(name string) []byte {
  62. wd, err := os.Getwd()
  63. s.Require().NoError(err)
  64. data, err := os.ReadFile(filepath.Join(wd, "testdata", name))
  65. s.Require().NoError(err)
  66. return data
  67. }
  68. func (s *ProcessingHandlerTestSuite) readTestImageData(name string) imagedata.ImageData {
  69. wd, err := os.Getwd()
  70. s.Require().NoError(err)
  71. data, err := os.ReadFile(filepath.Join(wd, "testdata", name))
  72. s.Require().NoError(err)
  73. imgdata, err := imagedata.NewFromBytes(data)
  74. s.Require().NoError(err)
  75. return imgdata
  76. }
  77. func (s *ProcessingHandlerTestSuite) readImageData(imgdata imagedata.ImageData) []byte {
  78. data, err := io.ReadAll(imgdata.Reader())
  79. s.Require().NoError(err)
  80. return data
  81. }
  82. func (s *ProcessingHandlerTestSuite) sampleETagData(imgETag string) (string, imagedata.ImageData, http.Header, string) {
  83. poStr := "rs:fill:4:4"
  84. po := options.NewProcessingOptions()
  85. po.ResizingType = options.ResizeFill
  86. po.Width = 4
  87. po.Height = 4
  88. imgdata := s.readTestImageData("test1.png")
  89. headers := make(http.Header)
  90. if len(imgETag) != 0 {
  91. headers.Set(httpheaders.Etag, imgETag)
  92. }
  93. var h etag.Handler
  94. h.SetActualProcessingOptions(po)
  95. h.SetActualImageData(imgdata, headers)
  96. return poStr, imgdata, headers, h.GenerateActualETag()
  97. }
  98. func (s *ProcessingHandlerTestSuite) TestRequest() {
  99. rw := s.send("/unsafe/rs:fill:4:4/plain/local:///test1.png")
  100. res := rw.Result()
  101. s.Require().Equal(200, res.StatusCode)
  102. s.Require().Equal("image/png", res.Header.Get("Content-Type"))
  103. format, err := imagetype.Detect(res.Body)
  104. s.Require().NoError(err)
  105. s.Require().Equal(imagetype.PNG, format)
  106. }
  107. func (s *ProcessingHandlerTestSuite) TestSignatureValidationFailure() {
  108. config.Keys = [][]byte{[]byte("test-key")}
  109. config.Salts = [][]byte{[]byte("test-salt")}
  110. rw := s.send("/unsafe/rs:fill:4:4/plain/local:///test1.png")
  111. res := rw.Result()
  112. s.Require().Equal(403, res.StatusCode)
  113. }
  114. func (s *ProcessingHandlerTestSuite) TestSignatureValidationSuccess() {
  115. config.Keys = [][]byte{[]byte("test-key")}
  116. config.Salts = [][]byte{[]byte("test-salt")}
  117. rw := s.send("/My9d3xq_PYpVHsPrCyww0Kh1w5KZeZhIlWhsa4az1TI/rs:fill:4:4/plain/local:///test1.png")
  118. res := rw.Result()
  119. s.Require().Equal(200, res.StatusCode)
  120. }
  121. func (s *ProcessingHandlerTestSuite) TestSourceValidation() {
  122. imagedata.RedirectAllRequestsTo("local:///test1.png")
  123. defer imagedata.StopRedirectingRequests()
  124. tt := []struct {
  125. name string
  126. allowedSources []string
  127. requestPath string
  128. expectedError bool
  129. }{
  130. {
  131. name: "match http URL without wildcard",
  132. allowedSources: []string{"local://", "http://images.dev/"},
  133. requestPath: "/unsafe/plain/http://images.dev/lorem/ipsum.jpg",
  134. expectedError: false,
  135. },
  136. {
  137. name: "match http URL with wildcard in hostname single level",
  138. allowedSources: []string{"local://", "http://*.mycdn.dev/"},
  139. requestPath: "/unsafe/plain/http://a-1.mycdn.dev/lorem/ipsum.jpg",
  140. expectedError: false,
  141. },
  142. {
  143. name: "match http URL with wildcard in hostname multiple levels",
  144. allowedSources: []string{"local://", "http://*.mycdn.dev/"},
  145. requestPath: "/unsafe/plain/http://a-1.b-2.mycdn.dev/lorem/ipsum.jpg",
  146. expectedError: false,
  147. },
  148. {
  149. name: "no match s3 URL with allowed local and http URLs",
  150. allowedSources: []string{"local://", "http://images.dev/"},
  151. requestPath: "/unsafe/plain/s3://images/lorem/ipsum.jpg",
  152. expectedError: true,
  153. },
  154. {
  155. name: "no match http URL with wildcard in hostname including slash",
  156. allowedSources: []string{"local://", "http://*.mycdn.dev/"},
  157. requestPath: "/unsafe/plain/http://other.dev/.mycdn.dev/lorem/ipsum.jpg",
  158. expectedError: true,
  159. },
  160. }
  161. for _, tc := range tt {
  162. s.Run(tc.name, func() {
  163. exps := make([]*regexp.Regexp, len(tc.allowedSources))
  164. for i, pattern := range tc.allowedSources {
  165. exps[i] = configurators.RegexpFromPattern(pattern)
  166. }
  167. config.AllowedSources = exps
  168. rw := s.send(tc.requestPath)
  169. res := rw.Result()
  170. if tc.expectedError {
  171. s.Require().Equal(404, res.StatusCode)
  172. } else {
  173. s.Require().Equal(200, res.StatusCode)
  174. }
  175. })
  176. }
  177. }
  178. func (s *ProcessingHandlerTestSuite) TestSourceNetworkValidation() {
  179. data := s.readTestFile("test1.png")
  180. server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  181. rw.WriteHeader(200)
  182. rw.Write(data)
  183. }))
  184. defer server.Close()
  185. var rw *httptest.ResponseRecorder
  186. u := fmt.Sprintf("/unsafe/rs:fill:4:4/plain/%s/test1.png", server.URL)
  187. rw = s.send(u)
  188. s.Require().Equal(200, rw.Result().StatusCode)
  189. config.AllowLoopbackSourceAddresses = false
  190. rw = s.send(u)
  191. s.Require().Equal(404, rw.Result().StatusCode)
  192. }
  193. func (s *ProcessingHandlerTestSuite) TestSourceFormatNotSupported() {
  194. vips.DisableLoadSupport(imagetype.PNG)
  195. defer vips.ResetLoadSupport()
  196. rw := s.send("/unsafe/rs:fill:4:4/plain/local:///test1.png")
  197. res := rw.Result()
  198. s.Require().Equal(422, res.StatusCode)
  199. }
  200. func (s *ProcessingHandlerTestSuite) TestResultingFormatNotSupported() {
  201. vips.DisableSaveSupport(imagetype.PNG)
  202. defer vips.ResetSaveSupport()
  203. rw := s.send("/unsafe/rs:fill:4:4/plain/local:///test1.png@png")
  204. res := rw.Result()
  205. s.Require().Equal(422, res.StatusCode)
  206. }
  207. func (s *ProcessingHandlerTestSuite) TestSkipProcessingConfig() {
  208. config.SkipProcessingFormats = []imagetype.Type{imagetype.PNG}
  209. rw := s.send("/unsafe/rs:fill:4:4/plain/local:///test1.png")
  210. res := rw.Result()
  211. s.Require().Equal(200, res.StatusCode)
  212. expected := s.readTestImageData("test1.png")
  213. s.Require().True(testutil.ReadersEqual(s.T(), expected.Reader(), res.Body))
  214. }
  215. func (s *ProcessingHandlerTestSuite) TestSkipProcessingPO() {
  216. rw := s.send("/unsafe/rs:fill:4:4/skp:png/plain/local:///test1.png")
  217. res := rw.Result()
  218. s.Require().Equal(200, res.StatusCode)
  219. expected := s.readTestImageData("test1.png")
  220. s.Require().True(testutil.ReadersEqual(s.T(), expected.Reader(), res.Body))
  221. }
  222. func (s *ProcessingHandlerTestSuite) TestSkipProcessingSameFormat() {
  223. config.SkipProcessingFormats = []imagetype.Type{imagetype.PNG}
  224. rw := s.send("/unsafe/rs:fill:4:4/plain/local:///test1.png@png")
  225. res := rw.Result()
  226. s.Require().Equal(200, res.StatusCode)
  227. expected := s.readTestImageData("test1.png")
  228. s.Require().True(testutil.ReadersEqual(s.T(), expected.Reader(), res.Body))
  229. }
  230. func (s *ProcessingHandlerTestSuite) TestSkipProcessingDifferentFormat() {
  231. config.SkipProcessingFormats = []imagetype.Type{imagetype.PNG}
  232. rw := s.send("/unsafe/rs:fill:4:4/plain/local:///test1.png@jpg")
  233. res := rw.Result()
  234. s.Require().Equal(200, res.StatusCode)
  235. expected := s.readTestImageData("test1.png")
  236. s.Require().False(testutil.ReadersEqual(s.T(), expected.Reader(), res.Body))
  237. }
  238. func (s *ProcessingHandlerTestSuite) TestSkipProcessingSVG() {
  239. rw := s.send("/unsafe/rs:fill:4:4/plain/local:///test1.svg")
  240. res := rw.Result()
  241. s.Require().Equal(200, res.StatusCode)
  242. expected, err := svg.Sanitize(s.readTestImageData("test1.svg"))
  243. s.Require().NoError(err)
  244. s.Require().True(testutil.ReadersEqual(s.T(), expected.Reader(), res.Body))
  245. }
  246. func (s *ProcessingHandlerTestSuite) TestNotSkipProcessingSVGToJPG() {
  247. rw := s.send("/unsafe/rs:fill:4:4/plain/local:///test1.svg@jpg")
  248. res := rw.Result()
  249. s.Require().Equal(200, res.StatusCode)
  250. expected := s.readTestImageData("test1.svg")
  251. s.Require().False(testutil.ReadersEqual(s.T(), expected.Reader(), res.Body))
  252. }
  253. func (s *ProcessingHandlerTestSuite) TestErrorSavingToSVG() {
  254. rw := s.send("/unsafe/rs:fill:4:4/plain/local:///test1.png@svg")
  255. res := rw.Result()
  256. s.Require().Equal(422, res.StatusCode)
  257. }
  258. func (s *ProcessingHandlerTestSuite) TestCacheControlPassthroughCacheControl() {
  259. config.CacheControlPassthrough = true
  260. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  261. rw.Header().Set("Cache-Control", "max-age=1234, public")
  262. rw.Header().Set("Expires", time.Now().Add(time.Hour).UTC().Format(http.TimeFormat))
  263. rw.WriteHeader(200)
  264. rw.Write(s.readTestFile("test1.png"))
  265. }))
  266. defer ts.Close()
  267. rw := s.send("/unsafe/rs:fill:4:4/plain/" + ts.URL)
  268. res := rw.Result()
  269. s.Require().Equal("max-age=1234, public", res.Header.Get("Cache-Control"))
  270. s.Require().Empty(res.Header.Get("Expires"))
  271. }
  272. func (s *ProcessingHandlerTestSuite) TestCacheControlPassthroughExpires() {
  273. config.CacheControlPassthrough = true
  274. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  275. rw.Header().Set("Expires", time.Now().Add(1239*time.Second).UTC().Format(http.TimeFormat))
  276. rw.WriteHeader(200)
  277. rw.Write(s.readTestFile("test1.png"))
  278. }))
  279. defer ts.Close()
  280. rw := s.send("/unsafe/rs:fill:4:4/plain/" + ts.URL)
  281. res := rw.Result()
  282. // Use regex to allow some delay
  283. s.Require().Regexp("max-age=123[0-9], public", res.Header.Get("Cache-Control"))
  284. s.Require().Empty(res.Header.Get("Expires"))
  285. }
  286. func (s *ProcessingHandlerTestSuite) TestCacheControlPassthroughDisabled() {
  287. config.CacheControlPassthrough = false
  288. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  289. rw.Header().Set("Cache-Control", "max-age=1234, public")
  290. rw.Header().Set("Expires", time.Now().Add(time.Hour).UTC().Format(http.TimeFormat))
  291. rw.WriteHeader(200)
  292. rw.Write(s.readTestFile("test1.png"))
  293. }))
  294. defer ts.Close()
  295. rw := s.send("/unsafe/rs:fill:4:4/plain/" + ts.URL)
  296. res := rw.Result()
  297. s.Require().NotEqual("max-age=1234, public", res.Header.Get("Cache-Control"))
  298. s.Require().Empty(res.Header.Get("Expires"))
  299. }
  300. func (s *ProcessingHandlerTestSuite) TestETagDisabled() {
  301. config.ETagEnabled = false
  302. rw := s.send("/unsafe/rs:fill:4:4/plain/local:///test1.png")
  303. res := rw.Result()
  304. s.Require().Equal(200, res.StatusCode)
  305. s.Require().Empty(res.Header.Get("ETag"))
  306. }
  307. func (s *ProcessingHandlerTestSuite) TestETagReqNoIfNotModified() {
  308. config.ETagEnabled = true
  309. poStr, _, headers, etag := s.sampleETagData("loremipsumdolor")
  310. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  311. s.Empty(r.Header.Get("If-None-Match"))
  312. rw.Header().Set("ETag", headers.Get(httpheaders.Etag))
  313. rw.WriteHeader(200)
  314. rw.Write(s.readTestFile("test1.png"))
  315. }))
  316. defer ts.Close()
  317. rw := s.send(fmt.Sprintf("/unsafe/%s/plain/%s", poStr, ts.URL))
  318. res := rw.Result()
  319. s.Require().Equal(200, res.StatusCode)
  320. s.Require().Equal(etag, res.Header.Get("ETag"))
  321. }
  322. func (s *ProcessingHandlerTestSuite) TestETagDataNoIfNotModified() {
  323. config.ETagEnabled = true
  324. poStr, imgdata, _, etag := s.sampleETagData("")
  325. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  326. s.Empty(r.Header.Get("If-None-Match"))
  327. rw.WriteHeader(200)
  328. rw.Write(s.readImageData(imgdata))
  329. }))
  330. defer ts.Close()
  331. rw := s.send(fmt.Sprintf("/unsafe/%s/plain/%s", poStr, ts.URL))
  332. res := rw.Result()
  333. s.Require().Equal(200, res.StatusCode)
  334. s.Require().Equal(etag, res.Header.Get("ETag"))
  335. }
  336. func (s *ProcessingHandlerTestSuite) TestETagReqMatch() {
  337. config.ETagEnabled = true
  338. poStr, _, headers, etag := s.sampleETagData(`"loremipsumdolor"`)
  339. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  340. s.Equal(headers.Get(httpheaders.Etag), r.Header.Get(httpheaders.IfNoneMatch))
  341. rw.WriteHeader(304)
  342. }))
  343. defer ts.Close()
  344. header := make(http.Header)
  345. header.Set("If-None-Match", etag)
  346. rw := s.send(fmt.Sprintf("/unsafe/%s/plain/%s", poStr, ts.URL), header)
  347. res := rw.Result()
  348. s.Require().Equal(304, res.StatusCode)
  349. s.Require().Equal(etag, res.Header.Get("ETag"))
  350. }
  351. func (s *ProcessingHandlerTestSuite) TestETagDataMatch() {
  352. config.ETagEnabled = true
  353. poStr, imgdata, _, etag := s.sampleETagData("")
  354. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  355. s.Empty(r.Header.Get("If-None-Match"))
  356. rw.WriteHeader(200)
  357. rw.Write(s.readImageData(imgdata))
  358. }))
  359. defer ts.Close()
  360. header := make(http.Header)
  361. header.Set("If-None-Match", etag)
  362. rw := s.send(fmt.Sprintf("/unsafe/%s/plain/%s", poStr, ts.URL), header)
  363. res := rw.Result()
  364. s.Require().Equal(304, res.StatusCode)
  365. s.Require().Equal(etag, res.Header.Get("ETag"))
  366. }
  367. func (s *ProcessingHandlerTestSuite) TestETagReqNotMatch() {
  368. config.ETagEnabled = true
  369. poStr, imgdata, headers, actualETag := s.sampleETagData(`"loremipsumdolor"`)
  370. _, _, _, expectedETag := s.sampleETagData(`"loremipsum"`)
  371. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  372. s.Equal(`"loremipsum"`, r.Header.Get("If-None-Match"))
  373. rw.Header().Set("ETag", headers.Get(httpheaders.Etag))
  374. rw.WriteHeader(200)
  375. rw.Write(s.readImageData(imgdata))
  376. }))
  377. defer ts.Close()
  378. header := make(http.Header)
  379. header.Set("If-None-Match", expectedETag)
  380. rw := s.send(fmt.Sprintf("/unsafe/%s/plain/%s", poStr, ts.URL), header)
  381. res := rw.Result()
  382. s.Require().Equal(200, res.StatusCode)
  383. s.Require().Equal(actualETag, res.Header.Get("ETag"))
  384. }
  385. func (s *ProcessingHandlerTestSuite) TestETagDataNotMatch() {
  386. config.ETagEnabled = true
  387. poStr, imgdata, _, actualETag := s.sampleETagData("")
  388. // Change the data hash
  389. expectedETag := actualETag[:strings.IndexByte(actualETag, '/')] + "/Dasdbefj"
  390. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  391. s.Empty(r.Header.Get("If-None-Match"))
  392. rw.WriteHeader(200)
  393. rw.Write(s.readImageData(imgdata))
  394. }))
  395. defer ts.Close()
  396. header := make(http.Header)
  397. header.Set("If-None-Match", expectedETag)
  398. rw := s.send(fmt.Sprintf("/unsafe/%s/plain/%s", poStr, ts.URL), header)
  399. res := rw.Result()
  400. s.Require().Equal(200, res.StatusCode)
  401. s.Require().Equal(actualETag, res.Header.Get("ETag"))
  402. }
  403. func (s *ProcessingHandlerTestSuite) TestETagProcessingOptionsNotMatch() {
  404. config.ETagEnabled = true
  405. poStr, imgdata, headers, actualETag := s.sampleETagData("")
  406. // Change the processing options hash
  407. expectedETag := "abcdefj" + actualETag[strings.IndexByte(actualETag, '/'):]
  408. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  409. s.Empty(r.Header.Get("If-None-Match"))
  410. rw.Header().Set("ETag", headers.Get(httpheaders.Etag))
  411. rw.WriteHeader(200)
  412. rw.Write(s.readImageData(imgdata))
  413. }))
  414. defer ts.Close()
  415. header := make(http.Header)
  416. header.Set("If-None-Match", expectedETag)
  417. rw := s.send(fmt.Sprintf("/unsafe/%s/plain/%s", poStr, ts.URL), header)
  418. res := rw.Result()
  419. s.Require().Equal(200, res.StatusCode)
  420. s.Require().Equal(actualETag, res.Header.Get("ETag"))
  421. }
  422. func (s *ProcessingHandlerTestSuite) TestLastModifiedEnabled() {
  423. config.LastModifiedEnabled = true
  424. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  425. rw.Header().Set("Last-Modified", "Wed, 21 Oct 2015 07:28:00 GMT")
  426. rw.WriteHeader(200)
  427. rw.Write(s.readTestFile("test1.png"))
  428. }))
  429. defer ts.Close()
  430. rw := s.send("/unsafe/rs:fill:4:4/plain/" + ts.URL)
  431. res := rw.Result()
  432. s.Require().Equal("Wed, 21 Oct 2015 07:28:00 GMT", res.Header.Get("Last-Modified"))
  433. }
  434. func (s *ProcessingHandlerTestSuite) TestLastModifiedDisabled() {
  435. config.LastModifiedEnabled = false
  436. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  437. rw.Header().Set("Last-Modified", "Wed, 21 Oct 2015 07:28:00 GMT")
  438. rw.WriteHeader(200)
  439. rw.Write(s.readTestFile("test1.png"))
  440. }))
  441. defer ts.Close()
  442. rw := s.send("/unsafe/rs:fill:4:4/plain/" + ts.URL)
  443. res := rw.Result()
  444. s.Require().Empty(res.Header.Get("Last-Modified"))
  445. }
  446. func (s *ProcessingHandlerTestSuite) TestModifiedSinceReqExactMatchLastModifiedDisabled() {
  447. config.LastModifiedEnabled = false
  448. data := s.readTestFile("test1.png")
  449. lastModified := "Wed, 21 Oct 2015 07:28:00 GMT"
  450. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  451. modifiedSince := r.Header.Get("If-Modified-Since")
  452. s.Empty(modifiedSince)
  453. rw.WriteHeader(200)
  454. rw.Write(data)
  455. }))
  456. defer ts.Close()
  457. header := make(http.Header)
  458. header.Set("If-Modified-Since", lastModified)
  459. rw := s.send(fmt.Sprintf("/unsafe/plain/%s", ts.URL), header)
  460. res := rw.Result()
  461. s.Require().Equal(200, res.StatusCode)
  462. }
  463. func (s *ProcessingHandlerTestSuite) TestModifiedSinceReqExactMatchLastModifiedEnabled() {
  464. config.LastModifiedEnabled = true
  465. lastModified := "Wed, 21 Oct 2015 07:28:00 GMT"
  466. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  467. modifiedSince := r.Header.Get("If-Modified-Since")
  468. s.Equal(lastModified, modifiedSince)
  469. rw.WriteHeader(304)
  470. }))
  471. defer ts.Close()
  472. header := make(http.Header)
  473. header.Set("If-Modified-Since", lastModified)
  474. rw := s.send(fmt.Sprintf("/unsafe/plain/%s", ts.URL), header)
  475. res := rw.Result()
  476. s.Require().Equal(304, res.StatusCode)
  477. }
  478. func (s *ProcessingHandlerTestSuite) TestModifiedSinceReqCompareMoreRecentLastModifiedDisabled() {
  479. data := s.readTestFile("test1.png")
  480. config.LastModifiedEnabled = false
  481. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  482. modifiedSince := r.Header.Get("If-Modified-Since")
  483. s.Empty(modifiedSince)
  484. rw.WriteHeader(200)
  485. rw.Write(data)
  486. }))
  487. defer ts.Close()
  488. recentTimestamp := "Thu, 25 Feb 2021 01:45:00 GMT"
  489. header := make(http.Header)
  490. header.Set("If-Modified-Since", recentTimestamp)
  491. rw := s.send(fmt.Sprintf("/unsafe/plain/%s", ts.URL), header)
  492. res := rw.Result()
  493. s.Require().Equal(200, res.StatusCode)
  494. }
  495. func (s *ProcessingHandlerTestSuite) TestModifiedSinceReqCompareMoreRecentLastModifiedEnabled() {
  496. config.LastModifiedEnabled = true
  497. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  498. fileLastModified, _ := time.Parse(http.TimeFormat, "Wed, 21 Oct 2015 07:28:00 GMT")
  499. modifiedSince := r.Header.Get("If-Modified-Since")
  500. parsedModifiedSince, err := time.Parse(http.TimeFormat, modifiedSince)
  501. s.NoError(err)
  502. s.True(fileLastModified.Before(parsedModifiedSince))
  503. rw.WriteHeader(304)
  504. }))
  505. defer ts.Close()
  506. recentTimestamp := "Thu, 25 Feb 2021 01:45:00 GMT"
  507. header := make(http.Header)
  508. header.Set("If-Modified-Since", recentTimestamp)
  509. rw := s.send(fmt.Sprintf("/unsafe/plain/%s", ts.URL), header)
  510. res := rw.Result()
  511. s.Require().Equal(304, res.StatusCode)
  512. }
  513. func (s *ProcessingHandlerTestSuite) TestModifiedSinceReqCompareTooOldLastModifiedDisabled() {
  514. config.LastModifiedEnabled = false
  515. data := s.readTestFile("test1.png")
  516. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  517. modifiedSince := r.Header.Get("If-Modified-Since")
  518. s.Empty(modifiedSince)
  519. rw.WriteHeader(200)
  520. rw.Write(data)
  521. }))
  522. defer ts.Close()
  523. oldTimestamp := "Tue, 01 Oct 2013 17:31:00 GMT"
  524. header := make(http.Header)
  525. header.Set("If-Modified-Since", oldTimestamp)
  526. rw := s.send(fmt.Sprintf("/unsafe/plain/%s", ts.URL), header)
  527. res := rw.Result()
  528. s.Require().Equal(200, res.StatusCode)
  529. }
  530. func (s *ProcessingHandlerTestSuite) TestModifiedSinceReqCompareTooOldLastModifiedEnabled() {
  531. config.LastModifiedEnabled = true
  532. data := s.readTestFile("test1.png")
  533. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  534. fileLastModified, _ := time.Parse(http.TimeFormat, "Wed, 21 Oct 2015 07:28:00 GMT")
  535. modifiedSince := r.Header.Get("If-Modified-Since")
  536. parsedModifiedSince, err := time.Parse(http.TimeFormat, modifiedSince)
  537. s.NoError(err)
  538. s.True(fileLastModified.After(parsedModifiedSince))
  539. rw.WriteHeader(200)
  540. rw.Write(data)
  541. }))
  542. defer ts.Close()
  543. oldTimestamp := "Tue, 01 Oct 2013 17:31:00 GMT"
  544. header := make(http.Header)
  545. header.Set("If-Modified-Since", oldTimestamp)
  546. rw := s.send(fmt.Sprintf("/unsafe/plain/%s", ts.URL), header)
  547. res := rw.Result()
  548. s.Require().Equal(200, res.StatusCode)
  549. }
  550. func (s *ProcessingHandlerTestSuite) TestAlwaysRasterizeSvg() {
  551. config.AlwaysRasterizeSvg = true
  552. rw := s.send("/unsafe/rs:fill:40:40/plain/local:///test1.svg")
  553. res := rw.Result()
  554. s.Require().Equal(200, res.StatusCode)
  555. s.Require().Equal("image/png", res.Header.Get("Content-Type"))
  556. }
  557. func (s *ProcessingHandlerTestSuite) TestAlwaysRasterizeSvgWithEnforceAvif() {
  558. config.AlwaysRasterizeSvg = true
  559. config.EnforceWebp = true
  560. rw := s.send("/unsafe/plain/local:///test1.svg", http.Header{"Accept": []string{"image/webp"}})
  561. res := rw.Result()
  562. s.Require().Equal(200, res.StatusCode)
  563. s.Require().Equal("image/webp", res.Header.Get("Content-Type"))
  564. }
  565. func (s *ProcessingHandlerTestSuite) TestAlwaysRasterizeSvgDisabled() {
  566. config.AlwaysRasterizeSvg = false
  567. config.EnforceWebp = true
  568. rw := s.send("/unsafe/plain/local:///test1.svg")
  569. res := rw.Result()
  570. s.Require().Equal(200, res.StatusCode)
  571. s.Require().Equal("image/svg+xml", res.Header.Get("Content-Type"))
  572. }
  573. func (s *ProcessingHandlerTestSuite) TestAlwaysRasterizeSvgWithFormat() {
  574. config.AlwaysRasterizeSvg = true
  575. config.SkipProcessingFormats = []imagetype.Type{imagetype.SVG}
  576. rw := s.send("/unsafe/plain/local:///test1.svg@svg")
  577. res := rw.Result()
  578. s.Require().Equal(200, res.StatusCode)
  579. s.Require().Equal("image/svg+xml", res.Header.Get("Content-Type"))
  580. }
  581. func (s *ProcessingHandlerTestSuite) TestMaxSrcFileSizeGlobal() {
  582. config.MaxSrcFileSize = 1
  583. ts := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  584. rw.WriteHeader(200)
  585. rw.Write(s.readTestFile("test1.png"))
  586. }))
  587. defer ts.Close()
  588. rw := s.send("/unsafe/rs:fill:4:4/plain/" + ts.URL)
  589. res := rw.Result()
  590. s.Require().Equal(422, res.StatusCode)
  591. }
  592. func TestProcessingHandler(t *testing.T) {
  593. suite.Run(t, new(ProcessingHandlerTestSuite))
  594. }