transport_test.go 95 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686
  1. // Copyright 2015 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bufio"
  7. "bytes"
  8. "crypto/tls"
  9. "errors"
  10. "flag"
  11. "fmt"
  12. "io"
  13. "io/ioutil"
  14. "math/rand"
  15. "net"
  16. "net/http"
  17. "net/http/httptest"
  18. "net/url"
  19. "os"
  20. "reflect"
  21. "runtime"
  22. "sort"
  23. "strconv"
  24. "strings"
  25. "sync"
  26. "sync/atomic"
  27. "testing"
  28. "time"
  29. "golang.org/x/net/http2/hpack"
  30. )
  31. var (
  32. extNet = flag.Bool("extnet", false, "do external network tests")
  33. transportHost = flag.String("transporthost", "http2.golang.org", "hostname to use for TestTransport")
  34. insecure = flag.Bool("insecure", false, "insecure TLS dials") // TODO: dead code. remove?
  35. )
  36. var tlsConfigInsecure = &tls.Config{InsecureSkipVerify: true}
  37. type testContext struct{}
  38. func (testContext) Done() <-chan struct{} { return make(chan struct{}) }
  39. func (testContext) Err() error { panic("should not be called") }
  40. func (testContext) Deadline() (deadline time.Time, ok bool) { return time.Time{}, false }
  41. func (testContext) Value(key interface{}) interface{} { return nil }
  42. func TestTransportExternal(t *testing.T) {
  43. if !*extNet {
  44. t.Skip("skipping external network test")
  45. }
  46. req, _ := http.NewRequest("GET", "https://"+*transportHost+"/", nil)
  47. rt := &Transport{TLSClientConfig: tlsConfigInsecure}
  48. res, err := rt.RoundTrip(req)
  49. if err != nil {
  50. t.Fatalf("%v", err)
  51. }
  52. res.Write(os.Stdout)
  53. }
  54. type fakeTLSConn struct {
  55. net.Conn
  56. }
  57. func (c *fakeTLSConn) ConnectionState() tls.ConnectionState {
  58. return tls.ConnectionState{
  59. Version: tls.VersionTLS12,
  60. CipherSuite: cipher_TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
  61. }
  62. }
  63. func startH2cServer(t *testing.T) net.Listener {
  64. h2Server := &Server{}
  65. l := newLocalListener(t)
  66. go func() {
  67. conn, err := l.Accept()
  68. if err != nil {
  69. t.Error(err)
  70. return
  71. }
  72. h2Server.ServeConn(&fakeTLSConn{conn}, &ServeConnOpts{Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  73. fmt.Fprintf(w, "Hello, %v, http: %v", r.URL.Path, r.TLS == nil)
  74. })})
  75. }()
  76. return l
  77. }
  78. func TestTransportH2c(t *testing.T) {
  79. l := startH2cServer(t)
  80. defer l.Close()
  81. req, err := http.NewRequest("GET", "http://"+l.Addr().String()+"/foobar", nil)
  82. if err != nil {
  83. t.Fatal(err)
  84. }
  85. tr := &Transport{
  86. AllowHTTP: true,
  87. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  88. return net.Dial(network, addr)
  89. },
  90. }
  91. res, err := tr.RoundTrip(req)
  92. if err != nil {
  93. t.Fatal(err)
  94. }
  95. if res.ProtoMajor != 2 {
  96. t.Fatal("proto not h2c")
  97. }
  98. body, err := ioutil.ReadAll(res.Body)
  99. if err != nil {
  100. t.Fatal(err)
  101. }
  102. if got, want := string(body), "Hello, /foobar, http: true"; got != want {
  103. t.Fatalf("response got %v, want %v", got, want)
  104. }
  105. }
  106. func TestTransport(t *testing.T) {
  107. const body = "sup"
  108. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  109. io.WriteString(w, body)
  110. }, optOnlyServer)
  111. defer st.Close()
  112. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  113. defer tr.CloseIdleConnections()
  114. req, err := http.NewRequest("GET", st.ts.URL, nil)
  115. if err != nil {
  116. t.Fatal(err)
  117. }
  118. res, err := tr.RoundTrip(req)
  119. if err != nil {
  120. t.Fatal(err)
  121. }
  122. defer res.Body.Close()
  123. t.Logf("Got res: %+v", res)
  124. if g, w := res.StatusCode, 200; g != w {
  125. t.Errorf("StatusCode = %v; want %v", g, w)
  126. }
  127. if g, w := res.Status, "200 OK"; g != w {
  128. t.Errorf("Status = %q; want %q", g, w)
  129. }
  130. wantHeader := http.Header{
  131. "Content-Length": []string{"3"},
  132. "Content-Type": []string{"text/plain; charset=utf-8"},
  133. "Date": []string{"XXX"}, // see cleanDate
  134. }
  135. cleanDate(res)
  136. if !reflect.DeepEqual(res.Header, wantHeader) {
  137. t.Errorf("res Header = %v; want %v", res.Header, wantHeader)
  138. }
  139. if res.Request != req {
  140. t.Errorf("Response.Request = %p; want %p", res.Request, req)
  141. }
  142. if res.TLS == nil {
  143. t.Error("Response.TLS = nil; want non-nil")
  144. }
  145. slurp, err := ioutil.ReadAll(res.Body)
  146. if err != nil {
  147. t.Errorf("Body read: %v", err)
  148. } else if string(slurp) != body {
  149. t.Errorf("Body = %q; want %q", slurp, body)
  150. }
  151. }
  152. func onSameConn(t *testing.T, modReq func(*http.Request)) bool {
  153. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  154. io.WriteString(w, r.RemoteAddr)
  155. }, optOnlyServer, func(c net.Conn, st http.ConnState) {
  156. t.Logf("conn %v is now state %v", c.RemoteAddr(), st)
  157. })
  158. defer st.Close()
  159. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  160. defer tr.CloseIdleConnections()
  161. get := func() string {
  162. req, err := http.NewRequest("GET", st.ts.URL, nil)
  163. if err != nil {
  164. t.Fatal(err)
  165. }
  166. modReq(req)
  167. res, err := tr.RoundTrip(req)
  168. if err != nil {
  169. t.Fatal(err)
  170. }
  171. defer res.Body.Close()
  172. slurp, err := ioutil.ReadAll(res.Body)
  173. if err != nil {
  174. t.Fatalf("Body read: %v", err)
  175. }
  176. addr := strings.TrimSpace(string(slurp))
  177. if addr == "" {
  178. t.Fatalf("didn't get an addr in response")
  179. }
  180. return addr
  181. }
  182. first := get()
  183. second := get()
  184. return first == second
  185. }
  186. func TestTransportReusesConns(t *testing.T) {
  187. if !onSameConn(t, func(*http.Request) {}) {
  188. t.Errorf("first and second responses were on different connections")
  189. }
  190. }
  191. func TestTransportReusesConn_RequestClose(t *testing.T) {
  192. if onSameConn(t, func(r *http.Request) { r.Close = true }) {
  193. t.Errorf("first and second responses were not on different connections")
  194. }
  195. }
  196. func TestTransportReusesConn_ConnClose(t *testing.T) {
  197. if onSameConn(t, func(r *http.Request) { r.Header.Set("Connection", "close") }) {
  198. t.Errorf("first and second responses were not on different connections")
  199. }
  200. }
  201. // Tests that the Transport only keeps one pending dial open per destination address.
  202. // https://golang.org/issue/13397
  203. func TestTransportGroupsPendingDials(t *testing.T) {
  204. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  205. io.WriteString(w, r.RemoteAddr)
  206. }, optOnlyServer)
  207. defer st.Close()
  208. tr := &Transport{
  209. TLSClientConfig: tlsConfigInsecure,
  210. }
  211. defer tr.CloseIdleConnections()
  212. var (
  213. mu sync.Mutex
  214. dials = map[string]int{}
  215. )
  216. var wg sync.WaitGroup
  217. for i := 0; i < 10; i++ {
  218. wg.Add(1)
  219. go func() {
  220. defer wg.Done()
  221. req, err := http.NewRequest("GET", st.ts.URL, nil)
  222. if err != nil {
  223. t.Error(err)
  224. return
  225. }
  226. res, err := tr.RoundTrip(req)
  227. if err != nil {
  228. t.Error(err)
  229. return
  230. }
  231. defer res.Body.Close()
  232. slurp, err := ioutil.ReadAll(res.Body)
  233. if err != nil {
  234. t.Errorf("Body read: %v", err)
  235. }
  236. addr := strings.TrimSpace(string(slurp))
  237. if addr == "" {
  238. t.Errorf("didn't get an addr in response")
  239. }
  240. mu.Lock()
  241. dials[addr]++
  242. mu.Unlock()
  243. }()
  244. }
  245. wg.Wait()
  246. if len(dials) != 1 {
  247. t.Errorf("saw %d dials; want 1: %v", len(dials), dials)
  248. }
  249. tr.CloseIdleConnections()
  250. if err := retry(50, 10*time.Millisecond, func() error {
  251. cp, ok := tr.connPool().(*clientConnPool)
  252. if !ok {
  253. return fmt.Errorf("Conn pool is %T; want *clientConnPool", tr.connPool())
  254. }
  255. cp.mu.Lock()
  256. defer cp.mu.Unlock()
  257. if len(cp.dialing) != 0 {
  258. return fmt.Errorf("dialing map = %v; want empty", cp.dialing)
  259. }
  260. if len(cp.conns) != 0 {
  261. return fmt.Errorf("conns = %v; want empty", cp.conns)
  262. }
  263. if len(cp.keys) != 0 {
  264. return fmt.Errorf("keys = %v; want empty", cp.keys)
  265. }
  266. return nil
  267. }); err != nil {
  268. t.Errorf("State of pool after CloseIdleConnections: %v", err)
  269. }
  270. }
  271. func retry(tries int, delay time.Duration, fn func() error) error {
  272. var err error
  273. for i := 0; i < tries; i++ {
  274. err = fn()
  275. if err == nil {
  276. return nil
  277. }
  278. time.Sleep(delay)
  279. }
  280. return err
  281. }
  282. func TestTransportAbortClosesPipes(t *testing.T) {
  283. shutdown := make(chan struct{})
  284. st := newServerTester(t,
  285. func(w http.ResponseWriter, r *http.Request) {
  286. w.(http.Flusher).Flush()
  287. <-shutdown
  288. },
  289. optOnlyServer,
  290. )
  291. defer st.Close()
  292. defer close(shutdown) // we must shutdown before st.Close() to avoid hanging
  293. done := make(chan struct{})
  294. requestMade := make(chan struct{})
  295. go func() {
  296. defer close(done)
  297. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  298. req, err := http.NewRequest("GET", st.ts.URL, nil)
  299. if err != nil {
  300. t.Fatal(err)
  301. }
  302. res, err := tr.RoundTrip(req)
  303. if err != nil {
  304. t.Fatal(err)
  305. }
  306. defer res.Body.Close()
  307. close(requestMade)
  308. _, err = ioutil.ReadAll(res.Body)
  309. if err == nil {
  310. t.Error("expected error from res.Body.Read")
  311. }
  312. }()
  313. <-requestMade
  314. // Now force the serve loop to end, via closing the connection.
  315. st.closeConn()
  316. // deadlock? that's a bug.
  317. select {
  318. case <-done:
  319. case <-time.After(3 * time.Second):
  320. t.Fatal("timeout")
  321. }
  322. }
  323. // TODO: merge this with TestTransportBody to make TestTransportRequest? This
  324. // could be a table-driven test with extra goodies.
  325. func TestTransportPath(t *testing.T) {
  326. gotc := make(chan *url.URL, 1)
  327. st := newServerTester(t,
  328. func(w http.ResponseWriter, r *http.Request) {
  329. gotc <- r.URL
  330. },
  331. optOnlyServer,
  332. )
  333. defer st.Close()
  334. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  335. defer tr.CloseIdleConnections()
  336. const (
  337. path = "/testpath"
  338. query = "q=1"
  339. )
  340. surl := st.ts.URL + path + "?" + query
  341. req, err := http.NewRequest("POST", surl, nil)
  342. if err != nil {
  343. t.Fatal(err)
  344. }
  345. c := &http.Client{Transport: tr}
  346. res, err := c.Do(req)
  347. if err != nil {
  348. t.Fatal(err)
  349. }
  350. defer res.Body.Close()
  351. got := <-gotc
  352. if got.Path != path {
  353. t.Errorf("Read Path = %q; want %q", got.Path, path)
  354. }
  355. if got.RawQuery != query {
  356. t.Errorf("Read RawQuery = %q; want %q", got.RawQuery, query)
  357. }
  358. }
  359. func randString(n int) string {
  360. rnd := rand.New(rand.NewSource(int64(n)))
  361. b := make([]byte, n)
  362. for i := range b {
  363. b[i] = byte(rnd.Intn(256))
  364. }
  365. return string(b)
  366. }
  367. type panicReader struct{}
  368. func (panicReader) Read([]byte) (int, error) { panic("unexpected Read") }
  369. func (panicReader) Close() error { panic("unexpected Close") }
  370. func TestActualContentLength(t *testing.T) {
  371. tests := []struct {
  372. req *http.Request
  373. want int64
  374. }{
  375. // Verify we don't read from Body:
  376. 0: {
  377. req: &http.Request{Body: panicReader{}},
  378. want: -1,
  379. },
  380. // nil Body means 0, regardless of ContentLength:
  381. 1: {
  382. req: &http.Request{Body: nil, ContentLength: 5},
  383. want: 0,
  384. },
  385. // ContentLength is used if set.
  386. 2: {
  387. req: &http.Request{Body: panicReader{}, ContentLength: 5},
  388. want: 5,
  389. },
  390. // http.NoBody means 0, not -1.
  391. 3: {
  392. req: &http.Request{Body: go18httpNoBody()},
  393. want: 0,
  394. },
  395. }
  396. for i, tt := range tests {
  397. got := actualContentLength(tt.req)
  398. if got != tt.want {
  399. t.Errorf("test[%d]: got %d; want %d", i, got, tt.want)
  400. }
  401. }
  402. }
  403. func TestTransportBody(t *testing.T) {
  404. bodyTests := []struct {
  405. body string
  406. noContentLen bool
  407. }{
  408. {body: "some message"},
  409. {body: "some message", noContentLen: true},
  410. {body: strings.Repeat("a", 1<<20), noContentLen: true},
  411. {body: strings.Repeat("a", 1<<20)},
  412. {body: randString(16<<10 - 1)},
  413. {body: randString(16 << 10)},
  414. {body: randString(16<<10 + 1)},
  415. {body: randString(512<<10 - 1)},
  416. {body: randString(512 << 10)},
  417. {body: randString(512<<10 + 1)},
  418. {body: randString(1<<20 - 1)},
  419. {body: randString(1 << 20)},
  420. {body: randString(1<<20 + 2)},
  421. }
  422. type reqInfo struct {
  423. req *http.Request
  424. slurp []byte
  425. err error
  426. }
  427. gotc := make(chan reqInfo, 1)
  428. st := newServerTester(t,
  429. func(w http.ResponseWriter, r *http.Request) {
  430. slurp, err := ioutil.ReadAll(r.Body)
  431. if err != nil {
  432. gotc <- reqInfo{err: err}
  433. } else {
  434. gotc <- reqInfo{req: r, slurp: slurp}
  435. }
  436. },
  437. optOnlyServer,
  438. )
  439. defer st.Close()
  440. for i, tt := range bodyTests {
  441. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  442. defer tr.CloseIdleConnections()
  443. var body io.Reader = strings.NewReader(tt.body)
  444. if tt.noContentLen {
  445. body = struct{ io.Reader }{body} // just a Reader, hiding concrete type and other methods
  446. }
  447. req, err := http.NewRequest("POST", st.ts.URL, body)
  448. if err != nil {
  449. t.Fatalf("#%d: %v", i, err)
  450. }
  451. c := &http.Client{Transport: tr}
  452. res, err := c.Do(req)
  453. if err != nil {
  454. t.Fatalf("#%d: %v", i, err)
  455. }
  456. defer res.Body.Close()
  457. ri := <-gotc
  458. if ri.err != nil {
  459. t.Errorf("#%d: read error: %v", i, ri.err)
  460. continue
  461. }
  462. if got := string(ri.slurp); got != tt.body {
  463. t.Errorf("#%d: Read body mismatch.\n got: %q (len %d)\nwant: %q (len %d)", i, shortString(got), len(got), shortString(tt.body), len(tt.body))
  464. }
  465. wantLen := int64(len(tt.body))
  466. if tt.noContentLen && tt.body != "" {
  467. wantLen = -1
  468. }
  469. if ri.req.ContentLength != wantLen {
  470. t.Errorf("#%d. handler got ContentLength = %v; want %v", i, ri.req.ContentLength, wantLen)
  471. }
  472. }
  473. }
  474. func shortString(v string) string {
  475. const maxLen = 100
  476. if len(v) <= maxLen {
  477. return v
  478. }
  479. return fmt.Sprintf("%v[...%d bytes omitted...]%v", v[:maxLen/2], len(v)-maxLen, v[len(v)-maxLen/2:])
  480. }
  481. func TestTransportDialTLS(t *testing.T) {
  482. var mu sync.Mutex // guards following
  483. var gotReq, didDial bool
  484. ts := newServerTester(t,
  485. func(w http.ResponseWriter, r *http.Request) {
  486. mu.Lock()
  487. gotReq = true
  488. mu.Unlock()
  489. },
  490. optOnlyServer,
  491. )
  492. defer ts.Close()
  493. tr := &Transport{
  494. DialTLS: func(netw, addr string, cfg *tls.Config) (net.Conn, error) {
  495. mu.Lock()
  496. didDial = true
  497. mu.Unlock()
  498. cfg.InsecureSkipVerify = true
  499. c, err := tls.Dial(netw, addr, cfg)
  500. if err != nil {
  501. return nil, err
  502. }
  503. return c, c.Handshake()
  504. },
  505. }
  506. defer tr.CloseIdleConnections()
  507. client := &http.Client{Transport: tr}
  508. res, err := client.Get(ts.ts.URL)
  509. if err != nil {
  510. t.Fatal(err)
  511. }
  512. res.Body.Close()
  513. mu.Lock()
  514. if !gotReq {
  515. t.Error("didn't get request")
  516. }
  517. if !didDial {
  518. t.Error("didn't use dial hook")
  519. }
  520. }
  521. func TestConfigureTransport(t *testing.T) {
  522. t1 := &http.Transport{}
  523. err := ConfigureTransport(t1)
  524. if err == errTransportVersion {
  525. t.Skip(err)
  526. }
  527. if err != nil {
  528. t.Fatal(err)
  529. }
  530. if got := fmt.Sprintf("%#v", t1); !strings.Contains(got, `"h2"`) {
  531. // Laziness, to avoid buildtags.
  532. t.Errorf("stringification of HTTP/1 transport didn't contain \"h2\": %v", got)
  533. }
  534. wantNextProtos := []string{"h2", "http/1.1"}
  535. if t1.TLSClientConfig == nil {
  536. t.Errorf("nil t1.TLSClientConfig")
  537. } else if !reflect.DeepEqual(t1.TLSClientConfig.NextProtos, wantNextProtos) {
  538. t.Errorf("TLSClientConfig.NextProtos = %q; want %q", t1.TLSClientConfig.NextProtos, wantNextProtos)
  539. }
  540. if err := ConfigureTransport(t1); err == nil {
  541. t.Error("unexpected success on second call to ConfigureTransport")
  542. }
  543. // And does it work?
  544. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  545. io.WriteString(w, r.Proto)
  546. }, optOnlyServer)
  547. defer st.Close()
  548. t1.TLSClientConfig.InsecureSkipVerify = true
  549. c := &http.Client{Transport: t1}
  550. res, err := c.Get(st.ts.URL)
  551. if err != nil {
  552. t.Fatal(err)
  553. }
  554. slurp, err := ioutil.ReadAll(res.Body)
  555. if err != nil {
  556. t.Fatal(err)
  557. }
  558. if got, want := string(slurp), "HTTP/2.0"; got != want {
  559. t.Errorf("body = %q; want %q", got, want)
  560. }
  561. }
  562. type capitalizeReader struct {
  563. r io.Reader
  564. }
  565. func (cr capitalizeReader) Read(p []byte) (n int, err error) {
  566. n, err = cr.r.Read(p)
  567. for i, b := range p[:n] {
  568. if b >= 'a' && b <= 'z' {
  569. p[i] = b - ('a' - 'A')
  570. }
  571. }
  572. return
  573. }
  574. type flushWriter struct {
  575. w io.Writer
  576. }
  577. func (fw flushWriter) Write(p []byte) (n int, err error) {
  578. n, err = fw.w.Write(p)
  579. if f, ok := fw.w.(http.Flusher); ok {
  580. f.Flush()
  581. }
  582. return
  583. }
  584. type clientTester struct {
  585. t *testing.T
  586. tr *Transport
  587. sc, cc net.Conn // server and client conn
  588. fr *Framer // server's framer
  589. client func() error
  590. server func() error
  591. }
  592. func newClientTester(t *testing.T) *clientTester {
  593. var dialOnce struct {
  594. sync.Mutex
  595. dialed bool
  596. }
  597. ct := &clientTester{
  598. t: t,
  599. }
  600. ct.tr = &Transport{
  601. TLSClientConfig: tlsConfigInsecure,
  602. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  603. dialOnce.Lock()
  604. defer dialOnce.Unlock()
  605. if dialOnce.dialed {
  606. return nil, errors.New("only one dial allowed in test mode")
  607. }
  608. dialOnce.dialed = true
  609. return ct.cc, nil
  610. },
  611. }
  612. ln := newLocalListener(t)
  613. cc, err := net.Dial("tcp", ln.Addr().String())
  614. if err != nil {
  615. t.Fatal(err)
  616. }
  617. sc, err := ln.Accept()
  618. if err != nil {
  619. t.Fatal(err)
  620. }
  621. ln.Close()
  622. ct.cc = cc
  623. ct.sc = sc
  624. ct.fr = NewFramer(sc, sc)
  625. return ct
  626. }
  627. func newLocalListener(t *testing.T) net.Listener {
  628. ln, err := net.Listen("tcp4", "127.0.0.1:0")
  629. if err == nil {
  630. return ln
  631. }
  632. ln, err = net.Listen("tcp6", "[::1]:0")
  633. if err != nil {
  634. t.Fatal(err)
  635. }
  636. return ln
  637. }
  638. func (ct *clientTester) greet(settings ...Setting) {
  639. buf := make([]byte, len(ClientPreface))
  640. _, err := io.ReadFull(ct.sc, buf)
  641. if err != nil {
  642. ct.t.Fatalf("reading client preface: %v", err)
  643. }
  644. f, err := ct.fr.ReadFrame()
  645. if err != nil {
  646. ct.t.Fatalf("Reading client settings frame: %v", err)
  647. }
  648. if sf, ok := f.(*SettingsFrame); !ok {
  649. ct.t.Fatalf("Wanted client settings frame; got %v", f)
  650. _ = sf // stash it away?
  651. }
  652. if err := ct.fr.WriteSettings(settings...); err != nil {
  653. ct.t.Fatal(err)
  654. }
  655. if err := ct.fr.WriteSettingsAck(); err != nil {
  656. ct.t.Fatal(err)
  657. }
  658. }
  659. func (ct *clientTester) readNonSettingsFrame() (Frame, error) {
  660. for {
  661. f, err := ct.fr.ReadFrame()
  662. if err != nil {
  663. return nil, err
  664. }
  665. if _, ok := f.(*SettingsFrame); ok {
  666. continue
  667. }
  668. return f, nil
  669. }
  670. }
  671. func (ct *clientTester) cleanup() {
  672. ct.tr.CloseIdleConnections()
  673. }
  674. func (ct *clientTester) run() {
  675. errc := make(chan error, 2)
  676. ct.start("client", errc, ct.client)
  677. ct.start("server", errc, ct.server)
  678. defer ct.cleanup()
  679. for i := 0; i < 2; i++ {
  680. if err := <-errc; err != nil {
  681. ct.t.Error(err)
  682. return
  683. }
  684. }
  685. }
  686. func (ct *clientTester) start(which string, errc chan<- error, fn func() error) {
  687. go func() {
  688. finished := false
  689. var err error
  690. defer func() {
  691. if !finished {
  692. err = fmt.Errorf("%s goroutine didn't finish.", which)
  693. } else if err != nil {
  694. err = fmt.Errorf("%s: %v", which, err)
  695. }
  696. errc <- err
  697. }()
  698. err = fn()
  699. finished = true
  700. }()
  701. }
  702. func (ct *clientTester) readFrame() (Frame, error) {
  703. return readFrameTimeout(ct.fr, 2*time.Second)
  704. }
  705. func (ct *clientTester) firstHeaders() (*HeadersFrame, error) {
  706. for {
  707. f, err := ct.readFrame()
  708. if err != nil {
  709. return nil, fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  710. }
  711. switch f.(type) {
  712. case *WindowUpdateFrame, *SettingsFrame:
  713. continue
  714. }
  715. hf, ok := f.(*HeadersFrame)
  716. if !ok {
  717. return nil, fmt.Errorf("Got %T; want HeadersFrame", f)
  718. }
  719. return hf, nil
  720. }
  721. }
  722. type countingReader struct {
  723. n *int64
  724. }
  725. func (r countingReader) Read(p []byte) (n int, err error) {
  726. for i := range p {
  727. p[i] = byte(i)
  728. }
  729. atomic.AddInt64(r.n, int64(len(p)))
  730. return len(p), err
  731. }
  732. func TestTransportReqBodyAfterResponse_200(t *testing.T) { testTransportReqBodyAfterResponse(t, 200) }
  733. func TestTransportReqBodyAfterResponse_403(t *testing.T) { testTransportReqBodyAfterResponse(t, 403) }
  734. func testTransportReqBodyAfterResponse(t *testing.T, status int) {
  735. const bodySize = 10 << 20
  736. clientDone := make(chan struct{})
  737. ct := newClientTester(t)
  738. ct.client = func() error {
  739. defer ct.cc.(*net.TCPConn).CloseWrite()
  740. defer close(clientDone)
  741. var n int64 // atomic
  742. req, err := http.NewRequest("PUT", "https://dummy.tld/", io.LimitReader(countingReader{&n}, bodySize))
  743. if err != nil {
  744. return err
  745. }
  746. res, err := ct.tr.RoundTrip(req)
  747. if err != nil {
  748. return fmt.Errorf("RoundTrip: %v", err)
  749. }
  750. defer res.Body.Close()
  751. if res.StatusCode != status {
  752. return fmt.Errorf("status code = %v; want %v", res.StatusCode, status)
  753. }
  754. slurp, err := ioutil.ReadAll(res.Body)
  755. if err != nil {
  756. return fmt.Errorf("Slurp: %v", err)
  757. }
  758. if len(slurp) > 0 {
  759. return fmt.Errorf("unexpected body: %q", slurp)
  760. }
  761. if status == 200 {
  762. if got := atomic.LoadInt64(&n); got != bodySize {
  763. return fmt.Errorf("For 200 response, Transport wrote %d bytes; want %d", got, bodySize)
  764. }
  765. } else {
  766. if got := atomic.LoadInt64(&n); got == 0 || got >= bodySize {
  767. return fmt.Errorf("For %d response, Transport wrote %d bytes; want (0,%d) exclusive", status, got, bodySize)
  768. }
  769. }
  770. return nil
  771. }
  772. ct.server = func() error {
  773. ct.greet()
  774. var buf bytes.Buffer
  775. enc := hpack.NewEncoder(&buf)
  776. var dataRecv int64
  777. var closed bool
  778. for {
  779. f, err := ct.fr.ReadFrame()
  780. if err != nil {
  781. select {
  782. case <-clientDone:
  783. // If the client's done, it
  784. // will have reported any
  785. // errors on its side.
  786. return nil
  787. default:
  788. return err
  789. }
  790. }
  791. //println(fmt.Sprintf("server got frame: %v", f))
  792. switch f := f.(type) {
  793. case *WindowUpdateFrame, *SettingsFrame:
  794. case *HeadersFrame:
  795. if !f.HeadersEnded() {
  796. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  797. }
  798. if f.StreamEnded() {
  799. return fmt.Errorf("headers contains END_STREAM unexpectedly: %v", f)
  800. }
  801. case *DataFrame:
  802. dataLen := len(f.Data())
  803. if dataLen > 0 {
  804. if dataRecv == 0 {
  805. enc.WriteField(hpack.HeaderField{Name: ":status", Value: strconv.Itoa(status)})
  806. ct.fr.WriteHeaders(HeadersFrameParam{
  807. StreamID: f.StreamID,
  808. EndHeaders: true,
  809. EndStream: false,
  810. BlockFragment: buf.Bytes(),
  811. })
  812. }
  813. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  814. return err
  815. }
  816. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  817. return err
  818. }
  819. }
  820. dataRecv += int64(dataLen)
  821. if !closed && ((status != 200 && dataRecv > 0) ||
  822. (status == 200 && dataRecv == bodySize)) {
  823. closed = true
  824. if err := ct.fr.WriteData(f.StreamID, true, nil); err != nil {
  825. return err
  826. }
  827. }
  828. default:
  829. return fmt.Errorf("Unexpected client frame %v", f)
  830. }
  831. }
  832. }
  833. ct.run()
  834. }
  835. // See golang.org/issue/13444
  836. func TestTransportFullDuplex(t *testing.T) {
  837. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  838. w.WriteHeader(200) // redundant but for clarity
  839. w.(http.Flusher).Flush()
  840. io.Copy(flushWriter{w}, capitalizeReader{r.Body})
  841. fmt.Fprintf(w, "bye.\n")
  842. }, optOnlyServer)
  843. defer st.Close()
  844. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  845. defer tr.CloseIdleConnections()
  846. c := &http.Client{Transport: tr}
  847. pr, pw := io.Pipe()
  848. req, err := http.NewRequest("PUT", st.ts.URL, ioutil.NopCloser(pr))
  849. if err != nil {
  850. t.Fatal(err)
  851. }
  852. req.ContentLength = -1
  853. res, err := c.Do(req)
  854. if err != nil {
  855. t.Fatal(err)
  856. }
  857. defer res.Body.Close()
  858. if res.StatusCode != 200 {
  859. t.Fatalf("StatusCode = %v; want %v", res.StatusCode, 200)
  860. }
  861. bs := bufio.NewScanner(res.Body)
  862. want := func(v string) {
  863. if !bs.Scan() {
  864. t.Fatalf("wanted to read %q but Scan() = false, err = %v", v, bs.Err())
  865. }
  866. }
  867. write := func(v string) {
  868. _, err := io.WriteString(pw, v)
  869. if err != nil {
  870. t.Fatalf("pipe write: %v", err)
  871. }
  872. }
  873. write("foo\n")
  874. want("FOO")
  875. write("bar\n")
  876. want("BAR")
  877. pw.Close()
  878. want("bye.")
  879. if err := bs.Err(); err != nil {
  880. t.Fatal(err)
  881. }
  882. }
  883. func TestTransportConnectRequest(t *testing.T) {
  884. gotc := make(chan *http.Request, 1)
  885. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  886. gotc <- r
  887. }, optOnlyServer)
  888. defer st.Close()
  889. u, err := url.Parse(st.ts.URL)
  890. if err != nil {
  891. t.Fatal(err)
  892. }
  893. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  894. defer tr.CloseIdleConnections()
  895. c := &http.Client{Transport: tr}
  896. tests := []struct {
  897. req *http.Request
  898. want string
  899. }{
  900. {
  901. req: &http.Request{
  902. Method: "CONNECT",
  903. Header: http.Header{},
  904. URL: u,
  905. },
  906. want: u.Host,
  907. },
  908. {
  909. req: &http.Request{
  910. Method: "CONNECT",
  911. Header: http.Header{},
  912. URL: u,
  913. Host: "example.com:123",
  914. },
  915. want: "example.com:123",
  916. },
  917. }
  918. for i, tt := range tests {
  919. res, err := c.Do(tt.req)
  920. if err != nil {
  921. t.Errorf("%d. RoundTrip = %v", i, err)
  922. continue
  923. }
  924. res.Body.Close()
  925. req := <-gotc
  926. if req.Method != "CONNECT" {
  927. t.Errorf("method = %q; want CONNECT", req.Method)
  928. }
  929. if req.Host != tt.want {
  930. t.Errorf("Host = %q; want %q", req.Host, tt.want)
  931. }
  932. if req.URL.Host != tt.want {
  933. t.Errorf("URL.Host = %q; want %q", req.URL.Host, tt.want)
  934. }
  935. }
  936. }
  937. type headerType int
  938. const (
  939. noHeader headerType = iota // omitted
  940. oneHeader
  941. splitHeader // broken into continuation on purpose
  942. )
  943. const (
  944. f0 = noHeader
  945. f1 = oneHeader
  946. f2 = splitHeader
  947. d0 = false
  948. d1 = true
  949. )
  950. // Test all 36 combinations of response frame orders:
  951. // (3 ways of 100-continue) * (2 ways of headers) * (2 ways of data) * (3 ways of trailers):func TestTransportResponsePattern_00f0(t *testing.T) { testTransportResponsePattern(h0, h1, false, h0) }
  952. // Generated by http://play.golang.org/p/SScqYKJYXd
  953. func TestTransportResPattern_c0h1d0t0(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f0) }
  954. func TestTransportResPattern_c0h1d0t1(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f1) }
  955. func TestTransportResPattern_c0h1d0t2(t *testing.T) { testTransportResPattern(t, f0, f1, d0, f2) }
  956. func TestTransportResPattern_c0h1d1t0(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f0) }
  957. func TestTransportResPattern_c0h1d1t1(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f1) }
  958. func TestTransportResPattern_c0h1d1t2(t *testing.T) { testTransportResPattern(t, f0, f1, d1, f2) }
  959. func TestTransportResPattern_c0h2d0t0(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f0) }
  960. func TestTransportResPattern_c0h2d0t1(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f1) }
  961. func TestTransportResPattern_c0h2d0t2(t *testing.T) { testTransportResPattern(t, f0, f2, d0, f2) }
  962. func TestTransportResPattern_c0h2d1t0(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f0) }
  963. func TestTransportResPattern_c0h2d1t1(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f1) }
  964. func TestTransportResPattern_c0h2d1t2(t *testing.T) { testTransportResPattern(t, f0, f2, d1, f2) }
  965. func TestTransportResPattern_c1h1d0t0(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f0) }
  966. func TestTransportResPattern_c1h1d0t1(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f1) }
  967. func TestTransportResPattern_c1h1d0t2(t *testing.T) { testTransportResPattern(t, f1, f1, d0, f2) }
  968. func TestTransportResPattern_c1h1d1t0(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f0) }
  969. func TestTransportResPattern_c1h1d1t1(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f1) }
  970. func TestTransportResPattern_c1h1d1t2(t *testing.T) { testTransportResPattern(t, f1, f1, d1, f2) }
  971. func TestTransportResPattern_c1h2d0t0(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f0) }
  972. func TestTransportResPattern_c1h2d0t1(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f1) }
  973. func TestTransportResPattern_c1h2d0t2(t *testing.T) { testTransportResPattern(t, f1, f2, d0, f2) }
  974. func TestTransportResPattern_c1h2d1t0(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f0) }
  975. func TestTransportResPattern_c1h2d1t1(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f1) }
  976. func TestTransportResPattern_c1h2d1t2(t *testing.T) { testTransportResPattern(t, f1, f2, d1, f2) }
  977. func TestTransportResPattern_c2h1d0t0(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f0) }
  978. func TestTransportResPattern_c2h1d0t1(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f1) }
  979. func TestTransportResPattern_c2h1d0t2(t *testing.T) { testTransportResPattern(t, f2, f1, d0, f2) }
  980. func TestTransportResPattern_c2h1d1t0(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f0) }
  981. func TestTransportResPattern_c2h1d1t1(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f1) }
  982. func TestTransportResPattern_c2h1d1t2(t *testing.T) { testTransportResPattern(t, f2, f1, d1, f2) }
  983. func TestTransportResPattern_c2h2d0t0(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f0) }
  984. func TestTransportResPattern_c2h2d0t1(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f1) }
  985. func TestTransportResPattern_c2h2d0t2(t *testing.T) { testTransportResPattern(t, f2, f2, d0, f2) }
  986. func TestTransportResPattern_c2h2d1t0(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f0) }
  987. func TestTransportResPattern_c2h2d1t1(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f1) }
  988. func TestTransportResPattern_c2h2d1t2(t *testing.T) { testTransportResPattern(t, f2, f2, d1, f2) }
  989. func testTransportResPattern(t *testing.T, expect100Continue, resHeader headerType, withData bool, trailers headerType) {
  990. const reqBody = "some request body"
  991. const resBody = "some response body"
  992. if resHeader == noHeader {
  993. // TODO: test 100-continue followed by immediate
  994. // server stream reset, without headers in the middle?
  995. panic("invalid combination")
  996. }
  997. ct := newClientTester(t)
  998. ct.client = func() error {
  999. req, _ := http.NewRequest("POST", "https://dummy.tld/", strings.NewReader(reqBody))
  1000. if expect100Continue != noHeader {
  1001. req.Header.Set("Expect", "100-continue")
  1002. }
  1003. res, err := ct.tr.RoundTrip(req)
  1004. if err != nil {
  1005. return fmt.Errorf("RoundTrip: %v", err)
  1006. }
  1007. defer res.Body.Close()
  1008. if res.StatusCode != 200 {
  1009. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1010. }
  1011. slurp, err := ioutil.ReadAll(res.Body)
  1012. if err != nil {
  1013. return fmt.Errorf("Slurp: %v", err)
  1014. }
  1015. wantBody := resBody
  1016. if !withData {
  1017. wantBody = ""
  1018. }
  1019. if string(slurp) != wantBody {
  1020. return fmt.Errorf("body = %q; want %q", slurp, wantBody)
  1021. }
  1022. if trailers == noHeader {
  1023. if len(res.Trailer) > 0 {
  1024. t.Errorf("Trailer = %v; want none", res.Trailer)
  1025. }
  1026. } else {
  1027. want := http.Header{"Some-Trailer": {"some-value"}}
  1028. if !reflect.DeepEqual(res.Trailer, want) {
  1029. t.Errorf("Trailer = %v; want %v", res.Trailer, want)
  1030. }
  1031. }
  1032. return nil
  1033. }
  1034. ct.server = func() error {
  1035. ct.greet()
  1036. var buf bytes.Buffer
  1037. enc := hpack.NewEncoder(&buf)
  1038. for {
  1039. f, err := ct.fr.ReadFrame()
  1040. if err != nil {
  1041. return err
  1042. }
  1043. endStream := false
  1044. send := func(mode headerType) {
  1045. hbf := buf.Bytes()
  1046. switch mode {
  1047. case oneHeader:
  1048. ct.fr.WriteHeaders(HeadersFrameParam{
  1049. StreamID: f.Header().StreamID,
  1050. EndHeaders: true,
  1051. EndStream: endStream,
  1052. BlockFragment: hbf,
  1053. })
  1054. case splitHeader:
  1055. if len(hbf) < 2 {
  1056. panic("too small")
  1057. }
  1058. ct.fr.WriteHeaders(HeadersFrameParam{
  1059. StreamID: f.Header().StreamID,
  1060. EndHeaders: false,
  1061. EndStream: endStream,
  1062. BlockFragment: hbf[:1],
  1063. })
  1064. ct.fr.WriteContinuation(f.Header().StreamID, true, hbf[1:])
  1065. default:
  1066. panic("bogus mode")
  1067. }
  1068. }
  1069. switch f := f.(type) {
  1070. case *WindowUpdateFrame, *SettingsFrame:
  1071. case *DataFrame:
  1072. if !f.StreamEnded() {
  1073. // No need to send flow control tokens. The test request body is tiny.
  1074. continue
  1075. }
  1076. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  1077. {
  1078. buf.Reset()
  1079. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1080. enc.WriteField(hpack.HeaderField{Name: "x-foo", Value: "blah"})
  1081. enc.WriteField(hpack.HeaderField{Name: "x-bar", Value: "more"})
  1082. if trailers != noHeader {
  1083. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "some-trailer"})
  1084. }
  1085. endStream = withData == false && trailers == noHeader
  1086. send(resHeader)
  1087. }
  1088. if withData {
  1089. endStream = trailers == noHeader
  1090. ct.fr.WriteData(f.StreamID, endStream, []byte(resBody))
  1091. }
  1092. if trailers != noHeader {
  1093. endStream = true
  1094. buf.Reset()
  1095. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "some-value"})
  1096. send(trailers)
  1097. }
  1098. if endStream {
  1099. return nil
  1100. }
  1101. case *HeadersFrame:
  1102. if expect100Continue != noHeader {
  1103. buf.Reset()
  1104. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "100"})
  1105. send(expect100Continue)
  1106. }
  1107. }
  1108. }
  1109. }
  1110. ct.run()
  1111. }
  1112. func TestTransportReceiveUndeclaredTrailer(t *testing.T) {
  1113. ct := newClientTester(t)
  1114. ct.client = func() error {
  1115. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1116. res, err := ct.tr.RoundTrip(req)
  1117. if err != nil {
  1118. return fmt.Errorf("RoundTrip: %v", err)
  1119. }
  1120. defer res.Body.Close()
  1121. if res.StatusCode != 200 {
  1122. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1123. }
  1124. slurp, err := ioutil.ReadAll(res.Body)
  1125. if err != nil {
  1126. return fmt.Errorf("res.Body ReadAll error = %q, %v; want %v", slurp, err, nil)
  1127. }
  1128. if len(slurp) > 0 {
  1129. return fmt.Errorf("body = %q; want nothing", slurp)
  1130. }
  1131. if _, ok := res.Trailer["Some-Trailer"]; !ok {
  1132. return fmt.Errorf("expected Some-Trailer")
  1133. }
  1134. return nil
  1135. }
  1136. ct.server = func() error {
  1137. ct.greet()
  1138. var n int
  1139. var hf *HeadersFrame
  1140. for hf == nil && n < 10 {
  1141. f, err := ct.fr.ReadFrame()
  1142. if err != nil {
  1143. return err
  1144. }
  1145. hf, _ = f.(*HeadersFrame)
  1146. n++
  1147. }
  1148. var buf bytes.Buffer
  1149. enc := hpack.NewEncoder(&buf)
  1150. // send headers without Trailer header
  1151. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1152. ct.fr.WriteHeaders(HeadersFrameParam{
  1153. StreamID: hf.StreamID,
  1154. EndHeaders: true,
  1155. EndStream: false,
  1156. BlockFragment: buf.Bytes(),
  1157. })
  1158. // send trailers
  1159. buf.Reset()
  1160. enc.WriteField(hpack.HeaderField{Name: "some-trailer", Value: "I'm an undeclared Trailer!"})
  1161. ct.fr.WriteHeaders(HeadersFrameParam{
  1162. StreamID: hf.StreamID,
  1163. EndHeaders: true,
  1164. EndStream: true,
  1165. BlockFragment: buf.Bytes(),
  1166. })
  1167. return nil
  1168. }
  1169. ct.run()
  1170. }
  1171. func TestTransportInvalidTrailer_Pseudo1(t *testing.T) {
  1172. testTransportInvalidTrailer_Pseudo(t, oneHeader)
  1173. }
  1174. func TestTransportInvalidTrailer_Pseudo2(t *testing.T) {
  1175. testTransportInvalidTrailer_Pseudo(t, splitHeader)
  1176. }
  1177. func testTransportInvalidTrailer_Pseudo(t *testing.T, trailers headerType) {
  1178. testInvalidTrailer(t, trailers, pseudoHeaderError(":colon"), func(enc *hpack.Encoder) {
  1179. enc.WriteField(hpack.HeaderField{Name: ":colon", Value: "foo"})
  1180. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1181. })
  1182. }
  1183. func TestTransportInvalidTrailer_Capital1(t *testing.T) {
  1184. testTransportInvalidTrailer_Capital(t, oneHeader)
  1185. }
  1186. func TestTransportInvalidTrailer_Capital2(t *testing.T) {
  1187. testTransportInvalidTrailer_Capital(t, splitHeader)
  1188. }
  1189. func testTransportInvalidTrailer_Capital(t *testing.T, trailers headerType) {
  1190. testInvalidTrailer(t, trailers, headerFieldNameError("Capital"), func(enc *hpack.Encoder) {
  1191. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  1192. enc.WriteField(hpack.HeaderField{Name: "Capital", Value: "bad"})
  1193. })
  1194. }
  1195. func TestTransportInvalidTrailer_EmptyFieldName(t *testing.T) {
  1196. testInvalidTrailer(t, oneHeader, headerFieldNameError(""), func(enc *hpack.Encoder) {
  1197. enc.WriteField(hpack.HeaderField{Name: "", Value: "bad"})
  1198. })
  1199. }
  1200. func TestTransportInvalidTrailer_BinaryFieldValue(t *testing.T) {
  1201. testInvalidTrailer(t, oneHeader, headerFieldValueError("has\nnewline"), func(enc *hpack.Encoder) {
  1202. enc.WriteField(hpack.HeaderField{Name: "x", Value: "has\nnewline"})
  1203. })
  1204. }
  1205. func testInvalidTrailer(t *testing.T, trailers headerType, wantErr error, writeTrailer func(*hpack.Encoder)) {
  1206. ct := newClientTester(t)
  1207. ct.client = func() error {
  1208. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1209. res, err := ct.tr.RoundTrip(req)
  1210. if err != nil {
  1211. return fmt.Errorf("RoundTrip: %v", err)
  1212. }
  1213. defer res.Body.Close()
  1214. if res.StatusCode != 200 {
  1215. return fmt.Errorf("status code = %v; want 200", res.StatusCode)
  1216. }
  1217. slurp, err := ioutil.ReadAll(res.Body)
  1218. se, ok := err.(StreamError)
  1219. if !ok || se.Cause != wantErr {
  1220. return fmt.Errorf("res.Body ReadAll error = %q, %#v; want StreamError with cause %T, %#v", slurp, err, wantErr, wantErr)
  1221. }
  1222. if len(slurp) > 0 {
  1223. return fmt.Errorf("body = %q; want nothing", slurp)
  1224. }
  1225. return nil
  1226. }
  1227. ct.server = func() error {
  1228. ct.greet()
  1229. var buf bytes.Buffer
  1230. enc := hpack.NewEncoder(&buf)
  1231. for {
  1232. f, err := ct.fr.ReadFrame()
  1233. if err != nil {
  1234. return err
  1235. }
  1236. switch f := f.(type) {
  1237. case *HeadersFrame:
  1238. var endStream bool
  1239. send := func(mode headerType) {
  1240. hbf := buf.Bytes()
  1241. switch mode {
  1242. case oneHeader:
  1243. ct.fr.WriteHeaders(HeadersFrameParam{
  1244. StreamID: f.StreamID,
  1245. EndHeaders: true,
  1246. EndStream: endStream,
  1247. BlockFragment: hbf,
  1248. })
  1249. case splitHeader:
  1250. if len(hbf) < 2 {
  1251. panic("too small")
  1252. }
  1253. ct.fr.WriteHeaders(HeadersFrameParam{
  1254. StreamID: f.StreamID,
  1255. EndHeaders: false,
  1256. EndStream: endStream,
  1257. BlockFragment: hbf[:1],
  1258. })
  1259. ct.fr.WriteContinuation(f.StreamID, true, hbf[1:])
  1260. default:
  1261. panic("bogus mode")
  1262. }
  1263. }
  1264. // Response headers (1+ frames; 1 or 2 in this test, but never 0)
  1265. {
  1266. buf.Reset()
  1267. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1268. enc.WriteField(hpack.HeaderField{Name: "trailer", Value: "declared"})
  1269. endStream = false
  1270. send(oneHeader)
  1271. }
  1272. // Trailers:
  1273. {
  1274. endStream = true
  1275. buf.Reset()
  1276. writeTrailer(enc)
  1277. send(trailers)
  1278. }
  1279. return nil
  1280. }
  1281. }
  1282. }
  1283. ct.run()
  1284. }
  1285. // headerListSize returns the HTTP2 header list size of h.
  1286. // http://httpwg.org/specs/rfc7540.html#SETTINGS_MAX_HEADER_LIST_SIZE
  1287. // http://httpwg.org/specs/rfc7540.html#MaxHeaderBlock
  1288. func headerListSize(h http.Header) (size uint32) {
  1289. for k, vv := range h {
  1290. for _, v := range vv {
  1291. hf := hpack.HeaderField{Name: k, Value: v}
  1292. size += hf.Size()
  1293. }
  1294. }
  1295. return size
  1296. }
  1297. // padHeaders adds data to an http.Header until headerListSize(h) ==
  1298. // limit. Due to the way header list sizes are calculated, padHeaders
  1299. // cannot add fewer than len("Pad-Headers") + 32 bytes to h, and will
  1300. // call t.Fatal if asked to do so. PadHeaders first reserves enough
  1301. // space for an empty "Pad-Headers" key, then adds as many copies of
  1302. // filler as possible. Any remaining bytes necessary to push the
  1303. // header list size up to limit are added to h["Pad-Headers"].
  1304. func padHeaders(t *testing.T, h http.Header, limit uint64, filler string) {
  1305. if limit > 0xffffffff {
  1306. t.Fatalf("padHeaders: refusing to pad to more than 2^32-1 bytes. limit = %v", limit)
  1307. }
  1308. hf := hpack.HeaderField{Name: "Pad-Headers", Value: ""}
  1309. minPadding := uint64(hf.Size())
  1310. size := uint64(headerListSize(h))
  1311. minlimit := size + minPadding
  1312. if limit < minlimit {
  1313. t.Fatalf("padHeaders: limit %v < %v", limit, minlimit)
  1314. }
  1315. // Use a fixed-width format for name so that fieldSize
  1316. // remains constant.
  1317. nameFmt := "Pad-Headers-%06d"
  1318. hf = hpack.HeaderField{Name: fmt.Sprintf(nameFmt, 1), Value: filler}
  1319. fieldSize := uint64(hf.Size())
  1320. // Add as many complete filler values as possible, leaving
  1321. // room for at least one empty "Pad-Headers" key.
  1322. limit = limit - minPadding
  1323. for i := 0; size+fieldSize < limit; i++ {
  1324. name := fmt.Sprintf(nameFmt, i)
  1325. h.Add(name, filler)
  1326. size += fieldSize
  1327. }
  1328. // Add enough bytes to reach limit.
  1329. remain := limit - size
  1330. lastValue := strings.Repeat("*", int(remain))
  1331. h.Add("Pad-Headers", lastValue)
  1332. }
  1333. func TestPadHeaders(t *testing.T) {
  1334. check := func(h http.Header, limit uint32, fillerLen int) {
  1335. if h == nil {
  1336. h = make(http.Header)
  1337. }
  1338. filler := strings.Repeat("f", fillerLen)
  1339. padHeaders(t, h, uint64(limit), filler)
  1340. gotSize := headerListSize(h)
  1341. if gotSize != limit {
  1342. t.Errorf("Got size = %v; want %v", gotSize, limit)
  1343. }
  1344. }
  1345. // Try all possible combinations for small fillerLen and limit.
  1346. hf := hpack.HeaderField{Name: "Pad-Headers", Value: ""}
  1347. minLimit := hf.Size()
  1348. for limit := minLimit; limit <= 128; limit++ {
  1349. for fillerLen := 0; uint32(fillerLen) <= limit; fillerLen++ {
  1350. check(nil, limit, fillerLen)
  1351. }
  1352. }
  1353. // Try a few tests with larger limits, plus cumulative
  1354. // tests. Since these tests are cumulative, tests[i+1].limit
  1355. // must be >= tests[i].limit + minLimit. See the comment on
  1356. // padHeaders for more info on why the limit arg has this
  1357. // restriction.
  1358. tests := []struct {
  1359. fillerLen int
  1360. limit uint32
  1361. }{
  1362. {
  1363. fillerLen: 64,
  1364. limit: 1024,
  1365. },
  1366. {
  1367. fillerLen: 1024,
  1368. limit: 1286,
  1369. },
  1370. {
  1371. fillerLen: 256,
  1372. limit: 2048,
  1373. },
  1374. {
  1375. fillerLen: 1024,
  1376. limit: 10 * 1024,
  1377. },
  1378. {
  1379. fillerLen: 1023,
  1380. limit: 11 * 1024,
  1381. },
  1382. }
  1383. h := make(http.Header)
  1384. for _, tc := range tests {
  1385. check(nil, tc.limit, tc.fillerLen)
  1386. check(h, tc.limit, tc.fillerLen)
  1387. }
  1388. }
  1389. func TestTransportChecksRequestHeaderListSize(t *testing.T) {
  1390. st := newServerTester(t,
  1391. func(w http.ResponseWriter, r *http.Request) {
  1392. // Consume body & force client to send
  1393. // trailers before writing response.
  1394. // ioutil.ReadAll returns non-nil err for
  1395. // requests that attempt to send greater than
  1396. // maxHeaderListSize bytes of trailers, since
  1397. // those requests generate a stream reset.
  1398. ioutil.ReadAll(r.Body)
  1399. r.Body.Close()
  1400. },
  1401. func(ts *httptest.Server) {
  1402. ts.Config.MaxHeaderBytes = 16 << 10
  1403. },
  1404. optOnlyServer,
  1405. optQuiet,
  1406. )
  1407. defer st.Close()
  1408. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1409. defer tr.CloseIdleConnections()
  1410. checkRoundTrip := func(req *http.Request, wantErr error, desc string) {
  1411. res, err := tr.RoundTrip(req)
  1412. if err != wantErr {
  1413. if res != nil {
  1414. res.Body.Close()
  1415. }
  1416. t.Errorf("%v: RoundTrip err = %v; want %v", desc, err, wantErr)
  1417. return
  1418. }
  1419. if err == nil {
  1420. if res == nil {
  1421. t.Errorf("%v: response nil; want non-nil.", desc)
  1422. return
  1423. }
  1424. defer res.Body.Close()
  1425. if res.StatusCode != http.StatusOK {
  1426. t.Errorf("%v: response status = %v; want %v", desc, res.StatusCode, http.StatusOK)
  1427. }
  1428. return
  1429. }
  1430. if res != nil {
  1431. t.Errorf("%v: RoundTrip err = %v but response non-nil", desc, err)
  1432. }
  1433. }
  1434. headerListSizeForRequest := func(req *http.Request) (size uint64) {
  1435. contentLen := actualContentLength(req)
  1436. trailers, err := commaSeparatedTrailers(req)
  1437. if err != nil {
  1438. t.Fatalf("headerListSizeForRequest: %v", err)
  1439. }
  1440. cc := &ClientConn{peerMaxHeaderListSize: 0xffffffffffffffff}
  1441. cc.henc = hpack.NewEncoder(&cc.hbuf)
  1442. cc.mu.Lock()
  1443. hdrs, err := cc.encodeHeaders(req, true, trailers, contentLen)
  1444. cc.mu.Unlock()
  1445. if err != nil {
  1446. t.Fatalf("headerListSizeForRequest: %v", err)
  1447. }
  1448. hpackDec := hpack.NewDecoder(initialHeaderTableSize, func(hf hpack.HeaderField) {
  1449. size += uint64(hf.Size())
  1450. })
  1451. if len(hdrs) > 0 {
  1452. if _, err := hpackDec.Write(hdrs); err != nil {
  1453. t.Fatalf("headerListSizeForRequest: %v", err)
  1454. }
  1455. }
  1456. return size
  1457. }
  1458. // Create a new Request for each test, rather than reusing the
  1459. // same Request, to avoid a race when modifying req.Headers.
  1460. // See https://github.com/golang/go/issues/21316
  1461. newRequest := func() *http.Request {
  1462. // Body must be non-nil to enable writing trailers.
  1463. body := strings.NewReader("hello")
  1464. req, err := http.NewRequest("POST", st.ts.URL, body)
  1465. if err != nil {
  1466. t.Fatalf("newRequest: NewRequest: %v", err)
  1467. }
  1468. return req
  1469. }
  1470. // Make an arbitrary request to ensure we get the server's
  1471. // settings frame and initialize peerMaxHeaderListSize.
  1472. req := newRequest()
  1473. checkRoundTrip(req, nil, "Initial request")
  1474. // Get the ClientConn associated with the request and validate
  1475. // peerMaxHeaderListSize.
  1476. addr := authorityAddr(req.URL.Scheme, req.URL.Host)
  1477. cc, err := tr.connPool().GetClientConn(req, addr)
  1478. if err != nil {
  1479. t.Fatalf("GetClientConn: %v", err)
  1480. }
  1481. cc.mu.Lock()
  1482. peerSize := cc.peerMaxHeaderListSize
  1483. cc.mu.Unlock()
  1484. st.scMu.Lock()
  1485. wantSize := uint64(st.sc.maxHeaderListSize())
  1486. st.scMu.Unlock()
  1487. if peerSize != wantSize {
  1488. t.Errorf("peerMaxHeaderListSize = %v; want %v", peerSize, wantSize)
  1489. }
  1490. // Sanity check peerSize. (*serverConn) maxHeaderListSize adds
  1491. // 320 bytes of padding.
  1492. wantHeaderBytes := uint64(st.ts.Config.MaxHeaderBytes) + 320
  1493. if peerSize != wantHeaderBytes {
  1494. t.Errorf("peerMaxHeaderListSize = %v; want %v.", peerSize, wantHeaderBytes)
  1495. }
  1496. // Pad headers & trailers, but stay under peerSize.
  1497. req = newRequest()
  1498. req.Header = make(http.Header)
  1499. req.Trailer = make(http.Header)
  1500. filler := strings.Repeat("*", 1024)
  1501. padHeaders(t, req.Trailer, peerSize, filler)
  1502. // cc.encodeHeaders adds some default headers to the request,
  1503. // so we need to leave room for those.
  1504. defaultBytes := headerListSizeForRequest(req)
  1505. padHeaders(t, req.Header, peerSize-defaultBytes, filler)
  1506. checkRoundTrip(req, nil, "Headers & Trailers under limit")
  1507. // Add enough header bytes to push us over peerSize.
  1508. req = newRequest()
  1509. req.Header = make(http.Header)
  1510. padHeaders(t, req.Header, peerSize, filler)
  1511. checkRoundTrip(req, errRequestHeaderListSize, "Headers over limit")
  1512. // Push trailers over the limit.
  1513. req = newRequest()
  1514. req.Trailer = make(http.Header)
  1515. padHeaders(t, req.Trailer, peerSize+1, filler)
  1516. checkRoundTrip(req, errRequestHeaderListSize, "Trailers over limit")
  1517. // Send headers with a single large value.
  1518. req = newRequest()
  1519. filler = strings.Repeat("*", int(peerSize))
  1520. req.Header = make(http.Header)
  1521. req.Header.Set("Big", filler)
  1522. checkRoundTrip(req, errRequestHeaderListSize, "Single large header")
  1523. // Send trailers with a single large value.
  1524. req = newRequest()
  1525. req.Trailer = make(http.Header)
  1526. req.Trailer.Set("Big", filler)
  1527. checkRoundTrip(req, errRequestHeaderListSize, "Single large trailer")
  1528. }
  1529. func TestTransportChecksResponseHeaderListSize(t *testing.T) {
  1530. ct := newClientTester(t)
  1531. ct.client = func() error {
  1532. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  1533. res, err := ct.tr.RoundTrip(req)
  1534. if err != errResponseHeaderListSize {
  1535. if res != nil {
  1536. res.Body.Close()
  1537. }
  1538. size := int64(0)
  1539. for k, vv := range res.Header {
  1540. for _, v := range vv {
  1541. size += int64(len(k)) + int64(len(v)) + 32
  1542. }
  1543. }
  1544. return fmt.Errorf("RoundTrip Error = %v (and %d bytes of response headers); want errResponseHeaderListSize", err, size)
  1545. }
  1546. return nil
  1547. }
  1548. ct.server = func() error {
  1549. ct.greet()
  1550. var buf bytes.Buffer
  1551. enc := hpack.NewEncoder(&buf)
  1552. for {
  1553. f, err := ct.fr.ReadFrame()
  1554. if err != nil {
  1555. return err
  1556. }
  1557. switch f := f.(type) {
  1558. case *HeadersFrame:
  1559. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  1560. large := strings.Repeat("a", 1<<10)
  1561. for i := 0; i < 5042; i++ {
  1562. enc.WriteField(hpack.HeaderField{Name: large, Value: large})
  1563. }
  1564. if size, want := buf.Len(), 6329; size != want {
  1565. // Note: this number might change if
  1566. // our hpack implementation
  1567. // changes. That's fine. This is
  1568. // just a sanity check that our
  1569. // response can fit in a single
  1570. // header block fragment frame.
  1571. return fmt.Errorf("encoding over 10MB of duplicate keypairs took %d bytes; expected %d", size, want)
  1572. }
  1573. ct.fr.WriteHeaders(HeadersFrameParam{
  1574. StreamID: f.StreamID,
  1575. EndHeaders: true,
  1576. EndStream: true,
  1577. BlockFragment: buf.Bytes(),
  1578. })
  1579. return nil
  1580. }
  1581. }
  1582. }
  1583. ct.run()
  1584. }
  1585. // Test that the the Transport returns a typed error from Response.Body.Read calls
  1586. // when the server sends an error. (here we use a panic, since that should generate
  1587. // a stream error, but others like cancel should be similar)
  1588. func TestTransportBodyReadErrorType(t *testing.T) {
  1589. doPanic := make(chan bool, 1)
  1590. st := newServerTester(t,
  1591. func(w http.ResponseWriter, r *http.Request) {
  1592. w.(http.Flusher).Flush() // force headers out
  1593. <-doPanic
  1594. panic("boom")
  1595. },
  1596. optOnlyServer,
  1597. optQuiet,
  1598. )
  1599. defer st.Close()
  1600. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1601. defer tr.CloseIdleConnections()
  1602. c := &http.Client{Transport: tr}
  1603. res, err := c.Get(st.ts.URL)
  1604. if err != nil {
  1605. t.Fatal(err)
  1606. }
  1607. defer res.Body.Close()
  1608. doPanic <- true
  1609. buf := make([]byte, 100)
  1610. n, err := res.Body.Read(buf)
  1611. want := StreamError{StreamID: 0x1, Code: 0x2}
  1612. if !reflect.DeepEqual(want, err) {
  1613. t.Errorf("Read = %v, %#v; want error %#v", n, err, want)
  1614. }
  1615. }
  1616. // golang.org/issue/13924
  1617. // This used to fail after many iterations, especially with -race:
  1618. // go test -v -run=TestTransportDoubleCloseOnWriteError -count=500 -race
  1619. func TestTransportDoubleCloseOnWriteError(t *testing.T) {
  1620. var (
  1621. mu sync.Mutex
  1622. conn net.Conn // to close if set
  1623. )
  1624. st := newServerTester(t,
  1625. func(w http.ResponseWriter, r *http.Request) {
  1626. mu.Lock()
  1627. defer mu.Unlock()
  1628. if conn != nil {
  1629. conn.Close()
  1630. }
  1631. },
  1632. optOnlyServer,
  1633. )
  1634. defer st.Close()
  1635. tr := &Transport{
  1636. TLSClientConfig: tlsConfigInsecure,
  1637. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1638. tc, err := tls.Dial(network, addr, cfg)
  1639. if err != nil {
  1640. return nil, err
  1641. }
  1642. mu.Lock()
  1643. defer mu.Unlock()
  1644. conn = tc
  1645. return tc, nil
  1646. },
  1647. }
  1648. defer tr.CloseIdleConnections()
  1649. c := &http.Client{Transport: tr}
  1650. c.Get(st.ts.URL)
  1651. }
  1652. // Test that the http1 Transport.DisableKeepAlives option is respected
  1653. // and connections are closed as soon as idle.
  1654. // See golang.org/issue/14008
  1655. func TestTransportDisableKeepAlives(t *testing.T) {
  1656. st := newServerTester(t,
  1657. func(w http.ResponseWriter, r *http.Request) {
  1658. io.WriteString(w, "hi")
  1659. },
  1660. optOnlyServer,
  1661. )
  1662. defer st.Close()
  1663. connClosed := make(chan struct{}) // closed on tls.Conn.Close
  1664. tr := &Transport{
  1665. t1: &http.Transport{
  1666. DisableKeepAlives: true,
  1667. },
  1668. TLSClientConfig: tlsConfigInsecure,
  1669. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1670. tc, err := tls.Dial(network, addr, cfg)
  1671. if err != nil {
  1672. return nil, err
  1673. }
  1674. return &noteCloseConn{Conn: tc, closefn: func() { close(connClosed) }}, nil
  1675. },
  1676. }
  1677. c := &http.Client{Transport: tr}
  1678. res, err := c.Get(st.ts.URL)
  1679. if err != nil {
  1680. t.Fatal(err)
  1681. }
  1682. if _, err := ioutil.ReadAll(res.Body); err != nil {
  1683. t.Fatal(err)
  1684. }
  1685. defer res.Body.Close()
  1686. select {
  1687. case <-connClosed:
  1688. case <-time.After(1 * time.Second):
  1689. t.Errorf("timeout")
  1690. }
  1691. }
  1692. // Test concurrent requests with Transport.DisableKeepAlives. We can share connections,
  1693. // but when things are totally idle, it still needs to close.
  1694. func TestTransportDisableKeepAlives_Concurrency(t *testing.T) {
  1695. const D = 25 * time.Millisecond
  1696. st := newServerTester(t,
  1697. func(w http.ResponseWriter, r *http.Request) {
  1698. time.Sleep(D)
  1699. io.WriteString(w, "hi")
  1700. },
  1701. optOnlyServer,
  1702. )
  1703. defer st.Close()
  1704. var dials int32
  1705. var conns sync.WaitGroup
  1706. tr := &Transport{
  1707. t1: &http.Transport{
  1708. DisableKeepAlives: true,
  1709. },
  1710. TLSClientConfig: tlsConfigInsecure,
  1711. DialTLS: func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  1712. tc, err := tls.Dial(network, addr, cfg)
  1713. if err != nil {
  1714. return nil, err
  1715. }
  1716. atomic.AddInt32(&dials, 1)
  1717. conns.Add(1)
  1718. return &noteCloseConn{Conn: tc, closefn: func() { conns.Done() }}, nil
  1719. },
  1720. }
  1721. c := &http.Client{Transport: tr}
  1722. var reqs sync.WaitGroup
  1723. const N = 20
  1724. for i := 0; i < N; i++ {
  1725. reqs.Add(1)
  1726. if i == N-1 {
  1727. // For the final request, try to make all the
  1728. // others close. This isn't verified in the
  1729. // count, other than the Log statement, since
  1730. // it's so timing dependent. This test is
  1731. // really to make sure we don't interrupt a
  1732. // valid request.
  1733. time.Sleep(D * 2)
  1734. }
  1735. go func() {
  1736. defer reqs.Done()
  1737. res, err := c.Get(st.ts.URL)
  1738. if err != nil {
  1739. t.Error(err)
  1740. return
  1741. }
  1742. if _, err := ioutil.ReadAll(res.Body); err != nil {
  1743. t.Error(err)
  1744. return
  1745. }
  1746. res.Body.Close()
  1747. }()
  1748. }
  1749. reqs.Wait()
  1750. conns.Wait()
  1751. t.Logf("did %d dials, %d requests", atomic.LoadInt32(&dials), N)
  1752. }
  1753. type noteCloseConn struct {
  1754. net.Conn
  1755. onceClose sync.Once
  1756. closefn func()
  1757. }
  1758. func (c *noteCloseConn) Close() error {
  1759. c.onceClose.Do(c.closefn)
  1760. return c.Conn.Close()
  1761. }
  1762. func isTimeout(err error) bool {
  1763. switch err := err.(type) {
  1764. case nil:
  1765. return false
  1766. case *url.Error:
  1767. return isTimeout(err.Err)
  1768. case net.Error:
  1769. return err.Timeout()
  1770. }
  1771. return false
  1772. }
  1773. // Test that the http1 Transport.ResponseHeaderTimeout option and cancel is sent.
  1774. func TestTransportResponseHeaderTimeout_NoBody(t *testing.T) {
  1775. testTransportResponseHeaderTimeout(t, false)
  1776. }
  1777. func TestTransportResponseHeaderTimeout_Body(t *testing.T) {
  1778. testTransportResponseHeaderTimeout(t, true)
  1779. }
  1780. func testTransportResponseHeaderTimeout(t *testing.T, body bool) {
  1781. ct := newClientTester(t)
  1782. ct.tr.t1 = &http.Transport{
  1783. ResponseHeaderTimeout: 5 * time.Millisecond,
  1784. }
  1785. ct.client = func() error {
  1786. c := &http.Client{Transport: ct.tr}
  1787. var err error
  1788. var n int64
  1789. const bodySize = 4 << 20
  1790. if body {
  1791. _, err = c.Post("https://dummy.tld/", "text/foo", io.LimitReader(countingReader{&n}, bodySize))
  1792. } else {
  1793. _, err = c.Get("https://dummy.tld/")
  1794. }
  1795. if !isTimeout(err) {
  1796. t.Errorf("client expected timeout error; got %#v", err)
  1797. }
  1798. if body && n != bodySize {
  1799. t.Errorf("only read %d bytes of body; want %d", n, bodySize)
  1800. }
  1801. return nil
  1802. }
  1803. ct.server = func() error {
  1804. ct.greet()
  1805. for {
  1806. f, err := ct.fr.ReadFrame()
  1807. if err != nil {
  1808. t.Logf("ReadFrame: %v", err)
  1809. return nil
  1810. }
  1811. switch f := f.(type) {
  1812. case *DataFrame:
  1813. dataLen := len(f.Data())
  1814. if dataLen > 0 {
  1815. if err := ct.fr.WriteWindowUpdate(0, uint32(dataLen)); err != nil {
  1816. return err
  1817. }
  1818. if err := ct.fr.WriteWindowUpdate(f.StreamID, uint32(dataLen)); err != nil {
  1819. return err
  1820. }
  1821. }
  1822. case *RSTStreamFrame:
  1823. if f.StreamID == 1 && f.ErrCode == ErrCodeCancel {
  1824. return nil
  1825. }
  1826. }
  1827. }
  1828. }
  1829. ct.run()
  1830. }
  1831. func TestTransportDisableCompression(t *testing.T) {
  1832. const body = "sup"
  1833. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1834. want := http.Header{
  1835. "User-Agent": []string{"Go-http-client/2.0"},
  1836. }
  1837. if !reflect.DeepEqual(r.Header, want) {
  1838. t.Errorf("request headers = %v; want %v", r.Header, want)
  1839. }
  1840. }, optOnlyServer)
  1841. defer st.Close()
  1842. tr := &Transport{
  1843. TLSClientConfig: tlsConfigInsecure,
  1844. t1: &http.Transport{
  1845. DisableCompression: true,
  1846. },
  1847. }
  1848. defer tr.CloseIdleConnections()
  1849. req, err := http.NewRequest("GET", st.ts.URL, nil)
  1850. if err != nil {
  1851. t.Fatal(err)
  1852. }
  1853. res, err := tr.RoundTrip(req)
  1854. if err != nil {
  1855. t.Fatal(err)
  1856. }
  1857. defer res.Body.Close()
  1858. }
  1859. // RFC 7540 section 8.1.2.2
  1860. func TestTransportRejectsConnHeaders(t *testing.T) {
  1861. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1862. var got []string
  1863. for k := range r.Header {
  1864. got = append(got, k)
  1865. }
  1866. sort.Strings(got)
  1867. w.Header().Set("Got-Header", strings.Join(got, ","))
  1868. }, optOnlyServer)
  1869. defer st.Close()
  1870. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1871. defer tr.CloseIdleConnections()
  1872. tests := []struct {
  1873. key string
  1874. value []string
  1875. want string
  1876. }{
  1877. {
  1878. key: "Upgrade",
  1879. value: []string{"anything"},
  1880. want: "ERROR: http2: invalid Upgrade request header: [\"anything\"]",
  1881. },
  1882. {
  1883. key: "Connection",
  1884. value: []string{"foo"},
  1885. want: "ERROR: http2: invalid Connection request header: [\"foo\"]",
  1886. },
  1887. {
  1888. key: "Connection",
  1889. value: []string{"close"},
  1890. want: "Accept-Encoding,User-Agent",
  1891. },
  1892. {
  1893. key: "Connection",
  1894. value: []string{"close", "something-else"},
  1895. want: "ERROR: http2: invalid Connection request header: [\"close\" \"something-else\"]",
  1896. },
  1897. {
  1898. key: "Connection",
  1899. value: []string{"keep-alive"},
  1900. want: "Accept-Encoding,User-Agent",
  1901. },
  1902. {
  1903. key: "Proxy-Connection", // just deleted and ignored
  1904. value: []string{"keep-alive"},
  1905. want: "Accept-Encoding,User-Agent",
  1906. },
  1907. {
  1908. key: "Transfer-Encoding",
  1909. value: []string{""},
  1910. want: "Accept-Encoding,User-Agent",
  1911. },
  1912. {
  1913. key: "Transfer-Encoding",
  1914. value: []string{"foo"},
  1915. want: "ERROR: http2: invalid Transfer-Encoding request header: [\"foo\"]",
  1916. },
  1917. {
  1918. key: "Transfer-Encoding",
  1919. value: []string{"chunked"},
  1920. want: "Accept-Encoding,User-Agent",
  1921. },
  1922. {
  1923. key: "Transfer-Encoding",
  1924. value: []string{"chunked", "other"},
  1925. want: "ERROR: http2: invalid Transfer-Encoding request header: [\"chunked\" \"other\"]",
  1926. },
  1927. {
  1928. key: "Content-Length",
  1929. value: []string{"123"},
  1930. want: "Accept-Encoding,User-Agent",
  1931. },
  1932. {
  1933. key: "Keep-Alive",
  1934. value: []string{"doop"},
  1935. want: "Accept-Encoding,User-Agent",
  1936. },
  1937. }
  1938. for _, tt := range tests {
  1939. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  1940. req.Header[tt.key] = tt.value
  1941. res, err := tr.RoundTrip(req)
  1942. var got string
  1943. if err != nil {
  1944. got = fmt.Sprintf("ERROR: %v", err)
  1945. } else {
  1946. got = res.Header.Get("Got-Header")
  1947. res.Body.Close()
  1948. }
  1949. if got != tt.want {
  1950. t.Errorf("For key %q, value %q, got = %q; want %q", tt.key, tt.value, got, tt.want)
  1951. }
  1952. }
  1953. }
  1954. // golang.org/issue/14048
  1955. func TestTransportFailsOnInvalidHeaders(t *testing.T) {
  1956. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1957. var got []string
  1958. for k := range r.Header {
  1959. got = append(got, k)
  1960. }
  1961. sort.Strings(got)
  1962. w.Header().Set("Got-Header", strings.Join(got, ","))
  1963. }, optOnlyServer)
  1964. defer st.Close()
  1965. tests := [...]struct {
  1966. h http.Header
  1967. wantErr string
  1968. }{
  1969. 0: {
  1970. h: http.Header{"with space": {"foo"}},
  1971. wantErr: `invalid HTTP header name "with space"`,
  1972. },
  1973. 1: {
  1974. h: http.Header{"name": {"Брэд"}},
  1975. wantErr: "", // okay
  1976. },
  1977. 2: {
  1978. h: http.Header{"имя": {"Brad"}},
  1979. wantErr: `invalid HTTP header name "имя"`,
  1980. },
  1981. 3: {
  1982. h: http.Header{"foo": {"foo\x01bar"}},
  1983. wantErr: `invalid HTTP header value "foo\x01bar" for header "foo"`,
  1984. },
  1985. }
  1986. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  1987. defer tr.CloseIdleConnections()
  1988. for i, tt := range tests {
  1989. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  1990. req.Header = tt.h
  1991. res, err := tr.RoundTrip(req)
  1992. var bad bool
  1993. if tt.wantErr == "" {
  1994. if err != nil {
  1995. bad = true
  1996. t.Errorf("case %d: error = %v; want no error", i, err)
  1997. }
  1998. } else {
  1999. if !strings.Contains(fmt.Sprint(err), tt.wantErr) {
  2000. bad = true
  2001. t.Errorf("case %d: error = %v; want error %q", i, err, tt.wantErr)
  2002. }
  2003. }
  2004. if err == nil {
  2005. if bad {
  2006. t.Logf("case %d: server got headers %q", i, res.Header.Get("Got-Header"))
  2007. }
  2008. res.Body.Close()
  2009. }
  2010. }
  2011. }
  2012. // Tests that gzipReader doesn't crash on a second Read call following
  2013. // the first Read call's gzip.NewReader returning an error.
  2014. func TestGzipReader_DoubleReadCrash(t *testing.T) {
  2015. gz := &gzipReader{
  2016. body: ioutil.NopCloser(strings.NewReader("0123456789")),
  2017. }
  2018. var buf [1]byte
  2019. n, err1 := gz.Read(buf[:])
  2020. if n != 0 || !strings.Contains(fmt.Sprint(err1), "invalid header") {
  2021. t.Fatalf("Read = %v, %v; want 0, invalid header", n, err1)
  2022. }
  2023. n, err2 := gz.Read(buf[:])
  2024. if n != 0 || err2 != err1 {
  2025. t.Fatalf("second Read = %v, %v; want 0, %v", n, err2, err1)
  2026. }
  2027. }
  2028. func TestTransportNewTLSConfig(t *testing.T) {
  2029. tests := [...]struct {
  2030. conf *tls.Config
  2031. host string
  2032. want *tls.Config
  2033. }{
  2034. // Normal case.
  2035. 0: {
  2036. conf: nil,
  2037. host: "foo.com",
  2038. want: &tls.Config{
  2039. ServerName: "foo.com",
  2040. NextProtos: []string{NextProtoTLS},
  2041. },
  2042. },
  2043. // User-provided name (bar.com) takes precedence:
  2044. 1: {
  2045. conf: &tls.Config{
  2046. ServerName: "bar.com",
  2047. },
  2048. host: "foo.com",
  2049. want: &tls.Config{
  2050. ServerName: "bar.com",
  2051. NextProtos: []string{NextProtoTLS},
  2052. },
  2053. },
  2054. // NextProto is prepended:
  2055. 2: {
  2056. conf: &tls.Config{
  2057. NextProtos: []string{"foo", "bar"},
  2058. },
  2059. host: "example.com",
  2060. want: &tls.Config{
  2061. ServerName: "example.com",
  2062. NextProtos: []string{NextProtoTLS, "foo", "bar"},
  2063. },
  2064. },
  2065. // NextProto is not duplicated:
  2066. 3: {
  2067. conf: &tls.Config{
  2068. NextProtos: []string{"foo", "bar", NextProtoTLS},
  2069. },
  2070. host: "example.com",
  2071. want: &tls.Config{
  2072. ServerName: "example.com",
  2073. NextProtos: []string{"foo", "bar", NextProtoTLS},
  2074. },
  2075. },
  2076. }
  2077. for i, tt := range tests {
  2078. // Ignore the session ticket keys part, which ends up populating
  2079. // unexported fields in the Config:
  2080. if tt.conf != nil {
  2081. tt.conf.SessionTicketsDisabled = true
  2082. }
  2083. tr := &Transport{TLSClientConfig: tt.conf}
  2084. got := tr.newTLSConfig(tt.host)
  2085. got.SessionTicketsDisabled = false
  2086. if !reflect.DeepEqual(got, tt.want) {
  2087. t.Errorf("%d. got %#v; want %#v", i, got, tt.want)
  2088. }
  2089. }
  2090. }
  2091. // The Google GFE responds to HEAD requests with a HEADERS frame
  2092. // without END_STREAM, followed by a 0-length DATA frame with
  2093. // END_STREAM. Make sure we don't get confused by that. (We did.)
  2094. func TestTransportReadHeadResponse(t *testing.T) {
  2095. ct := newClientTester(t)
  2096. clientDone := make(chan struct{})
  2097. ct.client = func() error {
  2098. defer close(clientDone)
  2099. req, _ := http.NewRequest("HEAD", "https://dummy.tld/", nil)
  2100. res, err := ct.tr.RoundTrip(req)
  2101. if err != nil {
  2102. return err
  2103. }
  2104. if res.ContentLength != 123 {
  2105. return fmt.Errorf("Content-Length = %d; want 123", res.ContentLength)
  2106. }
  2107. slurp, err := ioutil.ReadAll(res.Body)
  2108. if err != nil {
  2109. return fmt.Errorf("ReadAll: %v", err)
  2110. }
  2111. if len(slurp) > 0 {
  2112. return fmt.Errorf("Unexpected non-empty ReadAll body: %q", slurp)
  2113. }
  2114. return nil
  2115. }
  2116. ct.server = func() error {
  2117. ct.greet()
  2118. for {
  2119. f, err := ct.fr.ReadFrame()
  2120. if err != nil {
  2121. t.Logf("ReadFrame: %v", err)
  2122. return nil
  2123. }
  2124. hf, ok := f.(*HeadersFrame)
  2125. if !ok {
  2126. continue
  2127. }
  2128. var buf bytes.Buffer
  2129. enc := hpack.NewEncoder(&buf)
  2130. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2131. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "123"})
  2132. ct.fr.WriteHeaders(HeadersFrameParam{
  2133. StreamID: hf.StreamID,
  2134. EndHeaders: true,
  2135. EndStream: false, // as the GFE does
  2136. BlockFragment: buf.Bytes(),
  2137. })
  2138. ct.fr.WriteData(hf.StreamID, true, nil)
  2139. <-clientDone
  2140. return nil
  2141. }
  2142. }
  2143. ct.run()
  2144. }
  2145. type neverEnding byte
  2146. func (b neverEnding) Read(p []byte) (int, error) {
  2147. for i := range p {
  2148. p[i] = byte(b)
  2149. }
  2150. return len(p), nil
  2151. }
  2152. // golang.org/issue/15425: test that a handler closing the request
  2153. // body doesn't terminate the stream to the peer. (It just stops
  2154. // readability from the handler's side, and eventually the client
  2155. // runs out of flow control tokens)
  2156. func TestTransportHandlerBodyClose(t *testing.T) {
  2157. const bodySize = 10 << 20
  2158. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2159. r.Body.Close()
  2160. io.Copy(w, io.LimitReader(neverEnding('A'), bodySize))
  2161. }, optOnlyServer)
  2162. defer st.Close()
  2163. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2164. defer tr.CloseIdleConnections()
  2165. g0 := runtime.NumGoroutine()
  2166. const numReq = 10
  2167. for i := 0; i < numReq; i++ {
  2168. req, err := http.NewRequest("POST", st.ts.URL, struct{ io.Reader }{io.LimitReader(neverEnding('A'), bodySize)})
  2169. if err != nil {
  2170. t.Fatal(err)
  2171. }
  2172. res, err := tr.RoundTrip(req)
  2173. if err != nil {
  2174. t.Fatal(err)
  2175. }
  2176. n, err := io.Copy(ioutil.Discard, res.Body)
  2177. res.Body.Close()
  2178. if n != bodySize || err != nil {
  2179. t.Fatalf("req#%d: Copy = %d, %v; want %d, nil", i, n, err, bodySize)
  2180. }
  2181. }
  2182. tr.CloseIdleConnections()
  2183. gd := runtime.NumGoroutine() - g0
  2184. if gd > numReq/2 {
  2185. t.Errorf("appeared to leak goroutines")
  2186. }
  2187. }
  2188. // https://golang.org/issue/15930
  2189. func TestTransportFlowControl(t *testing.T) {
  2190. const bufLen = 64 << 10
  2191. var total int64 = 100 << 20 // 100MB
  2192. if testing.Short() {
  2193. total = 10 << 20
  2194. }
  2195. var wrote int64 // updated atomically
  2196. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2197. b := make([]byte, bufLen)
  2198. for wrote < total {
  2199. n, err := w.Write(b)
  2200. atomic.AddInt64(&wrote, int64(n))
  2201. if err != nil {
  2202. t.Errorf("ResponseWriter.Write error: %v", err)
  2203. break
  2204. }
  2205. w.(http.Flusher).Flush()
  2206. }
  2207. }, optOnlyServer)
  2208. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2209. defer tr.CloseIdleConnections()
  2210. req, err := http.NewRequest("GET", st.ts.URL, nil)
  2211. if err != nil {
  2212. t.Fatal("NewRequest error:", err)
  2213. }
  2214. resp, err := tr.RoundTrip(req)
  2215. if err != nil {
  2216. t.Fatal("RoundTrip error:", err)
  2217. }
  2218. defer resp.Body.Close()
  2219. var read int64
  2220. b := make([]byte, bufLen)
  2221. for {
  2222. n, err := resp.Body.Read(b)
  2223. if err == io.EOF {
  2224. break
  2225. }
  2226. if err != nil {
  2227. t.Fatal("Read error:", err)
  2228. }
  2229. read += int64(n)
  2230. const max = transportDefaultStreamFlow
  2231. if w := atomic.LoadInt64(&wrote); -max > read-w || read-w > max {
  2232. t.Fatalf("Too much data inflight: server wrote %v bytes but client only received %v", w, read)
  2233. }
  2234. // Let the server get ahead of the client.
  2235. time.Sleep(1 * time.Millisecond)
  2236. }
  2237. }
  2238. // golang.org/issue/14627 -- if the server sends a GOAWAY frame, make
  2239. // the Transport remember it and return it back to users (via
  2240. // RoundTrip or request body reads) if needed (e.g. if the server
  2241. // proceeds to close the TCP connection before the client gets its
  2242. // response)
  2243. func TestTransportUsesGoAwayDebugError_RoundTrip(t *testing.T) {
  2244. testTransportUsesGoAwayDebugError(t, false)
  2245. }
  2246. func TestTransportUsesGoAwayDebugError_Body(t *testing.T) {
  2247. testTransportUsesGoAwayDebugError(t, true)
  2248. }
  2249. func testTransportUsesGoAwayDebugError(t *testing.T, failMidBody bool) {
  2250. ct := newClientTester(t)
  2251. clientDone := make(chan struct{})
  2252. const goAwayErrCode = ErrCodeHTTP11Required // arbitrary
  2253. const goAwayDebugData = "some debug data"
  2254. ct.client = func() error {
  2255. defer close(clientDone)
  2256. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2257. res, err := ct.tr.RoundTrip(req)
  2258. if failMidBody {
  2259. if err != nil {
  2260. return fmt.Errorf("unexpected client RoundTrip error: %v", err)
  2261. }
  2262. _, err = io.Copy(ioutil.Discard, res.Body)
  2263. res.Body.Close()
  2264. }
  2265. want := GoAwayError{
  2266. LastStreamID: 5,
  2267. ErrCode: goAwayErrCode,
  2268. DebugData: goAwayDebugData,
  2269. }
  2270. if !reflect.DeepEqual(err, want) {
  2271. t.Errorf("RoundTrip error = %T: %#v, want %T (%#v)", err, err, want, want)
  2272. }
  2273. return nil
  2274. }
  2275. ct.server = func() error {
  2276. ct.greet()
  2277. for {
  2278. f, err := ct.fr.ReadFrame()
  2279. if err != nil {
  2280. t.Logf("ReadFrame: %v", err)
  2281. return nil
  2282. }
  2283. hf, ok := f.(*HeadersFrame)
  2284. if !ok {
  2285. continue
  2286. }
  2287. if failMidBody {
  2288. var buf bytes.Buffer
  2289. enc := hpack.NewEncoder(&buf)
  2290. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2291. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "123"})
  2292. ct.fr.WriteHeaders(HeadersFrameParam{
  2293. StreamID: hf.StreamID,
  2294. EndHeaders: true,
  2295. EndStream: false,
  2296. BlockFragment: buf.Bytes(),
  2297. })
  2298. }
  2299. // Write two GOAWAY frames, to test that the Transport takes
  2300. // the interesting parts of both.
  2301. ct.fr.WriteGoAway(5, ErrCodeNo, []byte(goAwayDebugData))
  2302. ct.fr.WriteGoAway(5, goAwayErrCode, nil)
  2303. ct.sc.(*net.TCPConn).CloseWrite()
  2304. <-clientDone
  2305. return nil
  2306. }
  2307. }
  2308. ct.run()
  2309. }
  2310. func testTransportReturnsUnusedFlowControl(t *testing.T, oneDataFrame bool) {
  2311. ct := newClientTester(t)
  2312. clientClosed := make(chan struct{})
  2313. serverWroteFirstByte := make(chan struct{})
  2314. ct.client = func() error {
  2315. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2316. res, err := ct.tr.RoundTrip(req)
  2317. if err != nil {
  2318. return err
  2319. }
  2320. <-serverWroteFirstByte
  2321. if n, err := res.Body.Read(make([]byte, 1)); err != nil || n != 1 {
  2322. return fmt.Errorf("body read = %v, %v; want 1, nil", n, err)
  2323. }
  2324. res.Body.Close() // leaving 4999 bytes unread
  2325. close(clientClosed)
  2326. return nil
  2327. }
  2328. ct.server = func() error {
  2329. ct.greet()
  2330. var hf *HeadersFrame
  2331. for {
  2332. f, err := ct.fr.ReadFrame()
  2333. if err != nil {
  2334. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  2335. }
  2336. switch f.(type) {
  2337. case *WindowUpdateFrame, *SettingsFrame:
  2338. continue
  2339. }
  2340. var ok bool
  2341. hf, ok = f.(*HeadersFrame)
  2342. if !ok {
  2343. return fmt.Errorf("Got %T; want HeadersFrame", f)
  2344. }
  2345. break
  2346. }
  2347. var buf bytes.Buffer
  2348. enc := hpack.NewEncoder(&buf)
  2349. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2350. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "5000"})
  2351. ct.fr.WriteHeaders(HeadersFrameParam{
  2352. StreamID: hf.StreamID,
  2353. EndHeaders: true,
  2354. EndStream: false,
  2355. BlockFragment: buf.Bytes(),
  2356. })
  2357. // Two cases:
  2358. // - Send one DATA frame with 5000 bytes.
  2359. // - Send two DATA frames with 1 and 4999 bytes each.
  2360. //
  2361. // In both cases, the client should consume one byte of data,
  2362. // refund that byte, then refund the following 4999 bytes.
  2363. //
  2364. // In the second case, the server waits for the client connection to
  2365. // close before seconding the second DATA frame. This tests the case
  2366. // where the client receives a DATA frame after it has reset the stream.
  2367. if oneDataFrame {
  2368. ct.fr.WriteData(hf.StreamID, false /* don't end stream */, make([]byte, 5000))
  2369. close(serverWroteFirstByte)
  2370. <-clientClosed
  2371. } else {
  2372. ct.fr.WriteData(hf.StreamID, false /* don't end stream */, make([]byte, 1))
  2373. close(serverWroteFirstByte)
  2374. <-clientClosed
  2375. ct.fr.WriteData(hf.StreamID, false /* don't end stream */, make([]byte, 4999))
  2376. }
  2377. waitingFor := "RSTStreamFrame"
  2378. for {
  2379. f, err := ct.fr.ReadFrame()
  2380. if err != nil {
  2381. return fmt.Errorf("ReadFrame while waiting for %s: %v", waitingFor, err)
  2382. }
  2383. if _, ok := f.(*SettingsFrame); ok {
  2384. continue
  2385. }
  2386. switch waitingFor {
  2387. case "RSTStreamFrame":
  2388. if rf, ok := f.(*RSTStreamFrame); !ok || rf.ErrCode != ErrCodeCancel {
  2389. return fmt.Errorf("Expected a RSTStreamFrame with code cancel; got %v", summarizeFrame(f))
  2390. }
  2391. waitingFor = "WindowUpdateFrame"
  2392. case "WindowUpdateFrame":
  2393. if wuf, ok := f.(*WindowUpdateFrame); !ok || wuf.Increment != 4999 {
  2394. return fmt.Errorf("Expected WindowUpdateFrame for 4999 bytes; got %v", summarizeFrame(f))
  2395. }
  2396. return nil
  2397. }
  2398. }
  2399. }
  2400. ct.run()
  2401. }
  2402. // See golang.org/issue/16481
  2403. func TestTransportReturnsUnusedFlowControlSingleWrite(t *testing.T) {
  2404. testTransportReturnsUnusedFlowControl(t, true)
  2405. }
  2406. // See golang.org/issue/20469
  2407. func TestTransportReturnsUnusedFlowControlMultipleWrites(t *testing.T) {
  2408. testTransportReturnsUnusedFlowControl(t, false)
  2409. }
  2410. // Issue 16612: adjust flow control on open streams when transport
  2411. // receives SETTINGS with INITIAL_WINDOW_SIZE from server.
  2412. func TestTransportAdjustsFlowControl(t *testing.T) {
  2413. ct := newClientTester(t)
  2414. clientDone := make(chan struct{})
  2415. const bodySize = 1 << 20
  2416. ct.client = func() error {
  2417. defer ct.cc.(*net.TCPConn).CloseWrite()
  2418. defer close(clientDone)
  2419. req, _ := http.NewRequest("POST", "https://dummy.tld/", struct{ io.Reader }{io.LimitReader(neverEnding('A'), bodySize)})
  2420. res, err := ct.tr.RoundTrip(req)
  2421. if err != nil {
  2422. return err
  2423. }
  2424. res.Body.Close()
  2425. return nil
  2426. }
  2427. ct.server = func() error {
  2428. _, err := io.ReadFull(ct.sc, make([]byte, len(ClientPreface)))
  2429. if err != nil {
  2430. return fmt.Errorf("reading client preface: %v", err)
  2431. }
  2432. var gotBytes int64
  2433. var sentSettings bool
  2434. for {
  2435. f, err := ct.fr.ReadFrame()
  2436. if err != nil {
  2437. select {
  2438. case <-clientDone:
  2439. return nil
  2440. default:
  2441. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  2442. }
  2443. }
  2444. switch f := f.(type) {
  2445. case *DataFrame:
  2446. gotBytes += int64(len(f.Data()))
  2447. // After we've got half the client's
  2448. // initial flow control window's worth
  2449. // of request body data, give it just
  2450. // enough flow control to finish.
  2451. if gotBytes >= initialWindowSize/2 && !sentSettings {
  2452. sentSettings = true
  2453. ct.fr.WriteSettings(Setting{ID: SettingInitialWindowSize, Val: bodySize})
  2454. ct.fr.WriteWindowUpdate(0, bodySize)
  2455. ct.fr.WriteSettingsAck()
  2456. }
  2457. if f.StreamEnded() {
  2458. var buf bytes.Buffer
  2459. enc := hpack.NewEncoder(&buf)
  2460. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2461. ct.fr.WriteHeaders(HeadersFrameParam{
  2462. StreamID: f.StreamID,
  2463. EndHeaders: true,
  2464. EndStream: true,
  2465. BlockFragment: buf.Bytes(),
  2466. })
  2467. }
  2468. }
  2469. }
  2470. }
  2471. ct.run()
  2472. }
  2473. // See golang.org/issue/16556
  2474. func TestTransportReturnsDataPaddingFlowControl(t *testing.T) {
  2475. ct := newClientTester(t)
  2476. unblockClient := make(chan bool, 1)
  2477. ct.client = func() error {
  2478. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2479. res, err := ct.tr.RoundTrip(req)
  2480. if err != nil {
  2481. return err
  2482. }
  2483. defer res.Body.Close()
  2484. <-unblockClient
  2485. return nil
  2486. }
  2487. ct.server = func() error {
  2488. ct.greet()
  2489. var hf *HeadersFrame
  2490. for {
  2491. f, err := ct.fr.ReadFrame()
  2492. if err != nil {
  2493. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  2494. }
  2495. switch f.(type) {
  2496. case *WindowUpdateFrame, *SettingsFrame:
  2497. continue
  2498. }
  2499. var ok bool
  2500. hf, ok = f.(*HeadersFrame)
  2501. if !ok {
  2502. return fmt.Errorf("Got %T; want HeadersFrame", f)
  2503. }
  2504. break
  2505. }
  2506. var buf bytes.Buffer
  2507. enc := hpack.NewEncoder(&buf)
  2508. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2509. enc.WriteField(hpack.HeaderField{Name: "content-length", Value: "5000"})
  2510. ct.fr.WriteHeaders(HeadersFrameParam{
  2511. StreamID: hf.StreamID,
  2512. EndHeaders: true,
  2513. EndStream: false,
  2514. BlockFragment: buf.Bytes(),
  2515. })
  2516. pad := make([]byte, 5)
  2517. ct.fr.WriteDataPadded(hf.StreamID, false, make([]byte, 5000), pad) // without ending stream
  2518. f, err := ct.readNonSettingsFrame()
  2519. if err != nil {
  2520. return fmt.Errorf("ReadFrame while waiting for first WindowUpdateFrame: %v", err)
  2521. }
  2522. wantBack := uint32(len(pad)) + 1 // one byte for the length of the padding
  2523. if wuf, ok := f.(*WindowUpdateFrame); !ok || wuf.Increment != wantBack || wuf.StreamID != 0 {
  2524. return fmt.Errorf("Expected conn WindowUpdateFrame for %d bytes; got %v", wantBack, summarizeFrame(f))
  2525. }
  2526. f, err = ct.readNonSettingsFrame()
  2527. if err != nil {
  2528. return fmt.Errorf("ReadFrame while waiting for second WindowUpdateFrame: %v", err)
  2529. }
  2530. if wuf, ok := f.(*WindowUpdateFrame); !ok || wuf.Increment != wantBack || wuf.StreamID == 0 {
  2531. return fmt.Errorf("Expected stream WindowUpdateFrame for %d bytes; got %v", wantBack, summarizeFrame(f))
  2532. }
  2533. unblockClient <- true
  2534. return nil
  2535. }
  2536. ct.run()
  2537. }
  2538. // golang.org/issue/16572 -- RoundTrip shouldn't hang when it gets a
  2539. // StreamError as a result of the response HEADERS
  2540. func TestTransportReturnsErrorOnBadResponseHeaders(t *testing.T) {
  2541. ct := newClientTester(t)
  2542. ct.client = func() error {
  2543. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2544. res, err := ct.tr.RoundTrip(req)
  2545. if err == nil {
  2546. res.Body.Close()
  2547. return errors.New("unexpected successful GET")
  2548. }
  2549. want := StreamError{1, ErrCodeProtocol, headerFieldNameError(" content-type")}
  2550. if !reflect.DeepEqual(want, err) {
  2551. t.Errorf("RoundTrip error = %#v; want %#v", err, want)
  2552. }
  2553. return nil
  2554. }
  2555. ct.server = func() error {
  2556. ct.greet()
  2557. hf, err := ct.firstHeaders()
  2558. if err != nil {
  2559. return err
  2560. }
  2561. var buf bytes.Buffer
  2562. enc := hpack.NewEncoder(&buf)
  2563. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2564. enc.WriteField(hpack.HeaderField{Name: " content-type", Value: "bogus"}) // bogus spaces
  2565. ct.fr.WriteHeaders(HeadersFrameParam{
  2566. StreamID: hf.StreamID,
  2567. EndHeaders: true,
  2568. EndStream: false,
  2569. BlockFragment: buf.Bytes(),
  2570. })
  2571. for {
  2572. fr, err := ct.readFrame()
  2573. if err != nil {
  2574. return fmt.Errorf("error waiting for RST_STREAM from client: %v", err)
  2575. }
  2576. if _, ok := fr.(*SettingsFrame); ok {
  2577. continue
  2578. }
  2579. if rst, ok := fr.(*RSTStreamFrame); !ok || rst.StreamID != 1 || rst.ErrCode != ErrCodeProtocol {
  2580. t.Errorf("Frame = %v; want RST_STREAM for stream 1 with ErrCodeProtocol", summarizeFrame(fr))
  2581. }
  2582. break
  2583. }
  2584. return nil
  2585. }
  2586. ct.run()
  2587. }
  2588. // byteAndEOFReader returns is in an io.Reader which reads one byte
  2589. // (the underlying byte) and io.EOF at once in its Read call.
  2590. type byteAndEOFReader byte
  2591. func (b byteAndEOFReader) Read(p []byte) (n int, err error) {
  2592. if len(p) == 0 {
  2593. panic("unexpected useless call")
  2594. }
  2595. p[0] = byte(b)
  2596. return 1, io.EOF
  2597. }
  2598. // Issue 16788: the Transport had a regression where it started
  2599. // sending a spurious DATA frame with a duplicate END_STREAM bit after
  2600. // the request body writer goroutine had already read an EOF from the
  2601. // Request.Body and included the END_STREAM on a data-carrying DATA
  2602. // frame.
  2603. //
  2604. // Notably, to trigger this, the requests need to use a Request.Body
  2605. // which returns (non-0, io.EOF) and also needs to set the ContentLength
  2606. // explicitly.
  2607. func TestTransportBodyDoubleEndStream(t *testing.T) {
  2608. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2609. // Nothing.
  2610. }, optOnlyServer)
  2611. defer st.Close()
  2612. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2613. defer tr.CloseIdleConnections()
  2614. for i := 0; i < 2; i++ {
  2615. req, _ := http.NewRequest("POST", st.ts.URL, byteAndEOFReader('a'))
  2616. req.ContentLength = 1
  2617. res, err := tr.RoundTrip(req)
  2618. if err != nil {
  2619. t.Fatalf("failure on req %d: %v", i+1, err)
  2620. }
  2621. defer res.Body.Close()
  2622. }
  2623. }
  2624. // golang.org/issue/16847, golang.org/issue/19103
  2625. func TestTransportRequestPathPseudo(t *testing.T) {
  2626. type result struct {
  2627. path string
  2628. err string
  2629. }
  2630. tests := []struct {
  2631. req *http.Request
  2632. want result
  2633. }{
  2634. 0: {
  2635. req: &http.Request{
  2636. Method: "GET",
  2637. URL: &url.URL{
  2638. Host: "foo.com",
  2639. Path: "/foo",
  2640. },
  2641. },
  2642. want: result{path: "/foo"},
  2643. },
  2644. // In Go 1.7, we accepted paths of "//foo".
  2645. // In Go 1.8, we rejected it (issue 16847).
  2646. // In Go 1.9, we accepted it again (issue 19103).
  2647. 1: {
  2648. req: &http.Request{
  2649. Method: "GET",
  2650. URL: &url.URL{
  2651. Host: "foo.com",
  2652. Path: "//foo",
  2653. },
  2654. },
  2655. want: result{path: "//foo"},
  2656. },
  2657. // Opaque with //$Matching_Hostname/path
  2658. 2: {
  2659. req: &http.Request{
  2660. Method: "GET",
  2661. URL: &url.URL{
  2662. Scheme: "https",
  2663. Opaque: "//foo.com/path",
  2664. Host: "foo.com",
  2665. Path: "/ignored",
  2666. },
  2667. },
  2668. want: result{path: "/path"},
  2669. },
  2670. // Opaque with some other Request.Host instead:
  2671. 3: {
  2672. req: &http.Request{
  2673. Method: "GET",
  2674. Host: "bar.com",
  2675. URL: &url.URL{
  2676. Scheme: "https",
  2677. Opaque: "//bar.com/path",
  2678. Host: "foo.com",
  2679. Path: "/ignored",
  2680. },
  2681. },
  2682. want: result{path: "/path"},
  2683. },
  2684. // Opaque without the leading "//":
  2685. 4: {
  2686. req: &http.Request{
  2687. Method: "GET",
  2688. URL: &url.URL{
  2689. Opaque: "/path",
  2690. Host: "foo.com",
  2691. Path: "/ignored",
  2692. },
  2693. },
  2694. want: result{path: "/path"},
  2695. },
  2696. // Opaque we can't handle:
  2697. 5: {
  2698. req: &http.Request{
  2699. Method: "GET",
  2700. URL: &url.URL{
  2701. Scheme: "https",
  2702. Opaque: "//unknown_host/path",
  2703. Host: "foo.com",
  2704. Path: "/ignored",
  2705. },
  2706. },
  2707. want: result{err: `invalid request :path "https://unknown_host/path" from URL.Opaque = "//unknown_host/path"`},
  2708. },
  2709. // A CONNECT request:
  2710. 6: {
  2711. req: &http.Request{
  2712. Method: "CONNECT",
  2713. URL: &url.URL{
  2714. Host: "foo.com",
  2715. },
  2716. },
  2717. want: result{},
  2718. },
  2719. }
  2720. for i, tt := range tests {
  2721. cc := &ClientConn{peerMaxHeaderListSize: 0xffffffffffffffff}
  2722. cc.henc = hpack.NewEncoder(&cc.hbuf)
  2723. cc.mu.Lock()
  2724. hdrs, err := cc.encodeHeaders(tt.req, false, "", -1)
  2725. cc.mu.Unlock()
  2726. var got result
  2727. hpackDec := hpack.NewDecoder(initialHeaderTableSize, func(f hpack.HeaderField) {
  2728. if f.Name == ":path" {
  2729. got.path = f.Value
  2730. }
  2731. })
  2732. if err != nil {
  2733. got.err = err.Error()
  2734. } else if len(hdrs) > 0 {
  2735. if _, err := hpackDec.Write(hdrs); err != nil {
  2736. t.Errorf("%d. bogus hpack: %v", i, err)
  2737. continue
  2738. }
  2739. }
  2740. if got != tt.want {
  2741. t.Errorf("%d. got %+v; want %+v", i, got, tt.want)
  2742. }
  2743. }
  2744. }
  2745. // golang.org/issue/17071 -- don't sniff the first byte of the request body
  2746. // before we've determined that the ClientConn is usable.
  2747. func TestRoundTripDoesntConsumeRequestBodyEarly(t *testing.T) {
  2748. const body = "foo"
  2749. req, _ := http.NewRequest("POST", "http://foo.com/", ioutil.NopCloser(strings.NewReader(body)))
  2750. cc := &ClientConn{
  2751. closed: true,
  2752. }
  2753. _, err := cc.RoundTrip(req)
  2754. if err != errClientConnUnusable {
  2755. t.Fatalf("RoundTrip = %v; want errClientConnUnusable", err)
  2756. }
  2757. slurp, err := ioutil.ReadAll(req.Body)
  2758. if err != nil {
  2759. t.Errorf("ReadAll = %v", err)
  2760. }
  2761. if string(slurp) != body {
  2762. t.Errorf("Body = %q; want %q", slurp, body)
  2763. }
  2764. }
  2765. func TestClientConnPing(t *testing.T) {
  2766. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {}, optOnlyServer)
  2767. defer st.Close()
  2768. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2769. defer tr.CloseIdleConnections()
  2770. cc, err := tr.dialClientConn(st.ts.Listener.Addr().String(), false)
  2771. if err != nil {
  2772. t.Fatal(err)
  2773. }
  2774. if err = cc.Ping(testContext{}); err != nil {
  2775. t.Fatal(err)
  2776. }
  2777. }
  2778. // Issue 16974: if the server sent a DATA frame after the user
  2779. // canceled the Transport's Request, the Transport previously wrote to a
  2780. // closed pipe, got an error, and ended up closing the whole TCP
  2781. // connection.
  2782. func TestTransportCancelDataResponseRace(t *testing.T) {
  2783. cancel := make(chan struct{})
  2784. clientGotError := make(chan bool, 1)
  2785. const msg = "Hello."
  2786. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2787. if strings.Contains(r.URL.Path, "/hello") {
  2788. time.Sleep(50 * time.Millisecond)
  2789. io.WriteString(w, msg)
  2790. return
  2791. }
  2792. for i := 0; i < 50; i++ {
  2793. io.WriteString(w, "Some data.")
  2794. w.(http.Flusher).Flush()
  2795. if i == 2 {
  2796. close(cancel)
  2797. <-clientGotError
  2798. }
  2799. time.Sleep(10 * time.Millisecond)
  2800. }
  2801. }, optOnlyServer)
  2802. defer st.Close()
  2803. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  2804. defer tr.CloseIdleConnections()
  2805. c := &http.Client{Transport: tr}
  2806. req, _ := http.NewRequest("GET", st.ts.URL, nil)
  2807. req.Cancel = cancel
  2808. res, err := c.Do(req)
  2809. if err != nil {
  2810. t.Fatal(err)
  2811. }
  2812. if _, err = io.Copy(ioutil.Discard, res.Body); err == nil {
  2813. t.Fatal("unexpected success")
  2814. }
  2815. clientGotError <- true
  2816. res, err = c.Get(st.ts.URL + "/hello")
  2817. if err != nil {
  2818. t.Fatal(err)
  2819. }
  2820. slurp, err := ioutil.ReadAll(res.Body)
  2821. if err != nil {
  2822. t.Fatal(err)
  2823. }
  2824. if string(slurp) != msg {
  2825. t.Errorf("Got = %q; want %q", slurp, msg)
  2826. }
  2827. }
  2828. func TestTransportRetryAfterGOAWAY(t *testing.T) {
  2829. var dialer struct {
  2830. sync.Mutex
  2831. count int
  2832. }
  2833. ct1 := make(chan *clientTester)
  2834. ct2 := make(chan *clientTester)
  2835. ln := newLocalListener(t)
  2836. defer ln.Close()
  2837. tr := &Transport{
  2838. TLSClientConfig: tlsConfigInsecure,
  2839. }
  2840. tr.DialTLS = func(network, addr string, cfg *tls.Config) (net.Conn, error) {
  2841. dialer.Lock()
  2842. defer dialer.Unlock()
  2843. dialer.count++
  2844. if dialer.count == 3 {
  2845. return nil, errors.New("unexpected number of dials")
  2846. }
  2847. cc, err := net.Dial("tcp", ln.Addr().String())
  2848. if err != nil {
  2849. return nil, fmt.Errorf("dial error: %v", err)
  2850. }
  2851. sc, err := ln.Accept()
  2852. if err != nil {
  2853. return nil, fmt.Errorf("accept error: %v", err)
  2854. }
  2855. ct := &clientTester{
  2856. t: t,
  2857. tr: tr,
  2858. cc: cc,
  2859. sc: sc,
  2860. fr: NewFramer(sc, sc),
  2861. }
  2862. switch dialer.count {
  2863. case 1:
  2864. ct1 <- ct
  2865. case 2:
  2866. ct2 <- ct
  2867. }
  2868. return cc, nil
  2869. }
  2870. errs := make(chan error, 3)
  2871. done := make(chan struct{})
  2872. defer close(done)
  2873. // Client.
  2874. go func() {
  2875. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2876. res, err := tr.RoundTrip(req)
  2877. if res != nil {
  2878. res.Body.Close()
  2879. if got := res.Header.Get("Foo"); got != "bar" {
  2880. err = fmt.Errorf("foo header = %q; want bar", got)
  2881. }
  2882. }
  2883. if err != nil {
  2884. err = fmt.Errorf("RoundTrip: %v", err)
  2885. }
  2886. errs <- err
  2887. }()
  2888. connToClose := make(chan io.Closer, 2)
  2889. // Server for the first request.
  2890. go func() {
  2891. var ct *clientTester
  2892. select {
  2893. case ct = <-ct1:
  2894. case <-done:
  2895. return
  2896. }
  2897. connToClose <- ct.cc
  2898. ct.greet()
  2899. hf, err := ct.firstHeaders()
  2900. if err != nil {
  2901. errs <- fmt.Errorf("server1 failed reading HEADERS: %v", err)
  2902. return
  2903. }
  2904. t.Logf("server1 got %v", hf)
  2905. if err := ct.fr.WriteGoAway(0 /*max id*/, ErrCodeNo, nil); err != nil {
  2906. errs <- fmt.Errorf("server1 failed writing GOAWAY: %v", err)
  2907. return
  2908. }
  2909. errs <- nil
  2910. }()
  2911. // Server for the second request.
  2912. go func() {
  2913. var ct *clientTester
  2914. select {
  2915. case ct = <-ct2:
  2916. case <-done:
  2917. return
  2918. }
  2919. connToClose <- ct.cc
  2920. ct.greet()
  2921. hf, err := ct.firstHeaders()
  2922. if err != nil {
  2923. errs <- fmt.Errorf("server2 failed reading HEADERS: %v", err)
  2924. return
  2925. }
  2926. t.Logf("server2 got %v", hf)
  2927. var buf bytes.Buffer
  2928. enc := hpack.NewEncoder(&buf)
  2929. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  2930. enc.WriteField(hpack.HeaderField{Name: "foo", Value: "bar"})
  2931. err = ct.fr.WriteHeaders(HeadersFrameParam{
  2932. StreamID: hf.StreamID,
  2933. EndHeaders: true,
  2934. EndStream: false,
  2935. BlockFragment: buf.Bytes(),
  2936. })
  2937. if err != nil {
  2938. errs <- fmt.Errorf("server2 failed writing response HEADERS: %v", err)
  2939. } else {
  2940. errs <- nil
  2941. }
  2942. }()
  2943. for k := 0; k < 3; k++ {
  2944. select {
  2945. case err := <-errs:
  2946. if err != nil {
  2947. t.Error(err)
  2948. }
  2949. case <-time.After(1 * time.Second):
  2950. t.Errorf("timed out")
  2951. }
  2952. }
  2953. for {
  2954. select {
  2955. case c := <-connToClose:
  2956. c.Close()
  2957. default:
  2958. return
  2959. }
  2960. }
  2961. }
  2962. func TestTransportRetryAfterRefusedStream(t *testing.T) {
  2963. clientDone := make(chan struct{})
  2964. ct := newClientTester(t)
  2965. ct.client = func() error {
  2966. defer ct.cc.(*net.TCPConn).CloseWrite()
  2967. defer close(clientDone)
  2968. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  2969. resp, err := ct.tr.RoundTrip(req)
  2970. if err != nil {
  2971. return fmt.Errorf("RoundTrip: %v", err)
  2972. }
  2973. resp.Body.Close()
  2974. if resp.StatusCode != 204 {
  2975. return fmt.Errorf("Status = %v; want 204", resp.StatusCode)
  2976. }
  2977. return nil
  2978. }
  2979. ct.server = func() error {
  2980. ct.greet()
  2981. var buf bytes.Buffer
  2982. enc := hpack.NewEncoder(&buf)
  2983. nreq := 0
  2984. for {
  2985. f, err := ct.fr.ReadFrame()
  2986. if err != nil {
  2987. select {
  2988. case <-clientDone:
  2989. // If the client's done, it
  2990. // will have reported any
  2991. // errors on its side.
  2992. return nil
  2993. default:
  2994. return err
  2995. }
  2996. }
  2997. switch f := f.(type) {
  2998. case *WindowUpdateFrame, *SettingsFrame:
  2999. case *HeadersFrame:
  3000. if !f.HeadersEnded() {
  3001. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  3002. }
  3003. nreq++
  3004. if nreq == 1 {
  3005. ct.fr.WriteRSTStream(f.StreamID, ErrCodeRefusedStream)
  3006. } else {
  3007. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "204"})
  3008. ct.fr.WriteHeaders(HeadersFrameParam{
  3009. StreamID: f.StreamID,
  3010. EndHeaders: true,
  3011. EndStream: true,
  3012. BlockFragment: buf.Bytes(),
  3013. })
  3014. }
  3015. default:
  3016. return fmt.Errorf("Unexpected client frame %v", f)
  3017. }
  3018. }
  3019. }
  3020. ct.run()
  3021. }
  3022. func TestTransportRetryHasLimit(t *testing.T) {
  3023. // Skip in short mode because the total expected delay is 1s+2s+4s+8s+16s=29s.
  3024. if testing.Short() {
  3025. t.Skip("skipping long test in short mode")
  3026. }
  3027. clientDone := make(chan struct{})
  3028. ct := newClientTester(t)
  3029. ct.client = func() error {
  3030. defer ct.cc.(*net.TCPConn).CloseWrite()
  3031. defer close(clientDone)
  3032. req, _ := http.NewRequest("GET", "https://dummy.tld/", nil)
  3033. resp, err := ct.tr.RoundTrip(req)
  3034. if err == nil {
  3035. return fmt.Errorf("RoundTrip expected error, got response: %+v", resp)
  3036. }
  3037. t.Logf("expected error, got: %v", err)
  3038. return nil
  3039. }
  3040. ct.server = func() error {
  3041. ct.greet()
  3042. for {
  3043. f, err := ct.fr.ReadFrame()
  3044. if err != nil {
  3045. select {
  3046. case <-clientDone:
  3047. // If the client's done, it
  3048. // will have reported any
  3049. // errors on its side.
  3050. return nil
  3051. default:
  3052. return err
  3053. }
  3054. }
  3055. switch f := f.(type) {
  3056. case *WindowUpdateFrame, *SettingsFrame:
  3057. case *HeadersFrame:
  3058. if !f.HeadersEnded() {
  3059. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  3060. }
  3061. ct.fr.WriteRSTStream(f.StreamID, ErrCodeRefusedStream)
  3062. default:
  3063. return fmt.Errorf("Unexpected client frame %v", f)
  3064. }
  3065. }
  3066. }
  3067. ct.run()
  3068. }
  3069. func TestTransportResponseDataBeforeHeaders(t *testing.T) {
  3070. ct := newClientTester(t)
  3071. ct.client = func() error {
  3072. defer ct.cc.(*net.TCPConn).CloseWrite()
  3073. req := httptest.NewRequest("GET", "https://dummy.tld/", nil)
  3074. // First request is normal to ensure the check is per stream and not per connection.
  3075. _, err := ct.tr.RoundTrip(req)
  3076. if err != nil {
  3077. return fmt.Errorf("RoundTrip expected no error, got: %v", err)
  3078. }
  3079. // Second request returns a DATA frame with no HEADERS.
  3080. resp, err := ct.tr.RoundTrip(req)
  3081. if err == nil {
  3082. return fmt.Errorf("RoundTrip expected error, got response: %+v", resp)
  3083. }
  3084. if err, ok := err.(StreamError); !ok || err.Code != ErrCodeProtocol {
  3085. return fmt.Errorf("expected stream PROTOCOL_ERROR, got: %v", err)
  3086. }
  3087. return nil
  3088. }
  3089. ct.server = func() error {
  3090. ct.greet()
  3091. for {
  3092. f, err := ct.fr.ReadFrame()
  3093. if err == io.EOF {
  3094. return nil
  3095. } else if err != nil {
  3096. return err
  3097. }
  3098. switch f := f.(type) {
  3099. case *WindowUpdateFrame, *SettingsFrame:
  3100. case *HeadersFrame:
  3101. switch f.StreamID {
  3102. case 1:
  3103. // Send a valid response to first request.
  3104. var buf bytes.Buffer
  3105. enc := hpack.NewEncoder(&buf)
  3106. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "200"})
  3107. ct.fr.WriteHeaders(HeadersFrameParam{
  3108. StreamID: f.StreamID,
  3109. EndHeaders: true,
  3110. EndStream: true,
  3111. BlockFragment: buf.Bytes(),
  3112. })
  3113. case 3:
  3114. ct.fr.WriteData(f.StreamID, true, []byte("payload"))
  3115. }
  3116. default:
  3117. return fmt.Errorf("Unexpected client frame %v", f)
  3118. }
  3119. }
  3120. }
  3121. ct.run()
  3122. }
  3123. func TestTransportRequestsStallAtServerLimit(t *testing.T) {
  3124. const maxConcurrent = 2
  3125. greet := make(chan struct{}) // server sends initial SETTINGS frame
  3126. gotRequest := make(chan struct{}) // server received a request
  3127. clientDone := make(chan struct{})
  3128. // Collect errors from goroutines.
  3129. var wg sync.WaitGroup
  3130. errs := make(chan error, 100)
  3131. defer func() {
  3132. wg.Wait()
  3133. close(errs)
  3134. for err := range errs {
  3135. t.Error(err)
  3136. }
  3137. }()
  3138. // We will send maxConcurrent+2 requests. This checker goroutine waits for the
  3139. // following stages:
  3140. // 1. The first maxConcurrent requests are received by the server.
  3141. // 2. The client will cancel the next request
  3142. // 3. The server is unblocked so it can service the first maxConcurrent requests
  3143. // 4. The client will send the final request
  3144. wg.Add(1)
  3145. unblockClient := make(chan struct{})
  3146. clientRequestCancelled := make(chan struct{})
  3147. unblockServer := make(chan struct{})
  3148. go func() {
  3149. defer wg.Done()
  3150. // Stage 1.
  3151. for k := 0; k < maxConcurrent; k++ {
  3152. <-gotRequest
  3153. }
  3154. // Stage 2.
  3155. close(unblockClient)
  3156. <-clientRequestCancelled
  3157. // Stage 3: give some time for the final RoundTrip call to be scheduled and
  3158. // verify that the final request is not sent.
  3159. time.Sleep(50 * time.Millisecond)
  3160. select {
  3161. case <-gotRequest:
  3162. errs <- errors.New("last request did not stall")
  3163. close(unblockServer)
  3164. return
  3165. default:
  3166. }
  3167. close(unblockServer)
  3168. // Stage 4.
  3169. <-gotRequest
  3170. }()
  3171. ct := newClientTester(t)
  3172. ct.client = func() error {
  3173. var wg sync.WaitGroup
  3174. defer func() {
  3175. wg.Wait()
  3176. close(clientDone)
  3177. ct.cc.(*net.TCPConn).CloseWrite()
  3178. }()
  3179. for k := 0; k < maxConcurrent+2; k++ {
  3180. wg.Add(1)
  3181. go func(k int) {
  3182. defer wg.Done()
  3183. // Don't send the second request until after receiving SETTINGS from the server
  3184. // to avoid a race where we use the default SettingMaxConcurrentStreams, which
  3185. // is much larger than maxConcurrent. We have to send the first request before
  3186. // waiting because the first request triggers the dial and greet.
  3187. if k > 0 {
  3188. <-greet
  3189. }
  3190. // Block until maxConcurrent requests are sent before sending any more.
  3191. if k >= maxConcurrent {
  3192. <-unblockClient
  3193. }
  3194. req, _ := http.NewRequest("GET", fmt.Sprintf("https://dummy.tld/%d", k), nil)
  3195. if k == maxConcurrent {
  3196. // This request will be canceled.
  3197. cancel := make(chan struct{})
  3198. req.Cancel = cancel
  3199. close(cancel)
  3200. _, err := ct.tr.RoundTrip(req)
  3201. close(clientRequestCancelled)
  3202. if err == nil {
  3203. errs <- fmt.Errorf("RoundTrip(%d) should have failed due to cancel", k)
  3204. return
  3205. }
  3206. } else {
  3207. resp, err := ct.tr.RoundTrip(req)
  3208. if err != nil {
  3209. errs <- fmt.Errorf("RoundTrip(%d): %v", k, err)
  3210. return
  3211. }
  3212. ioutil.ReadAll(resp.Body)
  3213. resp.Body.Close()
  3214. if resp.StatusCode != 204 {
  3215. errs <- fmt.Errorf("Status = %v; want 204", resp.StatusCode)
  3216. return
  3217. }
  3218. }
  3219. }(k)
  3220. }
  3221. return nil
  3222. }
  3223. ct.server = func() error {
  3224. var wg sync.WaitGroup
  3225. defer wg.Wait()
  3226. ct.greet(Setting{SettingMaxConcurrentStreams, maxConcurrent})
  3227. // Server write loop.
  3228. var buf bytes.Buffer
  3229. enc := hpack.NewEncoder(&buf)
  3230. writeResp := make(chan uint32, maxConcurrent+1)
  3231. wg.Add(1)
  3232. go func() {
  3233. defer wg.Done()
  3234. <-unblockServer
  3235. for id := range writeResp {
  3236. buf.Reset()
  3237. enc.WriteField(hpack.HeaderField{Name: ":status", Value: "204"})
  3238. ct.fr.WriteHeaders(HeadersFrameParam{
  3239. StreamID: id,
  3240. EndHeaders: true,
  3241. EndStream: true,
  3242. BlockFragment: buf.Bytes(),
  3243. })
  3244. }
  3245. }()
  3246. // Server read loop.
  3247. var nreq int
  3248. for {
  3249. f, err := ct.fr.ReadFrame()
  3250. if err != nil {
  3251. select {
  3252. case <-clientDone:
  3253. // If the client's done, it will have reported any errors on its side.
  3254. return nil
  3255. default:
  3256. return err
  3257. }
  3258. }
  3259. switch f := f.(type) {
  3260. case *WindowUpdateFrame:
  3261. case *SettingsFrame:
  3262. // Wait for the client SETTINGS ack until ending the greet.
  3263. close(greet)
  3264. case *HeadersFrame:
  3265. if !f.HeadersEnded() {
  3266. return fmt.Errorf("headers should have END_HEADERS be ended: %v", f)
  3267. }
  3268. gotRequest <- struct{}{}
  3269. nreq++
  3270. writeResp <- f.StreamID
  3271. if nreq == maxConcurrent+1 {
  3272. close(writeResp)
  3273. }
  3274. default:
  3275. return fmt.Errorf("Unexpected client frame %v", f)
  3276. }
  3277. }
  3278. }
  3279. ct.run()
  3280. }
  3281. func TestAuthorityAddr(t *testing.T) {
  3282. tests := []struct {
  3283. scheme, authority string
  3284. want string
  3285. }{
  3286. {"http", "foo.com", "foo.com:80"},
  3287. {"https", "foo.com", "foo.com:443"},
  3288. {"https", "foo.com:1234", "foo.com:1234"},
  3289. {"https", "1.2.3.4:1234", "1.2.3.4:1234"},
  3290. {"https", "1.2.3.4", "1.2.3.4:443"},
  3291. {"https", "[::1]:1234", "[::1]:1234"},
  3292. {"https", "[::1]", "[::1]:443"},
  3293. }
  3294. for _, tt := range tests {
  3295. got := authorityAddr(tt.scheme, tt.authority)
  3296. if got != tt.want {
  3297. t.Errorf("authorityAddr(%q, %q) = %q; want %q", tt.scheme, tt.authority, got, tt.want)
  3298. }
  3299. }
  3300. }
  3301. // Issue 20448: stop allocating for DATA frames' payload after
  3302. // Response.Body.Close is called.
  3303. func TestTransportAllocationsAfterResponseBodyClose(t *testing.T) {
  3304. megabyteZero := make([]byte, 1<<20)
  3305. writeErr := make(chan error, 1)
  3306. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3307. w.(http.Flusher).Flush()
  3308. var sum int64
  3309. for i := 0; i < 100; i++ {
  3310. n, err := w.Write(megabyteZero)
  3311. sum += int64(n)
  3312. if err != nil {
  3313. writeErr <- err
  3314. return
  3315. }
  3316. }
  3317. t.Logf("wrote all %d bytes", sum)
  3318. writeErr <- nil
  3319. }, optOnlyServer)
  3320. defer st.Close()
  3321. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3322. defer tr.CloseIdleConnections()
  3323. c := &http.Client{Transport: tr}
  3324. res, err := c.Get(st.ts.URL)
  3325. if err != nil {
  3326. t.Fatal(err)
  3327. }
  3328. var buf [1]byte
  3329. if _, err := res.Body.Read(buf[:]); err != nil {
  3330. t.Error(err)
  3331. }
  3332. if err := res.Body.Close(); err != nil {
  3333. t.Error(err)
  3334. }
  3335. trb, ok := res.Body.(transportResponseBody)
  3336. if !ok {
  3337. t.Fatalf("res.Body = %T; want transportResponseBody", res.Body)
  3338. }
  3339. if trb.cs.bufPipe.b != nil {
  3340. t.Errorf("response body pipe is still open")
  3341. }
  3342. gotErr := <-writeErr
  3343. if gotErr == nil {
  3344. t.Errorf("Handler unexpectedly managed to write its entire response without getting an error")
  3345. } else if gotErr != errStreamClosed {
  3346. t.Errorf("Handler Write err = %v; want errStreamClosed", gotErr)
  3347. }
  3348. }
  3349. // Issue 18891: make sure Request.Body == NoBody means no DATA frame
  3350. // is ever sent, even if empty.
  3351. func TestTransportNoBodyMeansNoDATA(t *testing.T) {
  3352. ct := newClientTester(t)
  3353. unblockClient := make(chan bool)
  3354. ct.client = func() error {
  3355. req, _ := http.NewRequest("GET", "https://dummy.tld/", go18httpNoBody())
  3356. ct.tr.RoundTrip(req)
  3357. <-unblockClient
  3358. return nil
  3359. }
  3360. ct.server = func() error {
  3361. defer close(unblockClient)
  3362. defer ct.cc.(*net.TCPConn).Close()
  3363. ct.greet()
  3364. for {
  3365. f, err := ct.fr.ReadFrame()
  3366. if err != nil {
  3367. return fmt.Errorf("ReadFrame while waiting for Headers: %v", err)
  3368. }
  3369. switch f := f.(type) {
  3370. default:
  3371. return fmt.Errorf("Got %T; want HeadersFrame", f)
  3372. case *WindowUpdateFrame, *SettingsFrame:
  3373. continue
  3374. case *HeadersFrame:
  3375. if !f.StreamEnded() {
  3376. return fmt.Errorf("got headers frame without END_STREAM")
  3377. }
  3378. return nil
  3379. }
  3380. }
  3381. }
  3382. ct.run()
  3383. }
  3384. func benchSimpleRoundTrip(b *testing.B, nHeaders int) {
  3385. defer disableGoroutineTracking()()
  3386. b.ReportAllocs()
  3387. st := newServerTester(b,
  3388. func(w http.ResponseWriter, r *http.Request) {
  3389. },
  3390. optOnlyServer,
  3391. optQuiet,
  3392. )
  3393. defer st.Close()
  3394. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3395. defer tr.CloseIdleConnections()
  3396. req, err := http.NewRequest("GET", st.ts.URL, nil)
  3397. if err != nil {
  3398. b.Fatal(err)
  3399. }
  3400. for i := 0; i < nHeaders; i++ {
  3401. name := fmt.Sprint("A-", i)
  3402. req.Header.Set(name, "*")
  3403. }
  3404. b.ResetTimer()
  3405. for i := 0; i < b.N; i++ {
  3406. res, err := tr.RoundTrip(req)
  3407. if err != nil {
  3408. if res != nil {
  3409. res.Body.Close()
  3410. }
  3411. b.Fatalf("RoundTrip err = %v; want nil", err)
  3412. }
  3413. res.Body.Close()
  3414. if res.StatusCode != http.StatusOK {
  3415. b.Fatalf("Response code = %v; want %v", res.StatusCode, http.StatusOK)
  3416. }
  3417. }
  3418. }
  3419. func BenchmarkClientRequestHeaders(b *testing.B) {
  3420. b.Run(" 0 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 0) })
  3421. b.Run(" 10 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 10) })
  3422. b.Run(" 100 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 100) })
  3423. b.Run("1000 Headers", func(b *testing.B) { benchSimpleRoundTrip(b, 1000) })
  3424. }