Home Explore Help
Register Sign In
lqb
/
java-wkhtmltopdf-wrapper
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

Creating temporary files for htmlAsString inputs #8

Jhonny Mertz 9 years ago
parent
2e24238721
commit
5412a04628
2 changed files with 30 additions and 15 deletions
Split View Show Diff Stats
  1. 11 13
      src/main/java/br/eti/mertz/wkhtmltopdf/wrapper/Pdf.java
  2. 19 2
      src/tests/java/br/eti/mertz/wkhtmltopdf/wrapper/PdfTest.java

+ 11 - 13
src/main/java/br/eti/mertz/wkhtmltopdf/wrapper/Pdf.java
View File 

@@ -5,11 +5,13 @@ import br.eti.mertz.wkhtmltopdf.wrapper.page.Page;
 
 import br.eti.mertz.wkhtmltopdf.wrapper.page.PageType;
 
 import br.eti.mertz.wkhtmltopdf.wrapper.params.Param;
 
 import br.eti.mertz.wkhtmltopdf.wrapper.params.Params;
 
+import org.apache.commons.io.FileUtils;
 
 import org.apache.commons.lang3.StringUtils;
 
 
 import java.io.*;
 
 import java.util.ArrayList;
 
 import java.util.List;
 
+import java.util.UUID;
 
 
 public class Pdf implements PdfService {
 
 
@@ -70,14 +72,6 @@ public class Pdf implements PdfService {
 
         Runtime runtime = Runtime.getRuntime();
 
         Process process = runtime.exec(getCommandAsArray());
 
 
-        for (Page page : pages) {
 
-            if (page.getType().equals(PageType.htmlAsString)) {
 
-                OutputStream stdInStream = process.getOutputStream();
 
-                stdInStream.write(page.getSource().getBytes("UTF-8"));
 
-                stdInStream.close();
 
-            }
 
-        }
 
-
 
         StreamEater outputStreamEater = new StreamEater(process.getInputStream());
 
         outputStreamEater.start();
 
 
@@ -103,7 +97,7 @@ public class Pdf implements PdfService {
 
         return outputStreamEater.getBytes();
 
     }
 
 
-    private String[] getCommandAsArray() {
 
+    private String[] getCommandAsArray() throws IOException {
 
         List<String> commandLine = new ArrayList<String>();
 
 
         if (wrapperConfig.isXvfbEnabled())
 
@@ -118,16 +112,20 @@ public class Pdf implements PdfService {
 
 
         for (Page page : pages) {
 
             if (page.getType().equals(PageType.htmlAsString)) {
 
-                commandLine.add(STDINOUT);
 
-            } else {
 
-                commandLine.add(page.getSource());
 
+
 
+                File temp = File.createTempFile("java-wkhtmltopdf-wrapper" + UUID.randomUUID().toString(), ".html");
 
+                FileUtils.writeStringToFile(temp, page.getSource(), "UTF-8");
 
+
 
+                page.setSource(temp.getAbsolutePath());
 
             }
 
+
 
+            commandLine.add(page.getSource());
 
         }
 
         commandLine.add(STDINOUT);
 
         return commandLine.toArray(new String[commandLine.size()]);
 
     }
 
 
-    public String getCommand() {
 
+    public String getCommand() throws IOException {
 
         return StringUtils.join(getCommandAsArray(), " ");
 
     }

+ 19 - 2
src/tests/java/br/eti/mertz/wkhtmltopdf/wrapper/PdfTest.java
View File 

@@ -37,8 +37,6 @@ public class PdfTest {
 
         Pdf pdf = new Pdf();
 
         pdf.addPage("<html><head><meta charset=\"utf-8\"></head><h1>Müller</h1></html>", PageType.htmlAsString);
 
 
-        pdf.saveAs("output.pdf");
 
-
 
         // WHEN
 
         byte[] pdfBytes = pdf.getPDF();
 
 
@@ -50,7 +48,26 @@ public class PdfTest {
 
         String pdfText = pdfTextStripper.getText(new PDDocument(parser.getDocument()));
 
 
         Assert.assertThat("document should contain the creditorName", pdfText, containsString("Müller"));
 
+    }
 
+
 
+    @Test
 
+    public void testMultiplePages() throws Exception {
 
+        Pdf pdf = new Pdf();
 
+        pdf.addPage("<html><head><meta charset=\"utf-8\"></head><h1>Page 1</h1></html>", PageType.htmlAsString);
 
+        pdf.addPage("<html><head><meta charset=\"utf-8\"></head><h1>Page 2</h1></html>", PageType.htmlAsString);
 
+        pdf.addPage("http://www.google.com", PageType.url);
 
+        pdf.addPage("<html><head><meta charset=\"utf-8\"></head><h1>Page 4</h1></html>", PageType.htmlAsString);
 
 
+        // WHEN
 
+        byte[] pdfBytes = pdf.getPDF();
 
+
 
+        PDFParser parser = new PDFParser(new ByteArrayInputStream(pdfBytes));
 
+
 
+        // that is a valid PDF (otherwise an IOException occurs)
 
+        parser.parse();
 
+        PDFTextStripper pdfTextStripper = new PDFTextStripper();
 
+        String pdfText = pdfTextStripper.getText(new PDDocument(parser.getDocument()));
 
 
+        Assert.assertThat("document should contain the fourth page name", pdfText, containsString("Page 4"));
 
     }
 
 }