Browse Source

make background transparent by default for headers/footers

This was already done for the main webpage in #2084, but was not
implemented for headers and footers. fixes #2416
Ashish Kulkarni 9 years ago
parent
commit
325095448b
2 changed files with 9 additions and 0 deletions
  1. 3 0
      CHANGELOG.md
  2. 6 0
      src/lib/pdfconverter.cc

+ 3 - 0
CHANGELOG.md

@@ -1,6 +1,9 @@
 v0.12.4 (unreleased)
 --------------------
 * update OpenSSL to 1.0.2g
+* **#2416**: make background transparent by default for headers/footers
+* **#2885**: enforce UTF-8 encoding for input strings in the API
+* **#2887**: improve docs to make examples of header/footer variables more explicit
 
 v0.12.3 (2016-01-20)
 --------------------

+ 6 - 0
src/lib/pdfconverter.cc

@@ -651,6 +651,9 @@ void PdfConverterPrivate::endPage(PageObject & object, bool hasHeaderFooter, int
 		updateWebSettings(header->settings(), object.settings.web);
 		painter->save();
 		painter->resetTransform();
+		QPalette pal = header->palette();
+		pal.setBrush(QPalette::Base, Qt::transparent);
+		header->setPalette(pal);
 		double spacing = s.header.spacing * printer->height() / printer->heightMM();
         // clear vertical margins for proper header rendering
         printer->setPageMargins(leftMargin, 0, rightMargin, 0, settings.margin.left.second);
@@ -680,6 +683,9 @@ void PdfConverterPrivate::endPage(PageObject & object, bool hasHeaderFooter, int
 		updateWebSettings(footer->settings(), object.settings.web);
 		painter->save();
 		painter->resetTransform();
+		QPalette pal = footer->palette();
+		pal.setBrush(QPalette::Base, Qt::transparent);
+		footer->setPalette(pal);
 		double spacing = s.footer.spacing * printer->height() / printer->heightMM();
 		painter->translate(0, printer->height()+ spacing);
         // clear vertical margins for proper header rendering