Browse Source

fix wrong comparison when parsing list parameters

Fixes #1906
Ashish Kulkarni 11 years ago
parent
commit
b8aa754a66
2 changed files with 2 additions and 1 deletions
  1. 1 0
      CHANGELOG.md
  2. 1 1
      src/lib/reflect.hh

+ 1 - 0
CHANGELOG.md

@@ -11,6 +11,7 @@ v0.12.2 (unreleased)
 * **#1772**: added variable 'isodate' for substitution in headers/footers
 * **#1808**: fix [sitepage] and [sitepages] not working without HTML headers/footers
 * **#1825**: fix handling of non-ASCII characters in command-line arguments
+* **#1906**: fix wrong comparison when parsing list parameters
 * **#1949**: fix generation of tarball in the posix-local build
 * **#1955**: installer does not work on 32-bit OS X (10.6.x or 10.7.x)
 * **#1961**: add explicit dependency on minimal font packages for all linux targets

+ 1 - 1
src/lib/reflect.hh

@@ -229,7 +229,7 @@ struct DLL_LOCAL ReflectImpl< QList< X> >: public Reflect {
 			return ok;
 		}
 		parmsize = 0;
-		while (name[parmsize] != '\0' || name[parmsize] != '.' || name[parmsize] != '[') ++parmsize;
+		while (name[parmsize] != '\0' && name[parmsize] != '.' && name[parmsize] != '[') ++parmsize;
 		next = parmsize;
 		if (name[next] == '.') ++next;
 		return true;