Browse Source

Add delete entities test

tumao 3 years ago
parent
commit
77fe9ba4d2

+ 11 - 0
express/src/__tests__/__mocks__/milvus/milvusClient.ts

@@ -24,6 +24,7 @@ import {
   ShowCollectionsReq,
   ShowCollectionsReq,
   ShowPartitionsReq,
   ShowPartitionsReq,
 } from '@zilliz/milvus2-sdk-node/dist/milvus/types';
 } from '@zilliz/milvus2-sdk-node/dist/milvus/types';
+import { DeleteEntitiesReq } from '@zilliz/milvus2-sdk-node/dist/milvus/types/Data';
 import { QueryDto } from '../../../collections/dto';
 import { QueryDto } from '../../../collections/dto';
 import {
 import {
   CodeEnum,
   CodeEnum,
@@ -335,6 +336,16 @@ const mockMilvusClient = jest.fn().mockImplementation((address: string) => {
           data: param,
           data: param,
         };
         };
       },
       },
+      deleteEntities: (param: DeleteEntitiesReq) => {
+        const { collection_name } = param;
+        if (!collection_name) {
+          return { status: mockStatusInfo(CodeEnum.error, ERR_NO_COLLECTION) };
+        }
+        return {
+          status: mockStatusInfo(CodeEnum.success),
+          data: param,
+        };
+      },
     },
     },
   };
   };
 });
 });

+ 16 - 0
express/src/__tests__/collections/collections.service.test.ts

@@ -283,4 +283,20 @@ describe('Test collections service', () => {
       },
       },
     ]);
     ]);
   });
   });
+
+  test('test deleteEntities method', async () => {
+    const mockParam = {
+      collection_name: 'c1',
+      expr: 'age > 7',
+    };
+
+    const res = await service.deleteEntities(mockParam);
+    expect(res.data).toEqual(mockParam);
+
+    try {
+      await service.deleteEntities({ collection_name: '', expr: '' });
+    } catch (err) {
+      expect(err).toBe(ERR_NO_COLLECTION);
+    }
+  });
 });
 });

+ 1 - 0
express/src/collections/collections.service.ts

@@ -88,6 +88,7 @@ export class CollectionsService {
 
 
   async deleteEntities(data: DeleteEntitiesReq) {
   async deleteEntities(data: DeleteEntitiesReq) {
     const res = await this.dataManager.deleteEntities(data);
     const res = await this.dataManager.deleteEntities(data);
+    throwErrorFromSDK(res.status);
     return res;
     return res;
   }
   }