Browse Source

modify testcases and pom (#403)

yongpengli-z 2 years ago
parent
commit
36eb3c8037
20 changed files with 75 additions and 83 deletions
  1. 1 1
      tests/milvustest/pom.xml
  2. 2 0
      tests/milvustest/src/main/java/com/zilliz/milvustest/common/CommonData.java
  3. 0 3
      tests/milvustest/src/main/java/com/zilliz/milvustest/service/CustomerListener.java
  4. 1 1
      tests/milvustest/src/test/java/com/zilliz/milvustest/compaction/GetCompactionStateTest.java
  5. 1 1
      tests/milvustest/src/test/java/com/zilliz/milvustest/compaction/GetCompactionStateWithPlansTest.java
  6. 9 13
      tests/milvustest/src/test/java/com/zilliz/milvustest/compaction/ManualCompactionTest.java
  7. 11 1
      tests/milvustest/src/test/java/com/zilliz/milvustest/load/BulkLoadStateTest.java
  8. 5 3
      tests/milvustest/src/test/java/com/zilliz/milvustest/load/ListBulkInsertTasksTest.java
  9. 1 1
      tests/milvustest/src/test/java/com/zilliz/milvustest/other/LoadBalanceTest.java
  10. 2 0
      tests/milvustest/src/test/java/com/zilliz/milvustest/partition/DropPartitionTest.java
  11. 1 1
      tests/milvustest/src/test/java/com/zilliz/milvustest/partition/GetPartitionStatisticsTest.java
  12. 12 0
      tests/milvustest/src/test/java/com/zilliz/milvustest/partition/LoadPartitionsTest.java
  13. 3 2
      tests/milvustest/src/test/java/com/zilliz/milvustest/rbac/AddUserToRoleTest.java
  14. 3 2
      tests/milvustest/src/test/java/com/zilliz/milvustest/rbac/CreateRoleTest.java
  15. 2 2
      tests/milvustest/src/test/java/com/zilliz/milvustest/rbac/DropRoleTest.java
  16. 0 30
      tests/milvustest/src/test/java/com/zilliz/milvustest/rbac/GrantRolePrivilegeTest.java
  17. 17 13
      tests/milvustest/src/test/java/com/zilliz/milvustest/rbac/SelectGrantForRoleAndObject.java
  18. 3 3
      tests/milvustest/src/test/java/com/zilliz/milvustest/rbac/SelectGrantForRoleTest.java
  19. 1 1
      tests/milvustest/src/test/java/resources/run.properties
  20. 0 5
      tests/milvustest/src/test/java/resources/testdata/privilege.json

+ 1 - 1
tests/milvustest/pom.xml

@@ -84,7 +84,7 @@
         <dependency>
             <groupId>io.milvus</groupId>
             <artifactId>milvus-sdk-java</artifactId>
-            <version>2.1.0-beta4</version>
+            <version>2.2.0-beta1</version>
         </dependency>
         <!--Allure-->
         <dependency>

+ 2 - 0
tests/milvustest/src/main/java/com/zilliz/milvustest/common/CommonData.java

@@ -28,4 +28,6 @@ public class CommonData {
   public static String defaultColJson = "colJson";
   public static String defaultColStrJson = "colStrJson";
   public static String defaultRoleName = "roleTest";
+  public static String defaultRoleName2 = "roleTest2";
 }
+

+ 0 - 3
tests/milvustest/src/main/java/com/zilliz/milvustest/service/CustomerListener.java

@@ -8,12 +8,9 @@ import org.slf4j.LoggerFactory;
 import org.testng.ITestContext;
 import org.testng.ITestResult;
 import org.testng.TestListenerAdapter;
-import sun.util.resources.LocaleData;
 
 import java.text.DecimalFormat;
 import java.time.LocalDate;
-import java.util.HashMap;
-import java.util.Map;
 
 public class CustomerListener extends TestListenerAdapter {
   private static final Logger logger = LoggerFactory.getLogger(CustomerListener.class);

+ 1 - 1
tests/milvustest/src/test/java/com/zilliz/milvustest/compaction/GetCompactionStateTest.java

@@ -35,7 +35,7 @@ public class GetCompactionStateTest extends BaseTest {
             GetCompactionStateParam.newBuilder().withCompactionID(compactionId).build());
     Assert.assertEquals(responseR.getStatus().intValue(), 0);
     GetCompactionStateResponse data = responseR.getData();
-    Assert.assertEquals(data.getState(), CompactionState.Completed);
+    Assert.assertTrue(data.getState().equals( CompactionState.Completed)||data.getState().equals( CompactionState.Executing));
   }
 
   @Severity(SeverityLevel.NORMAL)

+ 1 - 1
tests/milvustest/src/test/java/com/zilliz/milvustest/compaction/GetCompactionStateWithPlansTest.java

@@ -37,6 +37,6 @@ public class GetCompactionStateWithPlansTest extends BaseTest {
         milvusClient.getCompactionStateWithPlans(
             GetCompactionPlansParam.newBuilder().withCompactionID(compactionId).build());
     Assert.assertEquals(responseR.getStatus().intValue(), 0);
-    Assert.assertEquals(responseR.getData().getState(), CompactionState.Completed);
+    Assert.assertTrue(responseR.getData().getState().equals( CompactionState.Completed)||responseR.getData().getState().equals( CompactionState.Executing));
   }
 }

+ 9 - 13
tests/milvustest/src/test/java/com/zilliz/milvustest/compaction/ManualCompactionTest.java

@@ -54,27 +54,23 @@ public class ManualCompactionTest extends BaseTest {
   }
 
   @Severity(SeverityLevel.BLOCKER)
-  @Test(description = "performs a manual compaction.",groups = {"Smoke"})
+  @Test(
+      description = "performs a manual compaction.",
+      groups = {"Smoke"})
   public void manualCompactionTest() {
     R<ManualCompactionResponse> responseR =
         milvusClient.manualCompact(
-            ManualCompactParam.newBuilder()
-                .withCollectionName(collection)
-                .build());
+            ManualCompactParam.newBuilder().withCollectionName(collection).build());
     Assert.assertEquals(responseR.getStatus().intValue(), 0);
     Assert.assertTrue(responseR.getData().getCompactionID() > 0);
     long compactionID = responseR.getData().getCompactionID();
     R<GetCompactionStateResponse> GetCompactionStateResponse =
-            milvusClient.getCompactionState(
-                    GetCompactionStateParam.newBuilder().withCompactionID(compactionID).build());
+        milvusClient.getCompactionState(
+            GetCompactionStateParam.newBuilder().withCompactionID(compactionID).build());
     Assert.assertEquals(GetCompactionStateResponse.getStatus().intValue(), 0);
-    Assert.assertEquals(GetCompactionStateResponse.getData().getState(), CompactionState.Executing);
-    R<GetCompactionPlansResponse> GetCompactionPlansResponse =
-            milvusClient.getCompactionStateWithPlans(
-                    GetCompactionPlansParam.newBuilder().withCompactionID(compactionID).build());
-    Assert.assertEquals(GetCompactionPlansResponse.getStatus().intValue(), 0);
-    Assert.assertEquals(GetCompactionPlansResponse.getData().getState(),CompactionState.Executing);
-  }
+    Assert.assertTrue(GetCompactionStateResponse.getData().getState().equals(CompactionState.Executing)||
+            GetCompactionStateResponse.getData().getState().equals(CompactionState.Completed));
+   }
 
   @Severity(SeverityLevel.NORMAL)
   @Test(description = "manual compaction with nonexistent collection")

+ 11 - 1
tests/milvustest/src/test/java/com/zilliz/milvustest/load/bulkloadStateTest.java → tests/milvustest/src/test/java/com/zilliz/milvustest/load/BulkLoadStateTest.java

@@ -19,6 +19,7 @@ import io.qameta.allure.Feature;
 import io.qameta.allure.Severity;
 import io.qameta.allure.SeverityLevel;
 import org.testng.Assert;
+import org.testng.annotations.BeforeClass;
 import org.testng.annotations.DataProvider;
 import org.testng.annotations.Test;
 
@@ -34,7 +35,16 @@ import java.util.Optional;
  */
 @Epic("Import")
 @Feature("GetImportState")
-public class bulkloadStateTest extends BaseTest {
+public class BulkLoadStateTest extends BaseTest {
+  @BeforeClass
+  public void generateJsonFiles(){
+    BulkInsertTest bulkInsertTest=new BulkInsertTest();
+    try {
+      bulkInsertTest.generateJsonFiles();
+    } catch (IOException | NoSuchAlgorithmException | InvalidKeyException e) {
+      logger.error(e.getMessage());
+    }
+  }
 
   @DataProvider(name = "bigRowJsonTaskId")
   public Object[][] bigRowBasedTask()

+ 5 - 3
tests/milvustest/src/test/java/com/zilliz/milvustest/load/ListBulkInsertTasksTest.java

@@ -28,8 +28,8 @@ public class ListBulkInsertTasksTest extends BaseTest {
                 BulkInsertParam.newBuilder()
                 .withCollectionName(CommonData.defaultCollection)
                 .addFile("rowJson0.json")
-                .addFile("rowJson1.json")
                 .build());
+    logger.info("importResponseR:"+importResponseR);
   }
 
   @Severity(SeverityLevel.BLOCKER)
@@ -38,8 +38,10 @@ public class ListBulkInsertTasksTest extends BaseTest {
       groups = {"Smoke"})
   public void ListImportTasksTest() {
     R<ListImportTasksResponse> listImportTasksResponseR =
-        milvusClient.listBulkInsertTasks(ListBulkInsertTasksParam.newBuilder().build());
+        milvusClient.listBulkInsertTasks(ListBulkInsertTasksParam.newBuilder()
+                .withCollectionName(CommonData.defaultCollection)
+                .withLimit(1).build());
     Assert.assertEquals(listImportTasksResponseR.getStatus().intValue(), 0);
-    Assert.assertTrue(listImportTasksResponseR.getData().getTasksList().size() > 1);
+    Assert.assertTrue(listImportTasksResponseR.getData().getTasksList().size() == 1);
   }
 }

+ 1 - 1
tests/milvustest/src/test/java/com/zilliz/milvustest/other/LoadBalanceTest.java

@@ -26,7 +26,7 @@ import java.util.List;
 public class LoadBalanceTest extends BaseTest {
   @Severity(SeverityLevel.BLOCKER)
   @Issue("https://github.com/milvus-io/milvus-sdk-java/issues/356")
-  @Test(description = "Moves segment from a query node to another to keep the load balanced.",groups = {"Smoke"})
+  @Test(description = "Moves segment from a query node to another to keep the load balanced.",groups = {"Smoke"},enabled = false)
   public void loadBalanceTest() {
     // insert
     List<InsertParam.Field> fields = CommonFunction.generateData(3000);

+ 2 - 0
tests/milvustest/src/test/java/com/zilliz/milvustest/partition/DropPartitionTest.java

@@ -8,6 +8,7 @@ import io.milvus.grpc.QueryResults;
 import io.milvus.param.R;
 import io.milvus.param.RpcStatus;
 import io.milvus.param.collection.LoadCollectionParam;
+import io.milvus.param.collection.ReleaseCollectionParam;
 import io.milvus.param.dml.QueryParam;
 import io.milvus.param.partition.*;
 import io.qameta.allure.Epic;
@@ -41,6 +42,7 @@ public class DropPartitionTest extends BaseTest {
   @Severity(SeverityLevel.BLOCKER)
   @Test(description = "drop partition", dataProvider = "partitionName",groups = {"Smoke"})
   public void dropPartition(String partitionName) {
+    milvusClient.releaseCollection(ReleaseCollectionParam.newBuilder().withCollectionName(CommonData.defaultCollection).build());
     R<RpcStatus> rpcStatusR =
         milvusClient.dropPartition(
             DropPartitionParam.newBuilder()

+ 1 - 1
tests/milvustest/src/test/java/com/zilliz/milvustest/partition/GetPartitionStatisticsTest.java

@@ -59,7 +59,7 @@ public class GetPartitionStatisticsTest extends BaseTest {
         milvusClient.getPartitionStatistics(
             GetPartitionStatisticsParam.newBuilder()
                 .withCollectionName(CommonData.defaultCollection)
-                .withPartitionName(partition)
+                .withPartitionName(partition).withFlush(true)
                 .build());
     Assert.assertEquals(partitionStatisticsResponseR.getStatus().intValue(), 0);
     GetPartitionStatisticsResponse partitionStatisticsResponse =

+ 12 - 0
tests/milvustest/src/test/java/com/zilliz/milvustest/partition/LoadPartitionsTest.java

@@ -4,9 +4,12 @@ import com.zilliz.milvustest.common.BaseTest;
 import com.zilliz.milvustest.common.CommonData;
 import com.zilliz.milvustest.common.CommonFunction;
 import com.zilliz.milvustest.util.MathUtil;
+import io.milvus.param.IndexType;
+import io.milvus.param.MetricType;
 import io.milvus.param.R;
 import io.milvus.param.RpcStatus;
 import io.milvus.param.collection.DropCollectionParam;
+import io.milvus.param.index.CreateIndexParam;
 import io.milvus.param.partition.CreatePartitionParam;
 import io.milvus.param.partition.DropPartitionParam;
 import io.milvus.param.partition.LoadPartitionsParam;
@@ -21,6 +24,7 @@ import org.testng.annotations.BeforeClass;
 import org.testng.annotations.Test;
 
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
 
 @Epic("Partition")
@@ -45,10 +49,18 @@ public class LoadPartitionsTest extends BaseTest {
                     .withCollectionName(collection)
                     .withPartitionName(partition2)
                     .build());
+    milvusClient.createIndex(CreateIndexParam.newBuilder().withCollectionName(collection)
+            .withFieldName(CommonData.defaultVectorField)
+            .withIndexType(IndexType.HNSW)
+            .withMetricType(MetricType.L2)
+            .withExtraParam(CommonFunction.provideExtraParam(IndexType.HNSW)).build());
   }
 
   @AfterClass(description = "delete partition after test",alwaysRun = true)
   public void deletePartition() {
+    milvusClient.releasePartitions(ReleasePartitionsParam.newBuilder()
+            .withCollectionName(collection)
+            .withPartitionNames(Arrays.asList(partition,partition2)).build());
     milvusClient.dropPartition(
         DropPartitionParam.newBuilder()
             .withCollectionName(collection)

+ 3 - 2
tests/milvustest/src/test/java/com/zilliz/milvustest/rbac/AddUserToRoleTest.java

@@ -25,8 +25,9 @@ import org.testng.annotations.Test;
 public class AddUserToRoleTest extends BaseTest {
   @BeforeClass
   public void initCreateRole() {
-    milvusClient.createRole(
-        CreateRoleParam.newBuilder().withRoleName(CommonData.defaultRoleName).build());
+    R<RpcStatus> role = milvusClient.createRole(
+            CreateRoleParam.newBuilder().withRoleName(CommonData.defaultRoleName).build());
+    logger.info("role:"+role);
   }
 
   @AfterClass

+ 3 - 2
tests/milvustest/src/test/java/com/zilliz/milvustest/rbac/CreateRoleTest.java

@@ -19,11 +19,12 @@ import org.testng.annotations.Test;
  */
 @Epic("Role")
 @Feature("CreateRole")
+
 public class CreateRoleTest extends BaseTest {
   @AfterClass
   public void removeTestData() {
     milvusClient.dropRole(
-        DropRoleParam.newBuilder().withRoleName(CommonData.defaultRoleName).build());
+        DropRoleParam.newBuilder().withRoleName("newRole").build());
   }
 
   @Severity(SeverityLevel.BLOCKER)
@@ -33,7 +34,7 @@ public class CreateRoleTest extends BaseTest {
   public void createRole() {
     R<RpcStatus> role =
         milvusClient.createRole(
-            CreateRoleParam.newBuilder().withRoleName(CommonData.defaultRoleName).build());
+            CreateRoleParam.newBuilder().withRoleName("newRole").build());
     Assert.assertEquals(role.getStatus().intValue(), 0);
     Assert.assertEquals(role.getData().getMsg(), "Success");
   }

+ 2 - 2
tests/milvustest/src/test/java/com/zilliz/milvustest/rbac/DropRoleTest.java

@@ -23,7 +23,7 @@ public class DropRoleTest extends BaseTest {
 
   @BeforeClass
   public void initCreateRole() {
-    milvusClient.createRole(CreateRoleParam.newBuilder().withRoleName(CommonData.defaultRoleName).build());
+    milvusClient.createRole(CreateRoleParam.newBuilder().withRoleName("newRoleName").build());
   }
 
   @Severity(SeverityLevel.BLOCKER)
@@ -32,7 +32,7 @@ public class DropRoleTest extends BaseTest {
       groups = {"Smoke"})
   public void dropRole() {
     R<RpcStatus> rpcStatusR =
-        milvusClient.dropRole(DropRoleParam.newBuilder().withRoleName(CommonData.defaultRoleName).build());
+        milvusClient.dropRole(DropRoleParam.newBuilder().withRoleName("newRoleName").build());
     Assert.assertEquals(rpcStatusR.getStatus().intValue(), 0);
     Assert.assertEquals(rpcStatusR.getData().getMsg(), "Success");
   }

+ 0 - 30
tests/milvustest/src/test/java/com/zilliz/milvustest/rbac/GrantRolePrivilegeTest.java

@@ -118,35 +118,5 @@ public class GrantRolePrivilegeTest extends BaseTest {
                 .build());
     Assert.assertEquals(rpcStatusR.getStatus().intValue(), 0);
     Assert.assertEquals(rpcStatusR.getData().getMsg(), "Success");
-    MilvusServiceClient milvusServiceClient = CommonFunction.newMilvusClient(CommonData.defaultUserName, CommonData.defaultPassword);
-    collectionName = "Collection_" + MathUtil.getRandomString(10);
-    FieldType fieldType1 =
-            FieldType.newBuilder()
-                    .withName("book_id")
-                    .withDataType(DataType.Int64)
-                    .withPrimaryKey(true)
-                    .withAutoID(true)
-                    .build();
-    FieldType fieldType2 =
-            FieldType.newBuilder().withName("word_count").withDataType(DataType.Int64).build();
-    FieldType fieldType3 =
-            FieldType.newBuilder()
-                    .withName(CommonData.defaultVectorField)
-                    .withDataType(DataType.FloatVector)
-                    .withDimension(128)
-                    .build();
-    CreateCollectionParam createCollectionReq =
-            CreateCollectionParam.newBuilder()
-                    .withCollectionName(collectionName)
-                    .withDescription("Test" + collectionName + "search")
-                    .withShardsNum(2)
-                    .addFieldType(fieldType1)
-                    .addFieldType(fieldType2)
-                    .addFieldType(fieldType3)
-                    .build();
-    R<RpcStatus> collection = milvusServiceClient.createCollection(createCollectionReq);
-    Assert.assertEquals(collection.getStatus().intValue(),0);
-    R<RpcStatus> rpcStatusR1 = milvusServiceClient.loadCollection(LoadCollectionParam.newBuilder().withCollectionName(CommonData.defaultCollection).build());
-    Assert.assertTrue(rpcStatusR1.getMessage().contains("permission deny"));
   }
 }

+ 17 - 13
tests/milvustest/src/test/java/com/zilliz/milvustest/rbac/SelectGrantForRoleAndObject.java

@@ -4,6 +4,7 @@ import com.zilliz.milvustest.common.BaseTest;
 import com.zilliz.milvustest.common.CommonData;
 import io.milvus.grpc.SelectGrantResponse;
 import io.milvus.param.R;
+import io.milvus.param.RpcStatus;
 import io.milvus.param.role.*;
 import io.qameta.allure.Epic;
 import io.qameta.allure.Feature;
@@ -22,28 +23,30 @@ import org.testng.annotations.Test;
 public class SelectGrantForRoleAndObject extends BaseTest {
   @BeforeClass
   public void initTestData() {
-    milvusClient.createRole(
-        CreateRoleParam.newBuilder().withRoleName(CommonData.defaultRoleName).build());
-    milvusClient.grantRolePrivilege(
-        GrantRolePrivilegeParam.newBuilder()
-            .withRoleName(CommonData.defaultRoleName)
-            .withObject("Collection")
-            .withObjectName(CommonData.defaultCollection)
-            .withPrivilege("Load")
-            .build());
+      R<RpcStatus> newRole = milvusClient.createRole(
+              CreateRoleParam.newBuilder().withRoleName("newRole").build());
+      logger.info("newRole:"+newRole);
+      R<RpcStatus> rpcStatusR = milvusClient.grantRolePrivilege(
+              GrantRolePrivilegeParam.newBuilder()
+                      .withRoleName("newRole")
+                      .withObject("Collection")
+                      .withObjectName(CommonData.defaultCollection)
+                      .withPrivilege("Load")
+                      .build());
+      logger.info("rpcStatusR:"+rpcStatusR);
   }
 
   @AfterClass
   public void removeTestData() {
     milvusClient.revokeRolePrivilege(
         RevokeRolePrivilegeParam.newBuilder()
-            .withRoleName(CommonData.defaultRoleName)
+            .withRoleName("newRole")
             .withObject("Collection")
             .withObjectName(CommonData.defaultCollection)
             .withPrivilege("Load")
             .build());
     milvusClient.dropRole(
-        DropRoleParam.newBuilder().withRoleName(CommonData.defaultRoleName).build());
+        DropRoleParam.newBuilder().withRoleName("newRole").build());
   }
 
   @Severity(SeverityLevel.BLOCKER)
@@ -53,14 +56,15 @@ public class SelectGrantForRoleAndObject extends BaseTest {
   public void selectGrantForRoleAndObject() {
       R<SelectGrantResponse> selectGrantResponseR = milvusClient.selectGrantForRoleAndObject(
               SelectGrantForRoleAndObjectParam.newBuilder()
-                      .withRoleName(CommonData.defaultRoleName)
+                      .withRoleName("newRole")
                       .withObject("Collection")
                       .withObjectName(CommonData.defaultCollection)
                       .build());
+      logger.info("selectGrantResponseR"+selectGrantResponseR);
       Assert.assertEquals(selectGrantResponseR.getStatus().intValue(), 0);
       Assert.assertEquals(
               selectGrantResponseR.getData().getEntities(0).getRole().getName(),
-              CommonData.defaultRoleName);
+              "newRole");
       Assert.assertEquals(
               selectGrantResponseR.getData().getEntities(0).getObject().getName(), "Collection");
       Assert.assertEquals(selectGrantResponseR.getData().getEntities(0).getObjectName(), CommonData.defaultCollection);

+ 3 - 3
tests/milvustest/src/test/java/com/zilliz/milvustest/rbac/SelectGrantForRoleTest.java

@@ -54,12 +54,12 @@ public class SelectGrantForRoleTest extends BaseTest {
     R<SelectGrantResponse> selectGrantResponseR =
         milvusClient.selectGrantForRole(
             SelectGrantForRoleParam.newBuilder().withRoleName(CommonData.defaultRoleName).build());
+    logger.info("selectGrantResponseR"+selectGrantResponseR);
     Assert.assertEquals(selectGrantResponseR.getStatus().intValue(), 0);
     Assert.assertEquals(
         selectGrantResponseR.getData().getEntities(0).getRole().getName(),
         CommonData.defaultRoleName);
-    Assert.assertEquals(
-        selectGrantResponseR.getData().getEntities(0).getObject().getName(), "Global");
-    Assert.assertEquals(selectGrantResponseR.getData().getEntities(0).getObjectName(), "*");
+    Assert.assertTrue(
+        selectGrantResponseR.getData().getEntitiesCount()>1);
   }
 }

+ 1 - 1
tests/milvustest/src/test/java/resources/run.properties

@@ -4,7 +4,7 @@ milvusPort=19530
 milvusV=2.1.0
 milvusJdkJavaV=2.1.0
 #minio
-minioHost=http://10.102.5.231:9000
+minioHost=http://10.102.5.200:9000
 accesskey=minioadmin
 secretkey=minioadmin
 

+ 0 - 5
tests/milvustest/src/test/java/resources/testdata/privilege.json

@@ -14,11 +14,6 @@
     "objectName":"*",
     "privilege":"DescribeCollection"
   },
-  {
-    "object":"Collection",
-    "objectName":"*",
-    "privilege":"DescribePartition"
-  },
   {
     "object":"Collection",
     "objectName":"*",