deleteIds Marked as deprecated (#679)

Signed-off-by: lentitude2tk <xushuang.hu@zilliz.com>

src/main/java/io/milvus/client/AbstractMilvusGrpcClient.java

@@ -2974,7 +2974,7 @@ public abstract class AbstractMilvusGrpcClient implements MilvusClient {
                     .build();
             R<MutationResult> resultR = delete(deleteParam);
             MutationResultWrapper resultWrapper = new MutationResultWrapper(resultR.getData());
-            return R.success(DeleteResponse.builder().deleteIds(resultWrapper.getInsertIDs()).build());
+            return R.success(DeleteResponse.builder().deleteIds(resultWrapper.getDeleteIDs()).build());
         } catch (StatusRuntimeException e) {
             logError("Delete RPC failed! Collection name:{}",
                     requestParam.getCollectionName(), e);

src/main/java/io/milvus/param/highlevel/dml/response/DeleteResponse.java

@@ -32,5 +32,10 @@ import java.util.List;
 @Getter
 @ToString
 public class DeleteResponse {
+    /**
+     * In the new version(>=2.3.2), this method only returns an empty list and does not return specific values
+     * Mark is as deprecated, keep it to compatible with the legacy code
+     */
+    @Deprecated
     public List<?> deleteIds;
 }

src/main/java/io/milvus/response/MutationResultWrapper.java

@@ -1,5 +1,6 @@
 package io.milvus.response;
 
+import com.google.common.collect.Lists;
 import io.milvus.exception.ParamException;
 import io.milvus.grpc.MutationResult;
 
@@ -70,6 +71,21 @@ public class MutationResultWrapper {
         }
     }
 
+    /**
+     * Gets the ID array from returned by delete interface.
+     *
+     * @return List of Ids, ID array returned by delete interface
+     */
+    public List<?> getDeleteIDs() {
+        if (result.getIDs().hasIntId()) {
+            return result.getIDs().getIntId().getDataList();
+        } else if (result.getIDs().hasStrId()) {
+            return result.getIDs().getStrId().getDataList();
+        } else {
+            return Lists.newArrayList();
+        }
+    }
+
     /**
      * Gets the row count of the deleted entities. Currently, this value is always equal to input row count
      *

src/test/java/io/milvus/client/MilvusClientDockerTest.java

@@ -2107,6 +2107,5 @@ class MilvusClientDockerTest {
         String outPutStr = String.format("collectionName:%s, primaryIds:%s, deleteResponseR:%s", collectionName, primaryIds, deleteResponseR);
         System.out.println(outPutStr);
         Assertions.assertEquals(R.Status.Success.getCode(), deleteResponseR.getStatus().intValue());
-        Assertions.assertEquals(primaryIds.size(), deleteResponseR.getData().getDeleteIds().size());
     }
 }

tests/milvustest/src/test/java/com/zilliz/milvustest/serverless/HighLevelTest.java

@@ -137,7 +137,6 @@ public class HighLevelTest extends BaseTest {
                 .withPrimaryIds(integers)
                 .build());
         Assert.assertEquals(delete.getStatus().intValue(), R.Status.Success.getCode());
-        Assert.assertEquals(delete.getData().getDeleteIds().size(), integers.size());
     }
 
     @Severity(SeverityLevel.BLOCKER)
@@ -240,7 +239,6 @@ public class HighLevelTest extends BaseTest {
                 .withPrimaryIds(pks)
                 .build());
         Assert.assertEquals(delete.getStatus().intValue(), R.Status.Success.getCode());
-        Assert.assertEquals(delete.getData().getDeleteIds().size(), pks.size());
     }