Browse Source

Fix testcontainers dependency scope (#991) (#995)

* Fix testcontainers dependency scope (#991)

* Fix testcontainers dependency scope

Testcontainers must have a test scope. Currently, it is a transitive
dependency.

Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>

* Use BOM

Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>

---------

Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>

* Fix import

Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>

---------

Signed-off-by: Eddú Meléndez <eddu.melendez@gmail.com>
Eddú Meléndez Gonzales 11 months ago
parent
commit
756f9561a5

+ 10 - 3
pom.xml

@@ -94,7 +94,7 @@
         <gson.version>2.10.1</gson.version>
         <kotlin.version>1.9.10</kotlin.version>
         <mockito.version>4.11.0</mockito.version>
-        <testcontainers.version>1.19.6</testcontainers.version>
+        <testcontainers.version>1.19.8</testcontainers.version>
 
         <hadoop.version>3.3.6</hadoop.version>
         <hbase.version>1.2.0</hbase.version>
@@ -170,6 +170,13 @@
                 <artifactId>snappy-java</artifactId>
                 <version>${snappy.version}</version>
             </dependency>
+            <dependency>
+                <groupId>org.testcontainers</groupId>
+                <artifactId>testcontainers-bom</artifactId>
+                <version>${testcontainers.version}</version>
+                <type>pom</type>
+                <scope>import</scope>
+            </dependency>
         </dependencies>
     </dependencyManagement>
 
@@ -253,7 +260,7 @@
         <dependency>
             <groupId>org.testcontainers</groupId>
             <artifactId>milvus</artifactId>
-            <version>${testcontainers.version}</version>
+            <scope>test</scope>
             <exclusions>
                 <exclusion>
                     <groupId>org.slf4j</groupId>
@@ -268,7 +275,7 @@
         <dependency>
             <groupId>org.testcontainers</groupId>
             <artifactId>junit-jupiter</artifactId>
-            <version>${testcontainers.version}</version>
+            <scope>test</scope>
         </dependency>
         <dependency>
             <groupId>org.projectlombok</groupId>

+ 1 - 1
src/main/java/io/milvus/response/DescCollResponseWrapper.java

@@ -27,7 +27,7 @@ import io.milvus.param.ParamUtils;
 import io.milvus.param.collection.CollectionSchemaParam;
 import io.milvus.param.collection.FieldType;
 import lombok.NonNull;
-import org.testcontainers.shaded.org.bouncycastle.util.Strings;
+import org.bouncycastle.util.Strings;
 
 import java.util.*;
 

+ 1 - 1
src/main/java/io/milvus/response/DescDBResponseWrapper.java

@@ -29,7 +29,7 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
-import org.testcontainers.shaded.org.bouncycastle.util.Strings;
+import org.bouncycastle.util.Strings;
 
 /**
  * Util class to wrap response of <code>describeCollection</code> interface.