Browse Source

Simplify `loadCollection`

jianghua 4 years ago
parent
commit
ba0fe7ace8

+ 1 - 3
src/main/java/io/milvus/client/MilvusClient.java

@@ -312,10 +312,8 @@ public interface MilvusClient {
    * Pre-loads collection to memory
    *
    * @param collectionName collection to load
-   * @return <code>Response</code>
-   * @see Response
    */
-  Response loadCollection(String collectionName);
+  void loadCollection(String collectionName);
 
   /**
    * Drops collection index

+ 6 - 25
src/main/java/io/milvus/client/MilvusGrpcClient.java

@@ -400,31 +400,12 @@ abstract class AbstractMilvusGrpcClient implements MilvusClient {
   }
 
   @Override
-  public Response loadCollection(@Nonnull String collectionName) {
-
-    if (!maybeAvailable()) {
-      logWarning("You are not connected to Milvus server");
-      return new Response(Response.Status.CLIENT_NOT_CONNECTED);
-    }
-
-    CollectionName request = CollectionName.newBuilder().setCollectionName(collectionName).build();
-    Status response;
-
-    try {
-      response = blockingStub().preloadCollection(request);
-
-      if (response.getErrorCode() == ErrorCode.SUCCESS) {
-        logInfo("Loaded collection `{}` successfully!", collectionName);
-        return new Response(Response.Status.SUCCESS);
-      } else {
-        logError("Load collection `{}` failed:\n{}", collectionName, response.toString());
-        return new Response(
-            Response.Status.valueOf(response.getErrorCodeValue()), response.getReason());
-      }
-    } catch (StatusRuntimeException e) {
-      logError("loadCollection RPC failed:\n{}", e.getStatus().toString());
-      return new Response(Response.Status.RPC_ERROR, e.toString());
-    }
+  public void loadCollection(@Nonnull String collectionName) {
+    translateExceptions(() -> {
+      CollectionName request = CollectionName.newBuilder().setCollectionName(collectionName).build();
+      Status response = blockingStub().preloadCollection(request);
+      checkResponseStatus(response);
+    });
   }
 
   @Override

+ 1 - 3
src/test/java/io/milvus/client/MilvusGrpcClientTest.java

@@ -646,9 +646,7 @@ class MilvusClientTest {
   void loadCollection() {
     insert();
     assertTrue(client.flush(randomCollectionName).ok());
-
-    Response loadCollectionResponse = client.loadCollection(randomCollectionName);
-    assertTrue(loadCollectionResponse.ok());
+    client.loadCollection(randomCollectionName);
   }
 
   @org.junit.jupiter.api.Test