Browse Source

Simplify `createPartition`

jianghua 4 years ago
parent
commit
d74d6a5627

+ 1 - 3
src/main/java/io/milvus/client/MilvusClient.java

@@ -151,10 +151,8 @@ public interface MilvusClient {
    *
    * @param collectionName collection name
    * @param tag partition tag
-   * @return <code>Response</code>
-   * @see Response
    */
-  Response createPartition(String collectionName, String tag);
+  void createPartition(String collectionName, String tag);
 
   /**
    * Checks whether the partition exists

+ 6 - 31
src/main/java/io/milvus/client/MilvusGrpcClient.java

@@ -286,37 +286,12 @@ abstract class AbstractMilvusGrpcClient implements MilvusClient {
   }
 
   @Override
-  public Response createPartition(String collectionName, String tag) {
-
-    if (!maybeAvailable()) {
-      logWarning("You are not connected to Milvus server");
-      return new Response(Response.Status.CLIENT_NOT_CONNECTED);
-    }
-
-    PartitionParam request =
-        PartitionParam.newBuilder().setCollectionName(collectionName).setTag(tag).build();
-
-    Status response;
-
-    try {
-      response = blockingStub().createPartition(request);
-
-      if (response.getErrorCode() == ErrorCode.SUCCESS) {
-        logInfo("Created partition `{}` in collection `{}` successfully!", tag, collectionName);
-        return new Response(Response.Status.SUCCESS);
-      } else {
-        logError(
-            "Create partition `{}` in collection `{}` failed: {}",
-            tag,
-            collectionName,
-            response.toString());
-        return new Response(
-            Response.Status.valueOf(response.getErrorCodeValue()), response.getReason());
-      }
-    } catch (StatusRuntimeException e) {
-      logError("createPartition RPC failed:\n{}", e.getStatus().toString());
-      return new Response(Response.Status.RPC_ERROR, e.toString());
-    }
+  public void createPartition(String collectionName, String tag) {
+    translateExceptions(() -> {
+      PartitionParam request = PartitionParam.newBuilder().setCollectionName(collectionName).setTag(tag).build();
+      Status response = blockingStub().createPartition(request);
+      checkResponseStatus(response);
+    });
   }
 
   @Override

+ 2 - 4
src/test/java/io/milvus/client/MilvusGrpcClientTest.java

@@ -356,12 +356,10 @@ class MilvusClientTest {
   @SuppressWarnings("unchecked")
   void partitionTest() {
     final String tag1 = "tag1";
-    Response createPartitionResponse = client.createPartition(randomCollectionName, tag1);
-    assertTrue(createPartitionResponse.ok());
+    client.createPartition(randomCollectionName, tag1);
 
     final String tag2 = "tag2";
-    createPartitionResponse = client.createPartition(randomCollectionName, tag2);
-    assertTrue(createPartitionResponse.ok());
+    client.createPartition(randomCollectionName, tag2);
 
     ListPartitionsResponse listPartitionsResponse = client.listPartitions(randomCollectionName);
     assertTrue(listPartitionsResponse.ok());