Просмотр исходного кода

Rename segment_row_count to segment_row_limit

jianghua 4 лет назад
Родитель
Сommit
f0b6975805

+ 1 - 1
examples/src/main/java/MilvusClientExample.java

@@ -145,7 +145,7 @@ public class MilvusClientExample {
     CollectionMapping collectionMapping =
         new CollectionMapping.Builder(collectionName)
             .withFields(generateDefaultFields(dimension))
-            .withParamsInJson("{\"segment_row_count\": 50000, \"auto_id\": true}")
+            .withParamsInJson("{\"segment_row_limit\": 50000, \"auto_id\": true}")
             .build();
     Response createCollectionResponse = client.createCollection(collectionMapping);
 

+ 1 - 1
src/main/java/io/milvus/client/CollectionMapping.java

@@ -118,7 +118,7 @@ public class CollectionMapping {
     /**
      * Build with extra params in json string format.
      *
-     * @param paramsInJson Two optional parameters can be included. "segment_row_count" is default
+     * @param paramsInJson Two optional parameters can be included. "segment_row_limit" is default
      *                     to 100,000. Merge will be triggered if more than this number of entities
      *                     are inserted into collection. "auto_id" is default to <code>true</code>.
      *                     Entity ids will be auto-generated by Milvus if set to true.

+ 1 - 1
src/main/java/io/milvus/client/MilvusClient.java

@@ -77,7 +77,7 @@ public interface MilvusClient {
    * <code>
    * CollectionMapping collectionMapping = new CollectionMapping.Builder(collectionName)
    *                                                            .withFields(fields)
-   *                                                            .withParamsInJson("{"segment_row_count": 100000}")
+   *                                                            .withParamsInJson("{"segment_row_limit": 100000}")
    *                                                            .build();
    * </code>
    * Refer to <code>withFields</code> method for example <code>fields</code> usage.

+ 2 - 2
src/main/proto/milvus.proto

@@ -63,9 +63,9 @@ message FieldName {
  * @brief Collection mapping
  * @extra_params: key-value pair for extra parameters of the collection
  *    typically usage:
- *        extra_params["params"] = {segment_row_count: 1000000, auto_id: true}
+ *        extra_params["params"] = {segment_row_limit: 1000000, auto_id: true}
  *    Note:
- *        the segment_row_count specify segment row count limit for merging
+ *        the segment_row_limit specify segment row count limit for merging
  *        the auto_id = true means entity id is auto-generated by milvus
  */
 message Mapping {

+ 3 - 3
src/test/java/io/milvus/client/MilvusGrpcClientTest.java

@@ -143,7 +143,7 @@ class MilvusClientTest {
             .field(new FieldBuilder("float_vec", DataType.VECTOR_FLOAT)
                 .param("dim", dimension)
                 .build())
-            .withParamsInJson(new JsonBuilder().param("segment_row_count", 50000)
+            .withParamsInJson(new JsonBuilder().param("segment_row_limit", 50000)
                                                .param("auto_id", false)
                                                .build())
             .build();
@@ -232,7 +232,7 @@ class MilvusClientTest {
     createCollectionResponse = client.createCollection(invalidCollectionMapping);
     assertFalse(createCollectionResponse.ok());
 
-    // invalid segment_row_count
+    // invalid segment_row_limit
     invalidCollectionMapping =
         new CollectionMapping.Builder("validCollectionName")
             .field(new FieldBuilder("int64", DataType.INT64).build())
@@ -240,7 +240,7 @@ class MilvusClientTest {
             .field(new FieldBuilder("float_vec", DataType.VECTOR_FLOAT)
                 .param("dim", dimension)
                 .build())
-            .withParamsInJson(new JsonBuilder().param("segment_row_count", -1000).build())
+            .withParamsInJson(new JsonBuilder().param("segment_row_limit", -1000).build())
             .build();
     createCollectionResponse = client.createCollection(invalidCollectionMapping);
     assertFalse(createCollectionResponse.ok());